Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1037087

Summary:	gksu-polkit FTBFS if "-Werror=format-security" flag is used
Product:	[Fedora] Fedora	Reporter:	Dhiru Kholia <dkholia>
Component:	gksu-polkit	Assignee:	Dan Mashal <dan.mashal>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	bressers, dan.mashal, dhiru, negativo17
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-06-11 09:06:36 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1038083, 1106631

Description Dhiru Kholia 2013-12-03 03:06:13 UTC

Description of problem
----------------------

gksu-polkit fails to build if "-Werror=format-security" flag is used.

...

gksu-server.c:228:7: error: format not a string literal and no format arguments [-Werror=format-security]

...

We are working on a proposal to enable "-Werror=format-security" for all
packages. Once this flag is enabled, GCC will refuse to compile code that could
be vulnerable to a string format security flaw. For more details, please see
https://fedorahosted.org/fesco/ticket/1185 page.

To understand why it is important to fix this, please see
https://fedoraproject.org/wiki/Format-Security-FAQ page.

How to fix this
---------------

The fix for these errors is quite simple. It's a matter of changing a
line like,

printf(foo);

to read,

printf("%s", foo);

That's it.

Please fix this issue in rawhide with a patch (which you should submit
to upstream to merge moving forward). Please do a new build with the
fix in rawhide. Other releases do not need to be directly fixed, but
there should be no harm in pushing out this fix/patch with other needed
changes to those branches.

In the event you don't fix this bug before the next mass rebuild,
provenpackagers may step in and update your package(s) to fix this
issue.

How reproducible
----------------

Build gksu-polkit-0.0.3-8.gitf8ce834c.fc21.src.rpm with "-Werror=format-security" flag to reproduce the problem.

To make this process easier, you can use a modified "redhat-rpm-config" package
from http://people.fedoraproject.org/~halfie/artifacts/redhat-rpm-config/ URL.

$ sha256sum redhat-rpm-config-9.1.0-56.fc20.*
faad7594b2080fe76497d0ce50808c905a93dd7b41c1defdde5ca57e3833d3d2 redhat-rpm-config-9.1.0-56.fc20.noarch.rpm
5aa9357174305c7285ffdbc92d7ffe1c07a8a95d5459b930461308f5aad75413 redhat-rpm-config-9.1.0-56.fc20.src.rpm

Comment 1 Dan Mashal 2013-12-04 23:42:24 UTC

Will probably retire.

Comment 2 Simone Caronni 2014-02-03 08:57:34 UTC

Can it(In reply to Dan Mashal from comment #1)
> Will probably retire.

I've just checked with repoquery which packages still require it and the list is empty. The package has some bugs and upstream is dead. Can we proceed into retiring it in rawhide?

Thanks,
--Simone

Comment 4 Simone Caronni 2014-06-10 10:08:34 UTC

Hello, can I proceed into retiring this? Or there are plans to revive it? The FTBFS bug has been created.

https://bugzilla.redhat.com/show_bug.cgi?id=1106631

--Simone

Comment 5 Simone Caronni 2014-06-10 10:10:53 UTC

Forgot to add this has also been retired in Ubuntu and Debian.

Comment 6 Simone Caronni 2014-06-11 09:06:36 UTC

I patched it and built it in rawhide, we can retire it before the first compose.

Comment 7 Red Hat Bugzilla 2023-09-12 00:26:49 UTC

The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days