Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1037297
Summary: | qt3 FTBFS if "-Werror=format-security" flag is used | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Dhiru Kholia <dkholia> |
Component: | qt3 | Assignee: | Than Ngo <than> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | bressers, kevin, rdieter, than |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | qt3-3.3.8b-56.fc21 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2014-01-14 03:53:13 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1038083 |
Description
Dhiru Kholia
2013-12-03 05:54:27 UTC
As I pointed out to FESCo, the 4 errors above are all false positives, "line.ascii()" contains only '-' characters, "buf" contains only '*' characters. But that's only the first file that fails, there are 4 more: * qgcache.cpp: also trivially false positives as above. * moc.y / moc_yacc.cpp: false positives, constant format strings in const char * variables. * qjpegio.cpp: This one may or may not be a problem depending on what libjpeg's format_message can return. That's the only one I'm unsure about. It's fixed now ("%s" added) in any case. * qsql_odbc.cpp: Arguably a bug, if a client program is really dumb enough to pass junk that may contain '%' characters where constant strings such as "SQL_MODE_READ_ONLY" are expected. Otherwise, false positives. I strongly doubt any client program makes this exploitable. This is the whole mess I had to commit to make the broken warning/error happy: http://pkgs.fedoraproject.org/cgit/qt3.git/tree/qt-x11-free-3.3.8b-%231037297.patch It took me about 2 hours to clean up this mess! |