Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1037298

Summary: quarry FTBFS if "-Werror=format-security" flag is used
Product: [Fedora] Fedora Reporter: Dhiru Kholia <dkholia>
Component: quarryAssignee: Michel Lind <michel>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 22CC: bressers, dennis, dhiru, michel, mjuszkie
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: quarry-0.2.0-18.fc22 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-08-07 13:09:42 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1038083, 926416, 1105908    
Attachments:
Description Flags
patch + spec changeset none

Description Dhiru Kholia 2013-12-03 05:54:34 UTC
Description of problem
----------------------

quarry fails to build if "-Werror=format-security" flag is used.

...

parse-list.c:165:7: error: format not a string literal and no format arguments [-Werror=format-security]

...

We are working on a proposal to enable "-Werror=format-security" for all
packages. Once this flag is enabled, GCC will refuse to compile code that could
be vulnerable to a string format security flaw. For more details, please see
https://fedorahosted.org/fesco/ticket/1185 page.

To understand why it is important to fix this, please see
https://fedoraproject.org/wiki/Format-Security-FAQ page.

How to fix this
---------------

The fix for these errors is quite simple. It's a matter of changing a
line like,

   printf(foo);

to read,

   printf("%s", foo);

That's it.

Please fix this issue in rawhide with a patch (which you should submit
to upstream to merge moving forward). Please do a new build with the
fix in rawhide. Other releases do not need to be directly fixed, but
there should be no harm in pushing out this fix/patch with other needed
changes to those branches.

In the event you don't fix this bug before the next mass rebuild,
provenpackagers may step in and update your package(s) to fix this
issue.

How reproducible
----------------

Build quarry-0.2.0-12.fc20.src.rpm with "-Werror=format-security" flag to reproduce the problem.

To make this process easier, you can use a modified "redhat-rpm-config" package
from http://people.fedoraproject.org/~halfie/artifacts/redhat-rpm-config/ URL.

$ sha256sum redhat-rpm-config-9.1.0-56.fc20.*
faad7594b2080fe76497d0ce50808c905a93dd7b41c1defdde5ca57e3833d3d2  redhat-rpm-config-9.1.0-56.fc20.noarch.rpm
5aa9357174305c7285ffdbc92d7ffe1c07a8a95d5459b930461308f5aad75413  redhat-rpm-config-9.1.0-56.fc20.src.rpm

Comment 2 Marcin Juszkiewicz 2014-10-03 11:42:33 UTC
*** Bug 1106992 has been marked as a duplicate of this bug. ***

Comment 3 Marcin Juszkiewicz 2014-10-03 11:51:22 UTC
Created attachment 943707 [details]
patch + spec changeset

Comment 4 Jaroslav Reznik 2015-03-03 15:16:51 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 22 development cycle.
Changing version to '22'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora22

Comment 5 Marcin Juszkiewicz 2015-07-21 10:44:42 UTC
ping?

Comment 6 Michel Lind 2015-07-25 14:15:38 UTC
(In reply to Marcin Juszkiewicz from comment #5)
> ping?

hi Marcin - working on this. Thanks for the patch -- there's another issue involving Quarry not building with GCC5, I'm looking at how Debian solved the issue right now

Upstream is dead really, and there was a previous attempt to continue the project on Gitorious that didn't end up anywhere (in fact, Gitorious is not there any longer). Perhaps it's time to resurrect Quarry since I still haven't seen any compelling alternative.

Comment 7 Fedora Update System 2015-07-26 02:13:30 UTC
quarry-0.2.0-18.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/quarry-0.2.0-18.fc22

Comment 8 Fedora Update System 2015-07-26 02:13:38 UTC
quarry-0.2.0-18.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/quarry-0.2.0-18.fc21

Comment 9 Fedora Update System 2015-07-30 00:41:33 UTC
Package quarry-0.2.0-18.fc22:
* should fix your issue,
* was pushed to the Fedora 22 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing quarry-0.2.0-18.fc22'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-12085/quarry-0.2.0-18.fc22
then log in and leave karma (feedback).

Comment 10 Fedora Update System 2015-08-07 13:09:42 UTC
quarry-0.2.0-18.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2015-08-07 13:13:20 UTC
quarry-0.2.0-18.fc22 has been pushed to the Fedora 22 stable repository.  If problems still persist, please make note of it in this bug report.