Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 104299
Summary: | gtk2: kinput2 "enter" commit broken in gaim | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Warren Togami <wtogami> | ||||
Component: | gaim | Assignee: | Christopher Blizzard <blizzard> | ||||
Status: | CLOSED RAWHIDE | QA Contact: | |||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | CC: | eblanton, llch, otaylor, tagoh | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2003-10-24 15:27:58 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 100644 | ||||||
Attachments: |
|
Description
Warren Togami
2003-09-12 09:28:05 UTC
This is actually gaim's bug, because gaim is going to send the messages if the users are hitting ENTER. I'm not sure the author knows this issue, but gaim has a workaound to fix this issue. it is the Interface->Shortcuts->Control-Enter sends message on the preferences. it works to me. To fix this issue correctly, gaim will needs to check gtk_im_context_filter_keypress() when it receives the keyevent and keyval is GDK_Return or GDK_KP_Enter then. Created attachment 94440 [details]
proposed patch
I did a quick hack, and I've tested gaim with this patch. it works fine to me.
Thanks! I asked gaim developers to regression test it to make sure it causes no non-japanese problems, and I'm giving this to japanese users tonight for thorough testing. I am very aware of this problem, and have been since it was introduced (0.60cvs). Unfortunately, what I am _not_ aware of is a clean solution. I personally use the Ctrl+Enter-to-send method. This has been in the gaim bugtracker in several incarnations, and I have filed or posted to a couple of related Gtk2 bugs for it. (http://bugzilla.gnome.org/show_bug.cgi?id=90082 and http://bugzilla.gnome.org/show_bug.cgi?id=119051) The second bug there indicates that otaylor agrees with me that the patch attached to this report, while seeming to work, is potentially problematic. I would LOVE to come up with a clean and correct solution to this problem, it is one of the longest-outstanding gaim international-usability bugs I am aware of. Ethan Hmm, yes, if GtkIMContext is designed as the applications doesn't need any extra code perfectly, this patch is also just workaround, though. Tested this workaround quite a bit with several users. It seems to behave exactly how I expect now. Is the only concern that it is using a private gtk2 interface, which may disappear at any time? Ethan said this as the reason why he will not be committed to gaim upstream. In any case unless we discover that this breaks something, I am applying this to Fedora Linux's gaim packages. Please apply this to gaim-0.70. This patch has been in fedora.us 0.68 and 0.70 for 20 days now with no ill effects. "This seems to be working" != "This is good and correct", Warren. As indicated in the above referenced bugs, this is not a solution I am pleased with, and I do not intend to apply it to gaim. I was not referring to upstream gaim, I was referring to downstream Fedora Core where we have a predictable gtk2 that wont change during a stable release and break the underlying private interface which this depends upon. Owen what would you recommend? After talking with owen about this, I've included this patch in 0.71-2. Should be in the next tree. Woo! |