Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1070222
| Summary: | Review Request: python-impacket - Collection of Python classes providing access to network packets | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabian Affolter <mail> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | logans, mail, package-review, panemade, rebus, tcallawa |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | python-impacket-0.9.11-2.fc21 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-10-08 18:53:00 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 563471 | ||
|
Description
Fabian Affolter
2014-02-26 12:34:01 UTC
I will take this for review Review:- + Package build successfully in rawhide mock + Source verified with upstream as (sha256sum) srpm tarball :e0b4e5174b869efa35c3068ee55ac3c2364706b59ffc43cd9e3c2f75f5accf2d upstream tarball : e0b4e5174b869efa35c3068ee55ac3c2364706b59ffc43cd9e3c2f75f5accf2d - rpmlint on generated rpms gave output python-impacket.noarch: W: no-manual-page-for-binary smbexec.py python-impacket.noarch: W: no-manual-page-for-binary samrdump.py python-impacket.noarch: W: no-manual-page-for-binary atexec.py python-impacket.noarch: W: no-manual-page-for-binary ntfs-read.py python-impacket.noarch: W: no-manual-page-for-binary rdp_check.py python-impacket.noarch: W: no-manual-page-for-binary registry-read.py python-impacket.noarch: W: no-manual-page-for-binary nmapAnswerMachine.py python-impacket.noarch: W: no-manual-page-for-binary mssqlclient.py python-impacket.noarch: W: no-manual-page-for-binary ping.py python-impacket.noarch: W: no-manual-page-for-binary opdump.py python-impacket.noarch: W: no-manual-page-for-binary mssqlinstance.py python-impacket.noarch: W: no-manual-page-for-binary psexec.py python-impacket.noarch: W: no-manual-page-for-binary split.py python-impacket.noarch: W: no-manual-page-for-binary loopchain.py python-impacket.noarch: W: no-manual-page-for-binary sniffer.py python-impacket.noarch: W: no-manual-page-for-binary ping6.py python-impacket.noarch: W: no-manual-page-for-binary smbtorture.py python-impacket.noarch: W: no-manual-page-for-binary lookupsid.py python-impacket.noarch: W: no-manual-page-for-binary os_ident.py python-impacket.noarch: W: no-manual-page-for-binary services.py python-impacket.noarch: W: no-manual-page-for-binary esentutl.py python-impacket.noarch: W: no-manual-page-for-binary smbclient.py python-impacket.noarch: W: no-manual-page-for-binary ifmap.py python-impacket.noarch: W: no-manual-page-for-binary secretsdump.py python-impacket.noarch: W: no-manual-page-for-binary rpcdump.py python-impacket.noarch: W: no-manual-page-for-binary tracer.py python-impacket.noarch: W: no-manual-page-for-binary smbrelayx.py python-impacket.noarch: W: no-manual-page-for-binary sniff.py python-impacket.noarch: W: no-manual-page-for-binary uncrc32.py 2 packages and 0 specfiles checked; 0 errors, 29 warnings. ==> You should not install example files as a binary files in /usr/bin. Remove those files in %install. Users are anyway will get those files as part of %docs files. Also, sent an email to Legal for validity of this modified ASL 2.0 license. License tag is ASL 1.1 and zlib, as discussed on mailing list. Lifting FE-Legal. Thanks, Tom. Fabian, update the package for license and not installing py files in /usr/bin Looking forward to this package. It is needed for building parts of ROS [1] on Fedora. If I can assist in a swift packaging, please let me know. Thanks, [1] http://www.ros.org * Sat Jun 28 2014 Fabian Affolter <mail> - 0.9.11-2 - Move files out of /usr/bin - Update licence (according to mailing list) Updated files: Spec URL: http://fab.fedorapeople.org/packages/SRPMS/python-impacket.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/python-impacket-0.9.11-2.fc20.src.rpm Looks good. APPROVED. Thanks for the review. New Package SCM Request ======================= Package Name: python-impacket Short Description: Collection of Python classes providing access to network packets Owners: fab Branches: f20 f21 el6 epel7 InitialCC: Git done (by process-git-requests). python-impacket-0.9.11-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-impacket-0.9.11-2.fc21 python-impacket-0.9.11-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-impacket-0.9.11-2.fc20 python-impacket-0.9.11-2.fc21 has been pushed to the Fedora 21 testing repository. python-impacket-0.9.11-2.fc20 has been pushed to the Fedora 20 stable repository. python-impacket-0.9.11-2.fc21 has been pushed to the Fedora 21 stable repository. |