Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1094169
| Summary: | perl-Params-Validate make check error | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michel Normand <normand> | ||||||
| Component: | perl-Params-Validate | Assignee: | Ralf Corsepius <rc040203> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | rawhide | CC: | lxtnow, menantea, perl-devel, rc040203 | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | ppc64le | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | perl-Params-Validate-1.08-8.fc20 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2014-05-05 23:34:08 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 1051573 | ||||||||
| Attachments: |
|
||||||||
Created attachment 892456 [details]
tstspell.input.pm data used by tstspell.pl
Well, I am pretty much clueless about what to do with this BZ. perl-Params-Validate has always had problems with its pod-checks. In Fedora, I have been trying to work around these by applying a patch (Params-Validate-1.08.diff in git). Seemingly this patch ceased being functional by some other (yet undetermined) changes in Fedora. It used to work for f19, f20 and rawhide, but currently fails for f20 and rawhide. F19 still builds fine. That said, I do not think this issue has anything to do with ppc64, but is a general issue somewhere. The big questions, I don't know the answer to, to me is: Where/what is cause? A potential fix would depend on the answer to this question. I can easily modify my patch to let the package build on F20/rawhide again, however with this change applied, building fails on f19. A last-resort work-around to all this would be to disable t/release-pod-spell.t or all release tests. It's something I have been doing in more recent packages, because many upstream maintainers actively discourage packagers to execise these :( (In reply to Ralf Corsepius from comment #2) > Well, I am pretty much clueless about what to do with this BZ. > > perl-Params-Validate has always had problems with its pod-checks. > In Fedora, I have been trying to work around these by applying a patch > (Params-Validate-1.08.diff in git). > > Seemingly this patch ceased being functional by some other (yet > undetermined) changes in Fedora. It used to work for f19, f20 and rawhide, > but currently fails for f20 and rawhide. F19 still builds fine. That said, I > do not think this issue has anything to do with ppc64, but is a general > issue somewhere. > > The big questions, I don't know the answer to, to me is: Where/what is cause? > A potential fix would depend on the answer to this question. > > I can easily modify my patch to let the package build on F20/rawhide again, > however with this change applied, building fails on f19. > > A last-resort work-around to all this would be to disable > t/release-pod-spell.t or all release tests. It's something I have been doing > in more recent packages, because many upstream maintainers actively > discourage packagers to execise these :( Hi, I tried also to understand this problem without success (seems relative to the way hunspell is handling simple quote). I checked a workaround by adding 'globals (without last quote at the end) in your Params-Validate-1.08.diff patch and this make the test pass on rawhide/ppc64le. I don't have a f19 available so I didn't test it on f19 and perhaps is what you referenced in your comment by saying "I can easily modify my patch to let the package build on F20/rawhide again". I just wanted to signal it in case this workaround passes on f19 (worth a try). (In reply to Menanteau Guy from comment #3) > (In reply to Ralf Corsepius from comment #2) > Hi, I tried also to understand this problem without success (seems relative > to the way hunspell is handling simple quote). This is my understanding, too. My gut feeling is, there is a quoting bug somewhere. > I checked a workaround by adding 'globals (without last quote at the end) in > your Params-Validate-1.08.diff patch and this make the test pass on > rawhide/ppc64le. Exactly. This is the "easily patch work-around", I was referring to above. > I don't have a f19 available so I didn't test it on f19 and perhaps is what > you referenced in your comment by saying "I can easily modify my patch to > let the package build on F20/rawhide again". Exactly. When using "'globals" instead of "'globals'", building for f19 fails. However, ... adding both "'globals" and "'globals'" works on f19, f20 and rawhide! I guess, I am going to add this. BTW, wrt. test-building for f19, you could try - using "mock": yum install mock mock -r fedora-19-<x86_64,i386> perl-Params-Validate-<..>.src.rpm or - using "fedpkg": yum install fedpkg fedpkg clone -B perl-Params-Validate cd f19 fedpkg mockbuild (In reply to Ralf Corsepius from comment #4) > However, ... adding both "'globals" and "'globals'" works on f19, f20 and > rawhide! I guess, I am going to add this. I've applied this to perl-Params-Validate-1.08-7. perl-Params-Validate-1.08-7.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-Params-Validate-1.08-7.fc20 perl-Params-Validate-1.08-8.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-Params-Validate-1.08-8.fc20 perl-Params-Validate-1.08-8.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. |
Created attachment 892455 [details] tstspell.pl perl script (need compagnion testspell.input.pm) Description of problem: perl-Params-Validate make check error while building on ppc64le new architecture. Version-Release number of selected component (if applicable): perl-Params-Validate-1.08-6.fc21 How reproducible: Steps to Reproduce: 1.fedpkg clone -a perl-Params-Validate 2.fedpkg srpm 3.fedpkg mockbuild Actual results: ... # Failed test 'POD spelling for blib/lib/Params/Validate.pm' # at t/release-pod-spell.t line 31. # Errors: # 'globals # Looks like you failed 1 test of 7. t/release-pod-spell.t ................... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/7 subtests ... Additional info: The attached perl script is a code snippet that mimic the failing perl-Params-Validate package. This snippet failed on ppc64le and ppc64 architectures. The problem is either: * in the data set in script (the single quote as first element of __DATA__) * the add_stopwords or hunspell functions.