Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1098170
| Summary: | summary.py tries to access the "templates" dir in current dir | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora EPEL | Reporter: | Michal Domonkos <mdomonko> | ||||
| Component: | piglit | Assignee: | Matěj Cepl <mcepl> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | epel7 | CC: | mcepl, mcepl | ||||
| Target Milestone: | --- | Keywords: | Reopened | ||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | piglit-1-0.15.20140414GIT8775223.el6 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2014-05-17 00:05:37 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
Created attachment 895887 [details]
Sample results.json to test with
Update:
The most current commits appear to have this resolved; I was looking at a rather old commit where the templates dir was hardcoded. Now the code looks like this:
shutil.copy(path.join(self.TEMPLATE_DIR, "index.css"), path.join(destination, "index.css"))
versus the older:
copy("templates/index.css", path.join(destination, "index.css"))
I haven't tried to build yet but this should probably be no longer an issue and we can close this bug; I'll update you shortly.
Try this build http://koji.fedoraproject.org/koji/taskinfo?taskID=6851990 (In reply to Matěj Cepl from comment #3) > Try this build http://koji.fedoraproject.org/koji/taskinfo?taskID=6851990 I do confirm - this package is fixed (there's still a missing dependency but unrelated to this bug) so closing now. Thanks! piglit-1-0.15.20140414GIT8775223.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/piglit-1-0.15.20140414GIT8775223.el6 piglit-1-0.15.20140414GIT8775223.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/piglit-1-0.15.20140414GIT8775223.fc20 Package piglit-1-0.15.20140414GIT8775223.el6: * should fix your issue, * was pushed to the Fedora EPEL 6 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=epel-testing piglit-1-0.15.20140414GIT8775223.el6' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-EPEL-2014-1424/piglit-1-0.15.20140414GIT8775223.el6 then log in and leave karma (feedback). piglit-1-0.16.20140414GIT8775223.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/piglit-1-0.16.20140414GIT8775223.fc20 piglit-1-0.15.20140414GIT8775223.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. piglit-1-0.17.20140414GIT8775223.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/piglit-1-0.17.20140414GIT8775223.fc20 piglit-1-0.19.20140414GIT8775223.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/piglit-1-0.19.20140414GIT8775223.fc20 piglit-1-0.19.20140414GIT8775223.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. |
Description of problem: Generating piglit HTML summaries doesn't work in this new upstream version. The reason is that there's a new function generateHTML() in framework/summary.py expecting that the script be run from the piglit's own directory (on line 500 a file in the piglit's "templates" subdirectory is accessed). Since the piglit-summary-html script, that calls the function, is in PATH after installing the RPM and thus will always be run from any directory different from the installed one, it obviously fails. It looks like the source will have to be patched for our packaging needs to point to the correct dir but at this point I'm not really sure how that should be done correctly :) Version-Release number of selected component (if applicable): piglit-1-0.13.20130824GITbccdf6f.el6 How reproducible: always Steps to Reproduce: 1. Run piglit-summary-html /tmp/summary /tmp/results.json Actual results: Traceback (most recent call last): File "/usr/bin/piglit-summary-html", line 99, in <module> main() File "/usr/bin/piglit-summary-html", line 95, in main output.generateHTML(args.summaryDir, args.exclude_details) File "/usr/lib64/piglit/framework/summary.py", line 500, in generateHTML copy("templates/index.css", path.join(destination, "index.css")) File "/usr/lib64/python2.6/shutil.py", line 84, in copy copyfile(src, dst) File "/usr/lib64/python2.6/shutil.py", line 50, in copyfile with open(src, 'rb') as fsrc: IOError: [Errno 2] No such file or directory: 'templates/index.css' Expected results: No error