Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1106803

Summary: iperf3: FTBFS in rawhide
Product: [Fedora] Fedora Reporter: Dennis Gilmore <dennis>
Component: iperf3Assignee: Susant Sahani <ssahani>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: balajig81, fdc, kevin, ssahani, strobert
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-06-27 04:47:35 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1105908    
Attachments:
Description Flags
build.log
none
root.log
none
state.log
none
fix compilation none

Description Dennis Gilmore 2014-06-09 17:31:46 UTC 
Your package iperf3 failed to build from source in current rawhide.

http://koji.fedoraproject.org/koji/taskinfo?taskID=6987939

For details on mass rebuild see https://fedoraproject.org/wiki/Fedora_21_Mass_Rebuild
Comment 1 Dennis Gilmore 2014-06-09 17:31:48 UTC 
Created attachment 905344 [details]
build.log
Comment 2 Dennis Gilmore 2014-06-09 17:31:50 UTC 
Created attachment 905345 [details]
root.log
Comment 3 Dennis Gilmore 2014-06-09 17:31:52 UTC 
Created attachment 905346 [details]
state.log
Comment 4 Susant Sahani 2014-06-09 18:12:08 UTC 
In function 'open',
    inlined from 'iperf_new_stream' at iperf_api.c:2218:20:
/usr/include/bits/fcntl2.h:50:4: error: call to '__open_missing_mode' declared with attribute error: open with O_CREAT in second argument needs 3 arguments
    __open_missing_mode ();

 this is failing because of open function has 2 arguments and it is missing the third argument. open with O_CREAT must have 3 arguments rather than 2
http://www.opengroup.org/onlinepubs/009695399/functions/open.html


This patch should fix it.


diff -rupN iperf-3.0.3/src/iperf_api.c  iperf-3.0.3.patch/src/iperf_api.c
--- iperf-3.0.3/src/iperf_api.c	2014-03-26 23:36:38.000000000 +0530
+++ iperf-3.0.3.patch/src/iperf_api.c	2014-06-09 23:31:46.183346802 +0530
@@ -2215,7 +2215,7 @@ iperf_new_stream(struct iperf_test *test
     sp->rcv = test->protocol->recv;
 
     if (test->diskfile_name != (char*) 0) {
-	sp->diskfile_fd = open(test->diskfile_name, test->sender ? O_RDONLY : (O_WRONLY|O_CREAT|O_TRUNC));
+	sp->diskfile_fd = open(test->diskfile_name, test->sender ? O_RDONLY : (O_WRONLY|O_CREAT|O_TRUNC), S_IRUSR|S_IWUSR);
 	if (sp->diskfile_fd == -1) {
 	    i_errno = IEFILE;
             munmap(sp->buffer, sp->test->settings->blksize);
Comment 5 Susant Sahani 2014-06-09 18:13:32 UTC 
Created attachment 905607 [details]
fix compilation
Comment 6 Susant Sahani 2014-06-10 03:00:43 UTC 
The fix has been approved on upstream. I will back port it and push the changes.

https://github.com/esnet/iperf/commit/c5e1205e4906173d74574e30b4ea1c0e182883de
Comment 7 Susant Sahani 2014-06-11 05:09:26 UTC 
I have committed the changes. please verify if the issue still persists.

http://pkgs.fedoraproject.org/cgit/iperf3.git/commit/?id=c0885cc1cba5c07f2006df17439fa04ee7f2ea49
Comment 8 Susant Sahani 2014-06-11 05:10:54 UTC 
Build log can be found here http://koji.fedoraproject.org/koji/taskinfo?taskID=7034506
Comment 9 Susant Sahani 2014-06-27 04:47:35 UTC 
Closing this bug as changes made to git.