Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1113430
Summary: | Packaging issues | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Michael Schwendt <bugs.michael> |
Component: | lz4 | Assignee: | pjp <pj.pandit> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 20 | CC: | pj.pandit |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | lz4-r119-1.el5 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2014-07-17 04:33:02 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Michael Schwendt
2014-06-26 07:52:29 UTC
I've fixed most of the issues raised above, except the compiler flags and BuildRoot ones. Compiler flags are defined in the upstream Makefile. And Buildroot would be required for EPEL builds, no? See scratch build -> http://koji.fedoraproject.org/koji/taskinfo?taskID=7086005 === $ rpmlint SRPMS/lz4-r118-1.fc19.src.rpm lz4.src: W: spelling-error %description -l en_US scalable -> salable, callable, calculable lz4.src: W: spelling-error %description -l en_US multi -> mulch, mufti 1 packages and 0 specfiles checked; 0 errors, 2 warnings. $ $ $ rpmlint RPMS/x86_64/lz4-r118-1.fc19.x86_64.rpm lz4.x86_64: W: spelling-error %description -l en_US scalable -> salable, callable, calculable lz4.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti 1 packages and 0 specfiles checked; 0 errors, 2 warnings. $ $ $ rpmlint RPMS/x86_64/lz4-devel-r118-1.fc19.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. === Please let me know if this looks good to go into the repositories. Thank you. > And Buildroot would be required for EPEL builds, no? That's what the linked guidelines say. If you really want to use exactly the same spec file for EPEL (with the caveat that it would also include irrelevant entries about Rawhide and Fedora), it's good practise to either be explicit in the spec file (e.g. with a comment above the BuildRoot tag) or use dist conditionals: https://fedoraproject.org/wiki/Packaging:DistTag#Conditionals > Compiler flags are defined in the upstream Makefile. From the guidelines: [...] Overriding these flags for performance optimizations (for instance, -O3 instead of -O2) is generally discouraged. If you can present benchmarks that show a significant speedup for this particular code, this could be revisited on a case-by-case basis. Adding to and overriding or filtering parts of these flags is permitted if there's a good reason to do so; the rationale for doing so must be documented in the specfile. [...] (In reply to Michael Schwendt from comment #2) > with a comment above the BuildRoot tag) or use dist conditionals: > https://fedoraproject.org/wiki/Packaging:DistTag#Conditionals Done. Please see: -> http://koji.fedoraproject.org/koji/taskinfo?taskID=7086284 > [...] Overriding these flags for performance optimizations (for instance, > -O3 instead of -O2) is generally discouraged. If you can present benchmarks > that show a significant speedup for this particular code, this could be > revisited on a case-by-case basis. Adding to and overriding or filtering > parts of these flags is permitted if there's a good reason to do so; the > rationale for doing so must be documented in the specfile. [...] Yes, I read the guidelines and CFLAGS is set to $RPM_OPT_FLAGS in the %build section. But upstream Makefile merely adds its definition to the local one see -> https://github.com/Cyan4973/lz4/blob/master/Makefile Thank you. lz4-r118-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/lz4-r118-1.fc19 lz4-r118-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/lz4-r118-1.fc20 lz4-r118-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/lz4-r118-1.el6 lz4-r118-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/lz4-r118-1.el5 Package lz4-r118-1.fc20: * should fix your issue, * was pushed to the Fedora 20 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing lz4-r118-1.fc20' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-8022/lz4-r118-1.fc20 then log in and leave karma (feedback). lz4-r119-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/lz4-r119-1.fc20 lz4-r119-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/lz4-r119-1.fc19 lz4-r119-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/lz4-r119-1.el5 lz4-r119-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/lz4-r119-1.el6 lz4-r119-1.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. lz4-r119-1.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. lz4-r119-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. lz4-r119-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. |