Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1115672
| Summary: | Review Request: nodejs-grunt-contrib-csslint - Lint CSS files | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ralph Bean <rbean> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-07-22 22:33:34 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1115666 | ||
| Bug Blocks: | 956806, 858027, 1115659 | ||
|
Description
Ralph Bean
2014-07-02 21:04:20 UTC
Review:
+ mock build is successful for f22
- rpmlint output on rpms gave
nodejs-grunt-contrib-csslint.x86_64: E: no-binary
nodejs-grunt-contrib-csslint.x86_64: W: only-non-binary-in-usr-lib
nodejs-grunt-contrib-csslint.x86_64: W: dangling-symlink /usr/lib/node_modules/grunt-contrib-csslint/node_modules/csslint /usr/lib/node_modules/csslint
nodejs-grunt-contrib-csslint-debuginfo.x86_64: E: description-line-too-long C This package provides debug information for package nodejs-grunt-contrib-csslint.
nodejs-grunt-contrib-csslint-debuginfo.x86_64: E: empty-debuginfo-package
3 packages and 0 specfiles checked; 3 errors, 2 warnings.
==> See suggestion below
+ Source verified with upstream as (sha256sum)
srpm tarball :534cd31567ecc3ef2b3cf987df0a1e9969933f767cbd8adb33f43937c790d9ca
upstream tarball :534cd31567ecc3ef2b3cf987df0a1e9969933f767cbd8adb33f43937c790d9ca
+ License "MIT" is valid and is included in its own file as %doc.
+ rest looks following packaging guidelines
Suggestions:
1) Add following to spec
BuildArch: noarch
%if 0%{?fedora} >= 19
ExclusiveArch: %{nodejs_arches} noarch
%else
ExclusiveArch: %{ix86} x86_64 %{arm} noarch
%endif
New release should address your suggestions: Spec URL: http://threebean.org/rpm/SPECS/nodejs-grunt-contrib-csslint.spec SRPM URL: http://threebean.org/rpm/SRPMS/nodejs-grunt-contrib-csslint-0.2.0-2.fc20.src.rpm Thanks for the update. New srpm looks good. APPROVED. New Package SCM Request ======================= Package Name: nodejs-grunt-contrib-csslint Short Description: Lint CSS files Upstream URL: https://npmjs.org/package/grunt-contrib-csslint Owners: ralph Branches: f21,f20,f19,epel7,el6 InitialCC: Git done (by process-git-requests). nodejs-grunt-contrib-csslint-0.2.0-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-grunt-contrib-csslint-0.2.0-2.fc20 nodejs-grunt-contrib-csslint-0.2.0-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-grunt-contrib-csslint-0.2.0-2.fc19 Buildroot overrides created. nodejs-grunt-contrib-csslint-0.2.0-2.fc20 has been pushed to the Fedora 20 stable repository. nodejs-grunt-contrib-csslint-0.2.0-2.fc19 has been pushed to the Fedora 19 stable repository. |