Bug 1115673

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Unknown or generated". 1 files have unknown license. Detailed output of
     licensecheck in /home/tom/1115673-nodejs-grunt-contrib-
     cssmin/licensecheck.txt
[-]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[-]: Package should compile and build into binary rpms on all supported
     architectures.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: nodejs-grunt-contrib-cssmin-0.9.0-1.fc22.x86_64.rpm
          nodejs-grunt-contrib-cssmin-0.9.0-1.fc22.src.rpm
nodejs-grunt-contrib-cssmin.x86_64: E: no-binary
nodejs-grunt-contrib-cssmin.x86_64: W: only-non-binary-in-usr-lib
nodejs-grunt-contrib-cssmin.x86_64: W: dangling-symlink /usr/lib/node_modules/grunt-contrib-cssmin/node_modules/clean-css /usr/lib/node_modules/clean-css
nodejs-grunt-contrib-cssmin.x86_64: W: dangling-symlink /usr/lib/node_modules/grunt-contrib-cssmin/node_modules/chalk /usr/lib/node_modules/chalk
nodejs-grunt-contrib-cssmin.x86_64: W: dangling-symlink /usr/lib/node_modules/grunt-contrib-cssmin/node_modules/maxmin /usr/lib/node_modules/maxmin
2 packages and 0 specfiles checked; 1 errors, 4 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint nodejs-grunt-contrib-cssmin
nodejs-grunt-contrib-cssmin.x86_64: E: no-binary
nodejs-grunt-contrib-cssmin.x86_64: W: only-non-binary-in-usr-lib
nodejs-grunt-contrib-cssmin.x86_64: W: dangling-symlink /usr/lib/node_modules/grunt-contrib-cssmin/node_modules/clean-css /usr/lib/node_modules/clean-css
nodejs-grunt-contrib-cssmin.x86_64: W: dangling-symlink /usr/lib/node_modules/grunt-contrib-cssmin/node_modules/chalk /usr/lib/node_modules/chalk
nodejs-grunt-contrib-cssmin.x86_64: W: dangling-symlink /usr/lib/node_modules/grunt-contrib-cssmin/node_modules/maxmin /usr/lib/node_modules/maxmin
1 packages and 0 specfiles checked; 1 errors, 4 warnings.
# echo 'rpmlint-done:'



Requires
--------
nodejs-grunt-contrib-cssmin (rpmlib, GLIBC filtered):
    nodejs(engine)
    npm(chalk)
    npm(clean-css)
    npm(grunt)
    npm(maxmin)



Provides
--------
nodejs-grunt-contrib-cssmin:
    nodejs-grunt-contrib-cssmin
    nodejs-grunt-contrib-cssmin(x86-64)
    npm(grunt-contrib-cssmin)



Source checksums
----------------
http://registry.npmjs.org/grunt-contrib-cssmin/-/grunt-contrib-cssmin-0.9.0.tgz :
  CHECKSUM(SHA256) this package     : db2a49249a5859a3a398495738ca512346282eb93362cd55e3ace40cc94bde28
  CHECKSUM(SHA256) upstream package : db2a49249a5859a3a398495738ca512346282eb93362cd55e3ace40cc94bde28


Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/usr/bin/fedora-review -m compton-rawhide-x86_64 -b 1115673
Buildroot used: compton-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

* Should be noarch
* Upstream has release 0.10.0 now
* Consider packaging tests
* No need to require npm modules manually

Here's a new release with the latest upstream tarball and the noarch declaration.

As with the other reviews, I'd like to decline running the tests for now and ask if I can keep the npm module requirements explicit:

Spec URL: http://threebean.org/rpm/SPECS/nodejs-grunt-contrib-cssmin.spec
SRPM URL: http://threebean.org/rpm/SRPMS/nodejs-grunt-contrib-cssmin-0.10.0-1.fc20.src.rpm

Looks good. Package approved on the same basis as the others.

New Package SCM Request
=======================
Package Name: nodejs-grunt-contrib-cssmin
Short Description: Compress CSS files
Upstream URL: https://npmjs.org/package/grunt-contrib-cssmin
Owners: ralph
Branches: f21,f20,f19,epel7
InitialCC:

Git done (by process-git-requests).

nodejs-grunt-contrib-cssmin-0.10.0-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/nodejs-grunt-contrib-cssmin-0.10.0-1.fc21

nodejs-grunt-contrib-cssmin-0.10.0-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/nodejs-grunt-contrib-cssmin-0.10.0-1.fc20

nodejs-grunt-contrib-cssmin-0.10.0-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/nodejs-grunt-contrib-cssmin-0.10.0-1.fc19

Built and buildroot overrides submitted.

nodejs-grunt-contrib-cssmin-0.10.0-1.fc21 has been pushed to the Fedora 21 stable repository.

nodejs-grunt-contrib-cssmin-0.10.0-1.fc20 has been pushed to the Fedora 20 stable repository.

nodejs-grunt-contrib-cssmin-0.10.0-1.fc19 has been pushed to the Fedora 19 stable repository.