Bug 1135461

Few things:
* please change BR to python2-devel (easy fix to most python-XStatic-xxx packages)
* could you request that upstream also bundles the license files ? spin.js has a proper license file upstream. I don't consider this as a blocker, and I'm confident that you'll deal with it upstream.

Except the first point, it's all good for me.

Haïkel, thank you very much for your review.

I changed BR to python2-devel.

SPEC: http://www.matthias-runge.de/fedora/python-XStatic-Spin.spec
SRPM: http://www.matthias-runge.de/fedora/python-XStatic-Spin-1.2.5.2-2.fc20.src.rpm

I will ask upstream to bundle license files. 

Ideally, we would remove bundled JavaScript files and would make a requirement to the corresponding packages in Fedora (once they are there).

Thank you, everything is alright !

As for javascript libraries bundling, there is currently an exception concerning major javascript libraries (ie: jquery, jquery-ui, bootstrap, etc.) from FPC until we figure out how to unbundle jquery (which is required by most of them)
Besides, XStatic is an alternative to unbundle javascript libraries from python application that improves the current situation.

As this package respects Fedora packaging guidelines, I hereby approve this package into Fedora Packages Collection. Please submit a scm request, and feel free to ping me when you need it.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[-]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Unknown or generated". 4 files have unknown license. Detailed output of
     licensecheck in /home/builder/reviews/1135461-python-XStatic-
     Spin/licensecheck.txt
[x]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/lib/python2.7/site-packages/xstatic/pkg
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib/python2.7/site-
     packages/xstatic/pkg
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
     See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python-XStatic-Spin-1.2.5.2-2.fc20.noarch.rpm
          python-XStatic-Spin-1.2.5.2-2.fc20.src.rpm
python-XStatic-Spin.noarch: W: spelling-error %description -l en_US setuptools -> setup tools, setup-tools, footstools
python-XStatic-Spin.noarch: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal
python-XStatic-Spin.src: W: spelling-error %description -l en_US setuptools -> setup tools, setup-tools, footstools
python-XStatic-Spin.src: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal
2 packages and 0 specfiles checked; 0 errors, 4 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint python-XStatic-Spin
python-XStatic-Spin.noarch: W: spelling-error %description -l en_US setuptools -> setup tools, setup-tools, footstools
python-XStatic-Spin.noarch: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
# echo 'rpmlint-done:'



Requires
--------
python-XStatic-Spin (rpmlib, GLIBC filtered):
    python(abi)
    python-XStatic
    web-assets-filesystem



Provides
--------
python-XStatic-Spin:
    python-XStatic-Spin



Source checksums
----------------
https://pypi.python.org/packages/source/X/XStatic-Spin/XStatic-Spin-1.2.5.2.tar.gz :
  CHECKSUM(SHA256) this package     : 7f46ef0e45e047019ba6eda22c432fb96f681b97bbe7f1749aa9209e07727192
  CHECKSUM(SHA256) upstream package : 7f46ef0e45e047019ba6eda22c432fb96f681b97bbe7f1749aa9209e07727192

thank you very much for your review!

New Package SCM Request
=======================
Package Name: python-XStatic-Spin
Short Description: Spin (XStatic packaging standard)
Upstream URL: http://fgnass.github.io/spin.js/
Owners: mrunge
Branches: f20, f21, el6, el7

Git done (by process-git-requests).

python-XStatic-Spin-1.2.5.2-2.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/python-XStatic-Spin-1.2.5.2-2.el7

python-XStatic-Spin-1.2.5.2-2.el7 has been pushed to the Fedora EPEL 7 testing repository.

python-XStatic-Spin-1.2.5.2-2.el7 has been pushed to the Fedora EPEL 7 stable repository.