Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1147330
| Summary: | Review Request: libason - A library for manipulating ASON values | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Casey Dahlin <casey.dahlin> |
| Component: | Package Review | Assignee: | Mairi Dulaney <jdulaney> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | casey.dahlin, i, jdulaney, package-review |
| Target Milestone: | --- | Flags: | jdulaney:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | libason-0.1.2-2.fc20 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-02-04 08:00:02 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Casey Dahlin
2014-09-29 03:31:46 UTC
Review #1: jdulaney@gefjon:~/rpmbuild/SPECS$ rpmlint ./libason.spec ./libason.spec: W: invalid-url Source0: https://github.com/sadmac7000/libason/releases/download/v0.1/libason-0.1.1.tar.gz HTTP Error 404: Not Found 0 packages and 1 specfiles checked; 0 errors, 1 warnings. jdulaney@gefjon:~/rpmbuild/SRPMS$ rpmlint ./libason-0.1.1-1.fc21.src.rpm libason.src: W: spelling-error %description -l en_US programmatically -> pro grammatically, pro-grammatically, programmatic ally libason.src: W: invalid-url Source0: https://github.com/sadmac7000/libason/releases/download/v0.1/libason-0.1.1.tar.gz HTTP Error 404: Not Found 1 packages and 0 specfiles checked; 0 errors, 2 warnings. Missing build dependencies: lcov readline-devel texlive-latex-bin-bin Also, when building inside mock environment:
config.status: creating Makefile
config.status: creating src/Makefile
config.status: creating include/Makefile
config.status: creating tests/Makefile
config.status: creating doc/Makefile
config.status: creating include/config.h
config.status: executing depfiles commands
configure: WARNING: unrecognized options: --without-spec
+ make -j2
Making all in src
make[1]: Entering directory `/builddir/build/BUILD/libason-0.1.1/src'
CC value.lo
CC output.lo
CC iter.lo
CC stringfunc.lo
CC namespace.lo
CC namespace_ram.lo
CC crc.lo
CC parse.lo
CC asonq.o
CCLD libason.la
CCLD asonq
make[1]: Leaving directory `/builddir/build/BUILD/libason-0.1.1/src'
Making all in include
make[1]: Entering directory `/builddir/build/BUILD/libason-0.1.1/include'
make all-am
make[2]: Entering directory `/builddir/build/BUILD/libason-0.1.1/include'
make[2]: Leaving directory `/builddir/build/BUILD/libason-0.1.1/include'
make[1]: Leaving directory `/builddir/build/BUILD/libason-0.1.1/include'
Making all in tests
make[1]: Entering directory `/builddir/build/BUILD/libason-0.1.1/tests'
CC parser_test.o
CC harness.o
CC print_object.o
CC iterator_test.o
CC crc_test.o
CC value_test-value_test.o
CC value_test-harness.o
CC ns_test.o
CCLD parser_test
CCLD print_object
CCLD iterator_test
CC ../src/crc.o
CCLD value_test
CCLD crc_test
CCLD ns_test
make[1]: Leaving directory `/builddir/build/BUILD/libason-0.1.1/tests'
Making all in doc
make[1]: Entering directory `/builddir/build/BUILD/libason-0.1.1/doc'
cd .. && automake-1.13 --foreign doc/Makefile
/bin/sh: line 10: automake-1.13: command not found
make[1]: *** [Makefile.in] Error 127
make[1]: Leaving directory `/builddir/build/BUILD/libason-0.1.1/doc'
make: *** [all-recursive] Error 1
error: Bad exit status from /var/tmp/rpm-tmp.O2QCCH (%build)
RPM build errors:
Bad exit status from /var/tmp/rpm-tmp.O2QCCH (%build)
Child return code was: 1
EXCEPTION: Command failed. See logs for output.
# ['bash', '--login', '-c', 'rpmbuild -bb --target x86_64 --nodeps builddir/build/SPECS/libason.spec']
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/mockbuild/trace_decorator.py", line 70, in trace
result = func(*args, **kw)
File "/usr/lib/python2.7/site-packages/mockbuild/util.py", line 378, in do
raise mockbuild.exception.Error, ("Command failed. See logs for output.\n # %s" % (command,), child.returncode)
Error: Command failed. See logs for output.
# ['bash', '--login', '-c', 'rpmbuild -bb --target x86_64 --nodeps builddir/build/SPECS/libason.spec']
LEAVE do --> EXCEPTION RAISED
Ok, I've updated both files. Everything is fixed but the spelling error (which I contest). jdulaney@gefjon:~/rpmbuild/SPECS$ rpmlint ./libason.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
jdulaney@gefjon:~/rpmbuild/SPECS$ rpmbuild -ba libason.spec
Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.dR3k0a
+ umask 022
+ cd /home/jdulaney/rpmbuild/BUILD
+ cd /home/jdulaney/rpmbuild/BUILD
+ rm -rf libason-0.1.1
+ /usr/bin/gzip -dc /home/jdulaney/rpmbuild/SOURCES/libason-0.1.1.tar.gz
+ /usr/bin/tar -xf -
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ cd libason-0.1.1
+ /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
+ echo 'Patch #0 (no_man_symlinks.patch):'
Patch #0 (no_man_symlinks.patch):
+ /usr/bin/cat /home/jdulaney/rpmbuild/SOURCES/no_man_symlinks.patch
+ /usr/bin/patch -p1 --fuzz=0
patching file doc/Makefile.am
+ echo 'Patch #1 (config-fix.patch):'
Patch #1 (config-fix.patch):
+ /usr/bin/patch -p1 --fuzz=0
+ /usr/bin/cat /home/jdulaney/rpmbuild/SOURCES/config-fix.patch
patching file configure.ac
+ exit 0
Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.Xjm10x
+ umask 022
+ cd /home/jdulaney/rpmbuild/BUILD
+ cd libason-0.1.1
+ autoreconf
configure.ac:6: error: required file './compile' not found
configure.ac:6: 'automake --add-missing' can install 'compile'
autoreconf: automake failed with exit status: 1
error: Bad exit status from /var/tmp/rpm-tmp.Xjm10x (%build)
RPM build errors:
Bad exit status from /var/tmp/rpm-tmp.Xjm10x (%build)
Ok, I think I've got the last of the gremlins. Files updated. Good to go. New Package SCM Request ======================= Package Name: libason Short Description: A library for manipulating ASON values Upstream URL: https://github.com/sadmac7000/libason Owners: sadmac Branches: f20 f21 rawhide InitialCC: rpmlint: jdulaney@gefjon:~/rpmbuild/SPECS$ rpmlint ./libason.spec ../RPMS/x86_64/libason-0.1.1-1.fc21.x86_64.rpm ../SRPMS/libason-0.1.1-1.fc21.src.rpm libason.x86_64: W: spelling-error %description -l en_US programmatically -> pro grammatically, pro-grammatically, programmatic ally libason.src: W: spelling-error %description -l en_US programmatically -> pro grammatically, pro-grammatically, programmatic ally 2 packages and 1 specfiles checked; 0 errors, 2 warnings. Git done (by process-git-requests). No need to request rawhide, it's automatic. libason-0.1.2-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/libason-0.1.2-1.fc20 libason-0.1.2-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/libason-0.1.2-1.fc21 libason-0.1.2-1.fc21 has been pushed to the Fedora 21 testing repository. Please pass this option to %configure: --disable-silent-rules I have done so. Builds in progress for all 3 branches. libason-0.1.2-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/libason-0.1.2-2.fc20 libason-0.1.2-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/libason-0.1.2-2.fc21 When will it pushed to stable? Pushed now. I believe the bot will close this when it lands libason-0.1.2-2.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. libason-0.1.2-2.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. |