Bug 1148982 (python-aiohttp)

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses.
[x]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/lib/python3.4/site-packages,
     /usr/lib/python3.4
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib/python3.4/site-packages,
     /usr/lib/python3.4
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
   ---> http://koji.fedoraproject.org/koji/taskinfo?taskID=7770252
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python-aiohttp-0.9.1-1.fc22.noarch.rpm
          python-aiohttp-0.9.1-1.fc22.src.rpm
python-aiohttp.noarch: W: spelling-error Summary(en_US) asyncio -> Asuncion
python-aiohttp.noarch: W: spelling-error %description -l en_US asyncio -> Asuncion
python-aiohttp.src: W: spelling-error Summary(en_US) asyncio -> Asuncion
python-aiohttp.src: W: spelling-error %description -l en_US asyncio -> Asuncion
2 packages and 0 specfiles checked; 0 errors, 4 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint python-aiohttp
python-aiohttp.noarch: W: spelling-error Summary(en_US) asyncio -> Asuncion
python-aiohttp.noarch: W: spelling-error %description -l en_US asyncio -> Asuncion
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
# echo 'rpmlint-done:'



Requires
--------
python-aiohttp (rpmlib, GLIBC filtered):
    python(abi)



Provides
--------
python-aiohttp:
    python-aiohttp



Source checksums
----------------
https://pypi.python.org/packages/source/a/aiohttp/aiohttp-0.9.1.tar.gz :
  CHECKSUM(SHA256) this package     : 758a16cc26afd01ae74fb14ae9a1246a9e686c50785e7b75b39657cb0c775afe
  CHECKSUM(SHA256) upstream package : 758a16cc26afd01ae74fb14ae9a1246a9e686c50785e7b75b39657cb0c775afe


Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1148982
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

===== Solution =====
      APPROVED

Thanks for the review.

New Package SCM Request
=======================
Package Name: python-aiohttp
Short Description:  A Python http client/server for asyncio
Owners: fab 
Branches: f20 f21 epel7
InitialCC:

Git done (by process-git-requests).

python-aiohttp-0.9.1-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/python-aiohttp-0.9.1-1.fc21

python-aiohttp-0.9.1-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/python-aiohttp-0.9.1-1.fc20

This should have been named as python3-aiohttp as it only provides python3 module and can conflict with existing package naming guidelines which suggests to use python-<modulename> for python2 modules and python3-<modulename> for python3 modules.

See https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28python_modules.29

You are right. I did the naming of the package wrong.

According the conversion on the mailing list, the name will work but a py3 package is needed.

python-aiohttp-0.9.1-2.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/python-aiohttp-0.9.1-2.fc21

python-aiohttp-0.9.1-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/python-aiohttp-0.9.1-2.fc20

Package python-aiohttp-0.9.1-2.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing python-aiohttp-0.9.1-2.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-12743/python-aiohttp-0.9.1-2.fc20
then log in and leave karma (feedback).

This package needs a python3-asyncio package to work on fedora 20 as asyncio is only included with python 3.4 (which is not in fedora 20)

here is the specific error message after installing:

$ python3
>>> import aiohttp
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/python3.3/site-packages/aiohttp/__init__.py", line 6, in <module>
    from .protocol import *
  File "/usr/lib/python3.3/site-packages/aiohttp/protocol.py", line 20, in <module>
    from aiohttp import errors
  File "/usr/lib/python3.3/site-packages/aiohttp/errors.py", line 9, in <module>
    from asyncio import TimeoutError
ImportError: No module named 'asyncio'

(In reply to Johnny Robeson from comment #13)
> This package needs a python3-asyncio package to work on fedora 20 as asyncio
> is only included with python 3.4 (which is not in fedora 20)

That's right. This issue should be fixed with the pending update (0.9.1-2). The package wil not be available for F20.

why not? asyncio seems to work just fine on 3.3 with the required package.

python-aiohttp-0.9.1-2.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.

python-aiohttp-0.9.1-2.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Johnny Robeson: I've opened https://bugzilla.redhat.com/show_bug.cgi?id=1168687