Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1150099
| Summary: | Review Request: python-neo - Represent electrophysiology data in Python | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ankur Sinha (FranciscoD) <sanjay.ankur> |
| Component: | Package Review | Assignee: | Orion Poplawski <orion> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | orion, package-review, quantum.analyst |
| Target Milestone: | --- | Flags: | orion:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-07-06 15:44:24 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1150090 | ||
| Bug Blocks: | 1276941, 1150105 | ||
|
Description
Ankur Sinha (FranciscoD)
2014-10-07 12:34:35 UTC
You can perform tests by using 'nosetests' and build documentation. See doc/source/developers_guide.rst . Any news here? Sorry Antonio, was on vacation. I'll build docs and run tests and update the ticket this week. Cheers, Ankur Updated - better late than never I guess: Updated to latest upstream release, tests run, documentation packaged. https://ankursinha.fedorapeople.org/python-neo/python-neo.spec https://ankursinha.fedorapeople.org/python-neo/python-neo-0.4.1-1.fc25.src.rpm Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=18323743 If you use the sources from github https://github.com/NeuralEnsemble/python-neo/releases it will contain LICENSE.txt. doc is pretty big: 2.4M usr/share/doc/python2-neo/html I would suggest making a single python-neo-doc sub-package with that directory. Updated spec/srpm: https://ankursinha.fedorapeople.org/python-neo/python-neo.spec https://ankursinha.fedorapeople.org/python-neo/python-neo-0.5.1-1.fc26.src.rpm * Mon Jun 26 2017 Ankur Sinha <ankursinha AT fedoraproject DOT org> - 0.5.1-1 - Update to latest upstream release I've split the docs into a new subpackage, and updated the package to the lastest upstream version using the sources from Github. I get a funny rpmlint error, but I can't figure out what I've done wrong at the moment.. python3-neo.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/neo/__init__.pyc expected 3379 (3.6), found 62211 (2.7) python3-neo.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/neo/core/__init__.pyc expected 3379 (3.6), found 62211 (2.7) python3-neo.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/neo/core/baseneo.pyc expected 3379 (3.6), found 62211 (2.7) python3-neo.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/neo/core/block.pyc expected 3379 (3.6), found 62211 (2.7) python3-neo.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/neo/core/channelindex.pyc expected 3379 (3.6), found 62211 (2.7) python3-neo.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/neo/core/container.pyc expected 3379 (3.6), found 62211 (2.7) python3-neo.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.6/site-packages/neo/core/segment.pyc expected 3379 (3.6), found 62211 (2.7) Cheers! Ankur The doc building is polluting your build directory with Python 2 compiled bytecode, which is getting installed to the Python 3 directory by a wholesale copy. Hello, Sorry for the rather long hiatus! New spec/srpm: https://ankursinha.fedorapeople.org/python-neo/python-neo.spec https://ankursinha.fedorapeople.org/python-neo/python-neo-0.6.1-1.fc28.src.rpm Cheers, Ankur! Python2 deps should all use python2- prefix (including numpy). Again, if you use the sources from github https://github.com/NeuralEnsemble/python-neo/releases it will contain LICENSE.txt. Is there any reason not to use it? Hello, I missed the comment about using the Github sources. I'm using them now. New spec/srpm: https://ankursinha.fedorapeople.org/python-neo/python-neo.spec https://ankursinha.fedorapeople.org/python-neo/python-neo-0.6.1-2.fc28.src.rpm * Mon Jun 18 2018 Ankur Sinha <ankursinha AT fedoraproject DOT org> - 0.6.1-2 - Use python dist macros - Use github source Cheers, Ankur Looks good to me. Approved. Thanks very much for the review! Requesting pagure repo now. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-neo python-neo-0.6.1-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-5d07d13a1a python-neo-0.6.1-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-09ab4c4289 python-neo-0.6.1-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-5d07d13a1a python-neo-0.6.1-2.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-09ab4c4289 python-neo-0.6.1-2.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. python-neo-0.6.1-2.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. |