Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1156648
Summary: | Library is packaged twice as libiguanaIR.so.0 and libiguanaIR.so.0.3 | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora EPEL | Reporter: | Michael Lampe <lampe> | ||||
Component: | iguanaIR | Assignee: | Alec Leamas <leamas.alec> | ||||
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | unspecified | Docs Contact: | |||||
Priority: | unspecified | ||||||
Version: | epel7 | CC: | hobbes1069, jeff.sadowski, leamas.alec, lnie | ||||
Target Milestone: | --- | Keywords: | Reopened | ||||
Target Release: | --- | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Whiteboard: | |||||||
Fixed In Version: | iguanaIR-1.1.0-13.fc21 iguanaIR-1.1.0-20.fc25 | Doc Type: | Bug Fix | ||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2017-04-05 05:23:05 UTC | Type: | Bug | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
Michael Lampe
2014-10-24 22:30:45 UTC
Reassigning to Fedora Rawhide since the EPEL build inherits the problem from it. Hopefully it's an easy fix. I did some horrible things to unwrap a circular dependency between lirc and IguanaIR combined with an unintended so-bump in IguanaIR. I don't really feel that this bug motivates a new release, but will check-in a fix in git. Alec, let me know if you need some help. The cmake setup for iguanaIR is pretty bad and I've already done some work to fix it. Is "runCmake" necessary? One of the main reasons to use cmake is because it's cross platform capable, no shell needed, which requiring a shell script completely invalidates. A few things I tried to address: 1. It looks like the SOVERSION and VERSION values are swapped from what they should be. 2. i haven't done it yet but I was going to change the set_property(target...) to the "set_target_property(...)" version which is more concise. 3. I'm pretty sure that setting the install destinations to an absolute path is what's creating the RPATH issues, they should always be relative to CMAKE_INSTALL_PREFIX, unless of course for the exceptions that are not supposed to be installed that way, (the stuff in etc?) If they are willing to target a higher version of cmake (2.8ish) then they could use the GNUInstallDirs module which specs out FHS compliant relative and absolute locations. I need to clean up my patch a bit but I'll attach it here soon. Hey, this is great! Some remarks: - I was stuck in a real mess due to the circular dependency. It took me a loooong time to really understand the situation, and I was eventually forced to make a new release of iguanaIR with the same so-name but without the dependency on lirc to break the circular dep. Nowm this is done and we should be able to maintain this in a more normal way. - I think you should try to talk to upstream about the cmake patches. They have been cooperative and and open to patches (I have upstreamed some already). - We also need to talk to upstream about what a so-bump really is... - lirc has dynamically loaded drivers in the pipe. Basically, this means that we should try to make the iguana folks to maintain also the lirc user-space driver. Created attachment 951154 [details]
Cmake fixes
Ok, this SEEMS to have done the trick. The rpmlint output isn't too horrible, it obviously doesn't like your soname trick :)
The rpath issues were a pain because the swig python module doesn't directly expose the target name, and if you use install(FILES instead of install(TARGETS then it doesn't remove the RPATH from the library when installed in the standard search path. Also, it didn't create both names for the library, let me know if is HAS to and I'll take a look at why it's not even though I'm specing out both the SOVERSION and VERSION. Don't really follow you... But bottom line is that the problems I had with the soname are gone now when the circular dep is broken. So, for next release there's nothing strange with the IguanaIR so-name (besides that we don't want to change it in released F21) iguanaIR-1.1.0-13.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/iguanaIR-1.1.0-13.fc21 iguanaIR-1.1.0-13.fc21 works Package iguanaIR-1.1.0-13.fc21: * should fix your issue, * was pushed to the Fedora 21 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing iguanaIR-1.1.0-13.fc21' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-16812/iguanaIR-1.1.0-13.fc21 then log in and leave karma (feedback). Related issue: When I run ldconfig I get an error claiming /lib64/libiguanaIR.so.0.3 is not a symbolic link a double number should be a symbolic link to a tripple number quick fix was mv /lib64/libiguanaIR.so.0.3 /lib64/libiguanaIR.so.0.3.0; ln -s /lib64/libiguanaIR.so.0.3.0 /lib64/libiguanaIR.so.0.3 iguanaIR-1.1.0-13.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. Should be reassigned to epel7, not closed. It started as an epel7 bug, and because an fc21 package doesn't help with epel7, it's still an epel7 bug. iguanaIR-1.1.0-19.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-6c5c51e913 iguanaIR-1.1.0-19.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-db9c1f3d91 iguanaIR-1.1.0-20.fc24 iguanaIR-1.1.0-20.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-7166b398c9 iguanaIR-1.1.0-20.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-2e7ffbd796 iguanaIR-1.1.0-20.fc24 iguanaIR-1.1.0-20.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-7166b398c9 iguanaIR-1.1.0-19.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-db9c1f3d91 iguanaIR-1.1.0-19.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-6c5c51e913 iguanaIR-1.1.0-20.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-7166b398c9 iguanaIR-1.1.0-20.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-2e7ffbd796 iguanaIR-1.1.0-20.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. |