Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1157302

Summary: Review Request: oldkilim - A generic configuration framework for Java
Product: [Fedora] Fedora Reporter: Dave Chen <wei.d.chen>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED CANTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: package-review, puntogil, wei.d.chen
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-10-10 01:43:25 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 177841, 201449    

Description Dave Chen 2014-10-27 02:12:56 UTC 
Spec URL: https://github.com/chendave/OAT2.X-fedora21-Dependencies/blob/master/oldkilim/oldkilim.spec
SRPM URL: https://github.com/chendave/OAT2.X-fedora21-Dependencies/blob/master/oldkilim/oldkilim-1.1.3-2_1fc.src.rpm

Could anyone give some review on this package, appreciate for any comments you drop by.
Comment 1 gil cattaneo 2015-12-04 19:57:52 UTC 
The spec file should be cleanup, please remove:

Group:		Development/Libraries/Java
#Vendor:		JPackage Project
#Distribution:	JPackage

BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-buildroot

Group: Development/Documentation

rm -rf $RPM_BUILD_ROOT in %install section

%clean
rm -rf $RPM_BUILD_ROOT

%post javadoc

%postun javadoc

%defattr(0644,root,root,0755)

* jar and javadoc must be without version, e.g.

# jars
install -d -m 755 $RPM_BUILD_ROOT%{_javadir}
install -pm 644 distrib/kilim.jar $RPM_BUILD_ROOT%{_javadir}/%{name}.jar
install -pm 644 distrib/kilim-tools.jar $RPM_BUILD_ROOT%{_javadir}/%{name}-tools.jar

# javadoc
install -p -d -m 755 $RPM_BUILD_ROOT%{_javadocdir}/%{name}
cp -pr doc/apis/* $RPM_BUILD_ROOT%{_javadocdir}/%{name}

%files javadoc
%{_javadocdir}/%{name}
Comment 2 Dave Chen 2016-10-10 01:43:25 UTC 
Thanks gil for the review, no one is working on this anymore, will close the request.