Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1159874 (lxqt-policykit)
| Summary: | Review Request: lxqt-policykit - PolicyKit agent for LXQt desktop suite | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Helio Chissini de Castro <hcastro> |
| Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jmunilla, package-review, projects.rg, rdieter, ti.eugene |
| Target Milestone: | --- | Flags: | rdieter:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-11-20 13:20:40 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1157402 | ||
| Bug Blocks: | |||
|
Description
Helio Chissini de Castro
2014-11-03 14:07:56 UTC
naming: ok
license: ok, though all source files are LGPL (v2.1 or later) , so you could up to
License: LGPLv2+
sources: ok
c35c7f466e79142d6ee83e234a517f35 lxqt-policykit-0.8.0.tar.xz
macros: ok
scriptlets: ok, n/a
1. SHOULD document need for
export CMAKE_PREFIX_PATH=%{_libdir}/cmake/PolkitQt5-1
(seems to build ok without it for me)
2. Ideally, this package probably SHOULD:
* include an autostart .desktop file, and...
* move the binary to %{_libexecdir} as other policykit agents work
but we can deal with that post-review (in collaboration with upstream).
Otherwise, pkg is small, clean, simple.
APPROVED.
Updated on https://heliocastro.fedorapeople.org/lxqt/lxqt-policykit-0.8.0-3.fc21.src.rpm https://heliocastro.fedorapeople.org/lxqt/lxqt-policykit.spec don't want/need %config here:
%config(noreplace) %{_sysconfdir}/xdg/autostart
otherwise, still looks good.
New Package SCM Request ======================= Package Name: lxqt-policykit Short Description: PolicyKit agent for LXQt desktop suite Upstream URL: http://lxqt.org Owners: heliocastro rdieter tieugene Branches: f20 f21 el6 epel7 InitialCC: heliocastro Git done (by process-git-requests). imported It seems the policykit agent was forgotten to test if it starts automatically in an user session and at login, see bug#1220159. |