Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1169140

Summary: Review Request: nodejs-util - Node.JS util module
Product: [Fedora] Fedora Reporter: Piotr Popieluch <piotr1212>
Component: Package ReviewAssignee: Parag AN(पराग) <panemade>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, panemade
Target Milestone: ---Flags: panemade: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: nodejs-util-0.10.3-2.fc21 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-12-14 12:37:08 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Piotr Popieluch 2014-11-30 17:10:31 UTC
Spec URL: https://piotrp.fedorapeople.org/nodejs-util.spec
SRPM URL: https://piotrp.fedorapeople.org/nodejs-util-0.10.3-1.fc21.src.rpm
Description: Node.JS util module
Fedora Account System Username: piotrp

Comment 1 Parag AN(पराग) 2014-12-06 15:46:49 UTC
Review:

+ Package built successful in mock (f22 x86_64)

+ rpmlint on generated rpms gave output
nodejs-util.noarch: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-util.noarch: W: only-non-binary-in-usr-lib
nodejs-util.noarch: W: dangling-symlink /usr/lib/node_modules/util/node_modules/inherits /usr/lib/node_modules/inherits@2
nodejs-util.src: W: spelling-error %description -l en_US js -> dis, ks, j
2 packages and 0 specfiles checked; 0 errors, 4 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball: 88033ac0a981b3c3919d7bf21e9808d0a2903c331688e4122bdd32eeea3dd6d0
upstream tarball:  88033ac0a981b3c3919d7bf21e9808d0a2903c331688e4122bdd32eeea3dd6d0

+ License is "MIT" and included in its own LICENSE file.

+ follows nodejs packaging guidelines.

Suggestions:
1) Group tag is optional, can be removed.

2) description can be same as %{summary}.
Node.js util module.

APPROVED.

Comment 2 Piotr Popieluch 2014-12-06 16:45:18 UTC
New Package SCM Request
=======================
Package Name: nodejs-util
Short Description: Node.JS util module
Upstream URL: https://github.com/defunctzombie/node-util
Owners: piotrp
Branches: f19 f20 f21 el6 epel7
InitialCC: piotrp

Comment 3 Gwyn Ciesla 2014-12-08 14:11:33 UTC
Git done (by process-git-requests).

Comment 4 Fedora Update System 2014-12-08 21:17:20 UTC
nodejs-util-0.10.3-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/nodejs-util-0.10.3-1.fc21

Comment 5 Fedora Update System 2014-12-08 21:18:53 UTC
nodejs-util-0.10.3-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/nodejs-util-0.10.3-1.fc20

Comment 6 Fedora Update System 2014-12-08 21:19:23 UTC
nodejs-util-0.10.3-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/nodejs-util-0.10.3-1.fc19

Comment 7 Fedora Update System 2014-12-08 21:19:54 UTC
nodejs-util-0.10.3-1.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/nodejs-util-0.10.3-1.el7

Comment 8 Fedora Update System 2014-12-11 06:32:21 UTC
nodejs-util-0.10.3-1.el7 has been pushed to the Fedora EPEL 7 testing repository.

Comment 9 Fedora Update System 2014-12-12 23:43:55 UTC
nodejs-util-0.10.3-2.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/nodejs-util-0.10.3-2.el7

Comment 10 Fedora Update System 2014-12-12 23:45:10 UTC
nodejs-util-0.10.3-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/nodejs-util-0.10.3-2.fc19

Comment 11 Piotr Popieluch 2014-12-14 12:37:08 UTC
Package built and in testing, closing bug.

Comment 12 Fedora Update System 2014-12-19 11:15:17 UTC
nodejs-util-0.10.3-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/nodejs-util-0.10.3-2.fc20

Comment 13 Fedora Update System 2014-12-20 08:40:09 UTC
nodejs-util-0.10.3-1.fc21 has been pushed to the Fedora 21 stable repository.

Comment 14 Fedora Update System 2014-12-28 18:07:06 UTC
nodejs-util-0.10.3-2.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/nodejs-util-0.10.3-2.fc21

Comment 15 Fedora Update System 2014-12-29 10:04:14 UTC
nodejs-util-0.10.3-2.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2014-12-29 19:03:44 UTC
nodejs-util-0.10.3-2.el7 has been pushed to the Fedora EPEL 7 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 17 Fedora Update System 2015-01-06 06:12:31 UTC
nodejs-util-0.10.3-2.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.