Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 117690
Summary: | (Radeon 7500) DRI breaks S3 Sleep | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Warren Togami <wtogami> | ||||||
Component: | XFree86 | Assignee: | Mike A. Harris <mharris> | ||||||
Status: | CLOSED RAWHIDE | QA Contact: | |||||||
Severity: | medium | Docs Contact: | |||||||
Priority: | medium | ||||||||
Version: | rawhide | CC: | aleksey, davej, notting | ||||||
Target Milestone: | --- | ||||||||
Target Release: | --- | ||||||||
Hardware: | i686 | ||||||||
OS: | Linux | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2004-03-19 04:36:26 UTC | Type: | --- | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Bug Depends On: | 117607 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Warren Togami
2004-03-07 09:01:33 UTC
There's a patch in 4.4pre CVS for this for the XFree86 radeon driver. Created attachment 98370 [details]
radeon powermanagement patch
I believe this is the power management patch to fix suspend. Feel free to try
it (if it's not it, I'll grovel around on my laptop some more for it. :) )
Created attachment 98390 [details]
XFree86-4.3.0-radeon-power-management-v1.patch
Merged it manually minus the whitespace changes, and attempted build into
XFree86-4.3.0-62 and attempted build on FC1. Strange build failure:
make[3]: Entering directory `/home/temp1/redhat/BUILD/XFree86-4.3.0/xc/lib/dps'
checking ../../config/pswrap/pswrap over in ../../config/pswrap first...
make[4]: Entering directory
`/home/temp1/redhat/BUILD/XFree86-4.3.0/xc/config/pswrap'
gcc -m32 -O2 -pipe -march=i386 -mcpu=i686 -fno-strict-aliasing -pipe -ansi
-pedantic -Wall -Wpointer-arith -Wundef -I../.. -I../../exports/include
-Dlinux -D__i386__ -D_POSIX_C_SOURCE=199309L
-D_POSIX_SOURCE -D_XOPEN_SOURCE -D_BSD_SOURCE
-D_SVID_SOURCE -D_GNU_SOURCE -DFUNCPROTO=15
-DNARROWPROTO -DXENVIRONMENT -c -o main.o main.c
bison -y -d pswparser.y
conflicts: 1 shift/reduce
make[4]: *** [pswparser.c] Broken pipe
make[4]: Leaving directory
`/home/temp1/redhat/BUILD/XFree86-4.3.0/xc/config/pswrap'
make[3]: *** [../../config/pswrap/pswrap] Error 2
make[3]: Leaving directory `/home/temp1/redhat/BUILD/XFree86-4.3.0/xc/lib/dps'
make[2]: *** [includes] Error 2
make[2]: Leaving directory `/home/temp1/redhat/BUILD/XFree86-4.3.0/xc/lib'
make[1]: *** [includes] Error 2
make[1]: Leaving directory `/home/temp1/redhat/BUILD/XFree86-4.3.0/xc'
make: *** [World] Error 2
make: Leaving directory `/home/temp1/redhat/BUILD/XFree86-4.3.0/xc'
error: Bad exit status from /var/tmp/rpm-tmp.59063 (%build)
Tried the same patch on XFree86-4.3.0-63 on FC1.90, build failure below. I
suspect a portion of the patch from upstream CVS is missing?
gcc -m32 -O2 -pipe -march=i386 -mcpu=i686 -fno-strict-aliasing -pipe -ansi
-pedantic -Wall -Wpointer-arith -Wundef -fno-merge-constants -I.
-I../../../../../../programs/Xserver/hw/xfree86/common
-I../../../../../../programs/Xserver/hw/xfree86/os-support
-I../../../../../../programs/Xserver/hw/xfree86
-I../../../../../../programs/Xserver/hw/xfree86/vbe
-I../../../../../../programs/Xserver/hw/xfree86/int10
-I../../../../../../programs/Xserver/hw/xfree86/ddc
-I../../../../../../programs/Xserver/hw/xfree86/i2c
-I../../../../../../programs/Xserver/hw/xfree86/rac
-I../../../../../../programs/Xserver/hw/xfree86/ramdac
-I../../../../../../programs/Xserver/hw/xfree86/shadowfb
-I../../../../../../programs/Xserver/hw/xfree86/xaa
-I../../../../../../programs/Xserver/hw/xfree86/xf24_32bpp
-I../../../../../../programs/Xserver/hw/xfree86/xf4bpp
-I../../../../../../programs/Xserver/hw/xfree86/xf1bpp
-I../../../../../../programs/Xserver/hw/xfree86/vgahw
-I../../../../../../programs/Xserver/hw/xfree86/fbdevhw
-I../../../../../../programs/Xserver/cfb
-I../../../../../../programs/Xserver/mfb
-I../../../../../../programs/Xserver/fb -I../../../../../../programs/Xserver/mi
-I../../../../../../programs/Xserver/miext/shadow
-I../../../../../../programs/Xserver/render
-I../../../../../../programs/Xserver/Xext
-I../../../../../../programs/Xserver/include
-I../../../../../../programs/Xserver/GL/dri -I../../../../../../lib/GL/dri
-I../../../../../../include -I../../../../../../include/fonts
-I../../../../../../include/extensions -I../../../../../../exports/include/X11
-I../../../../../.. -I../../../../../../exports/include -Dlinux -D__i386__
-D_POSIX_C_SOURCE=199309L -D_POSIX_SOURCE
-D_XOPEN_SOURCE -D_BSD_SOURCE -D_SVID_SOURCE
-D_GNU_SOURCE -DSHAPE -DXINPUT -DXKB
-DLBX -DXAPPGROUP -DXCSECURITY -DTOGCUP -DXF86BIGFONT -DDPMSExtension
-DPIXPRIV -DPANORAMIX -DRENDER -DRANDR -DGCCUSESGAS -DAVOID_GLYPHBLT
-DPIXPRIV -DSINGLEDEPTH -DXFreeXDGA -DXvExtension
-DXFree86LOADER -DXFree86Server
-DXF86VIDMODE -DXvMCExtension
-DSMART_SCHEDULE -DXResExtension
-DX_BYTE_ORDER=X_LITTLE_ENDIAN -DNDEBUG -DFUNCPROTO=15
-DNARROWPROTO -DIN_MODULE -DXFree86Module -DGLXEXT -DXF86DRI
-DGLX_DIRECT_RENDERING -DGLX_USE_DLOPEN -DGLX_USE_MESA -c radeon_driver.c
radeon_driver.c: In function `RADEONSetDynamicClock':
radeon_driver.c:6917: error: structure has no member named `RamWidth'
radeon_driver.c:6918: error: `R300_MEM_USE_CD_CH_ONLY' undeclared (first use in
this function)
radeon_driver.c:6918: error: (Each undeclared identifier is reported only once
radeon_driver.c:6918: error: for each function it appears in.)
make[7]: *** [radeon_driver.o] Error 1
make[7]: Leaving directory
`/home/builder/rpmbuild/BUILD/XFree86-4.3.0/xc/programs/Xserver/hw/xfree86/drivers/ati'
make[6]: *** [all] Error 2
make[6]: Leaving directory
`/home/builder/rpmbuild/BUILD/XFree86-4.3.0/xc/programs/Xserver/hw/xfree86/drivers'
make[5]: *** [all] Error 2
make[5]: Leaving directory
`/home/builder/rpmbuild/BUILD/XFree86-4.3.0/xc/programs/Xserver/hw/xfree86'
make[4]: *** [hw/xfree86] Error 2
make[4]: Leaving directory
`/home/builder/rpmbuild/BUILD/XFree86-4.3.0/xc/programs/Xserver'
make[3]: *** [all] Error 2
make[3]: Leaving directory
`/home/builder/rpmbuild/BUILD/XFree86-4.3.0/xc/programs'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/home/builder/rpmbuild/BUILD/XFree86-4.3.0/xc'
make[1]: *** [World] Error 2
make[1]: Leaving directory `/home/builder/rpmbuild/BUILD/XFree86-4.3.0/xc'
make: *** [World] Error 2
make: Leaving directory `/home/builder/rpmbuild/BUILD/XFree86-4.3.0/xc'
error: Bad exit status from /var/tmp/rpm-tmp.74576 (%build)
Arjan) I don't think this is a busmaster enable issue, but warren can test for that by doing lspci -vvv before suspending, then switching to tty1 prior to suspend, then resume and run lspci -vvv again to see if the busmaster bit was disabled. That usually prevents X from hanging for those cases. Warren) Unfortunately, the thing is that many changes have occured in XFree86 developement CVS in the radeon driver since Charl's dri-resume patch went into the tree, and it's non-trivial to isolate each possible bug fix from the larger changes that have occured in the last year (it's about 12 months or so since Charl wrote the initial patch). While it is definitely possible to backport all of the relevant bits, and include it, there are some really good reasons why not to do this, which I'd like to touch upon: Our current Radeon driver is very heavily patched already, and maintenance of it becomes more and more difficult with each overlapping patch that is applied. It would be easier to maintain the driver in a separate CVS repository directly than to keep patching it. Some of the patches we apply are applied conditionally, or there is need to enable some of them only for certain builds, which complicates thigns when patches overlap, as you need to maintain multiple patches that add the same functionality, but depend on which other conditionalized patches are being applied. Another issue, is that in the past, the XFree86 side changes for dri-resume patch to work, required kernel side changes as well, and it was never clear for a long time wether all of our supported OS releases got the patches for this from DRI CVS or not. Since we share XFree86 4.3.0 across RHL 9, FC1, RHEL3, it would have to be in the kernels of all of those releases in order to keep unnecessary conditionalization stew out of the spec file. ;o) I do not know if each OS release we ship 4.3.0 in has the needed changes or not, and it's been so long now since the patches were made that it would require research to make sure it would work in all OS releases. Additionally, this is a rather intrusive change, and has never been tested in the distribution proper, so it is not without risk of regression, which is particularly bad for the case of RHEL3, and a risk I would rather not take. To conditionalize the patch(es) out for RHEL3 invites additional maintenance burden as described above due to overlapping patches. The good news however, is that XFree86 4.4.0 has full support for this, and the X.org server tree has also. We are planning on putting X.org into the tree within the next few weeks anyway, so this functionality comes for free at that time with no engineering effort, and with much less risk of regression, and also is built into the upstream codebase, so has zero maintenance costs. ;o) RHL 9 goes EOL at the end of April IIRC, and Fedora Core 2 will be coming out not long after that. RHEL 3 with 4.3.0 has to be supported for 5 years however, and the risk of regression to RHEL to add support for this when the 2 main products it benefits would be EOL within months is not worth it, considering everyone is likely to upgrade to Fedora Core 2 when it is out (if not before then). The rpms of xorg-x11 once ready will most likely be installable on Fedora Core 1 and later unless I need to break that for some reason, and quite possibly will install on Red Hat Linux 9 with some updates from newer OS releases. So for the time being, it is not that this problem is unfixable, but rather that 4.3.0 has reached near end of life for us, and spending any engineering resources on possibly regression risky patches in the src.rpm which must share with RHEL3 and be supported for 4.5 more years, when we're ditching 4.3.0 ultrasoon is just not worth the risk IMHO. So for now, my recommendation is to wait a few weeks and upgrade to xorg X11 and it's radeon driver. I'll update this when xorg is in the tree. Thanks for your patience. ;o) It seems that this is fixed in xorg-x11! Now only Bug #117607 prevents S3 sleep from working on the Thinkpad T40 and T41. |