Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1178265
Summary: | osm2pgsql needs to link to -lboost_atomic | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Dan Horák <dan> | ||||
Component: | osm2pgsql | Assignee: | Fabian Affolter <mail> | ||||
Status: | CLOSED EOL | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | unspecified | Docs Contact: | |||||
Priority: | unspecified | ||||||
Version: | 21 | CC: | dakingun, denis.arnaud_fedora, mail, mnewsome, pertusus, rc040203 | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | s390x | ||||||
OS: | Unspecified | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2015-12-02 06:47:56 UTC | Type: | Bug | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 467765 | ||||||
Attachments: |
|
Description
Dan Horák
2015-01-03 13:06:21 UTC
the symptoms look like from http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=1680905 ... libtool: link: g++ -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -march=z9-109 -mtune=z10 -Wl,-z -Wl,relro -o osm2pgsql osm2pgsql.o -pthread ./.libs/libosm2pgsql.a -L/usr/lib -L/usr/lib64 -lpq -lxml2 -lz -lm -ldl -lbz2 -lgeos -lproj -lprotobuf-c -L/usr/lib/x86_64-linux-gnu -lboost_filesystem -lboost_system -lboost_thread -lstdc++ -pthread libtool: link: g++ -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -march=z9-109 -mtune=z10 -Wl,-z -Wl,relro -o nodecachefilereader node-persistent-cache-reader.o -pthread ./.libs/libosm2pgsql.a -L/usr/lib -L/usr/lib64 -lpq -lxml2 -lz -lm -ldl -lbz2 -lgeos -lproj -lprotobuf-c -L/usr/lib/x86_64-linux-gnu -lboost_filesystem -lboost_system -lboost_thread -lstdc++ -pthread ./.libs/libosm2pgsql.a(osmdata.o): In function `scoped_lock': /usr/include/boost/atomic/detail/lockpool.hpp:62: undefined reference to `boost::atomics::detail::lockpool::get_lock_for(void const volatile*)' /usr/include/boost/atomic/detail/lockpool.hpp:62: undefined reference to `boost::atomics::detail::lockpool::get_lock_for(void const volatile*)' /usr/include/boost/atomic/detail/lockpool.hpp:62: undefined reference to `boost::atomics::detail::lockpool::get_lock_for(void const volatile*)' /usr/include/boost/atomic/detail/lockpool.hpp:62: undefined reference to `boost::atomics::detail::lockpool::get_lock_for(void const volatile*)' /usr/include/boost/atomic/detail/lockpool.hpp:62: undefined reference to `boost::atomics::detail::lockpool::get_lock_for(void const volatile*)' ./.libs/libosm2pgsql.a(osmdata.o):/usr/include/boost/atomic/detail/lockpool.hpp:62: more undefined references to `boost::atomics::detail::lockpool::get_lock_for(void const volatile*)' follow collect2: error: ld returned 1 exit status Makefile:978: recipe for target 'osm2pgsql' failed osm2pgsql contains what amounts to the following snippet, which reproduces the problem: #include <boost/lockfree/queue.hpp> boost::lockfree::queue <size_t> queue; It should therefore link with Boost.Atomic. I don't think we can do anything on Boost side for this. (In reply to Dan Horák from comment #0) > -ifdef([HAS_ATOMIC_FLAG_LOCKFREE],[], > +ifdef(HAS_ATOMIC_FLAG_LOCKFREE,[], This happens to work because then -lboost_thread _always_ implies -lboost_atomic. But here the problem isn't caused by use of Boost.Thread, but by use of Boost.Lockfree. The reason that the line went away from libbost_thread.so linker script is that Boost now defines BOOST_ATOMIC_FLAG_LOCK_FREE on s390x as well, where it uses GCC builtins for atomics. Created attachment 976916 [details]
A fix
This fix seems appropriate before upstream can address this problem in a more constructive manner.
I just updated osm2pgsql to 0.88.1 on rawhide and f23. Could you please check if this bug still applies? This message is a reminder that Fedora 21 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 21. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '21'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 21 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. Fedora 21 changed to end-of-life (EOL) status on 2015-12-01. Fedora 21 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed. |