Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 119954
Summary: | (ACPI PATCH)Opps after 'rmmod button' | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Michal Jaegermann <michal> | ||||
Component: | kernel | Assignee: | Dave Jones <davej> | ||||
Status: | CLOSED CURRENTRELEASE | QA Contact: | |||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | 3 | CC: | acpi-bugzilla, pfrields | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2005-07-16 17:02:42 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 114963, 123268 | ||||||
Attachments: |
|
Description
Michal Jaegermann
2004-04-04 03:53:25 UTC
Perhaps you can test the fix here: http://bugzilla.kernel.org/show_bug.cgi?id=2281 > Perhaps you can test the fix here:
> http://bugzilla.kernel.org/show_bug.cgi?id=2281
A patch in this location is for 2.4 and not for 2.6. Still
based on it I made something which seems to be an equivalent
for 2.6.5-1.326smp (attached). Unfortunately this does not work.
In the same location this is causing somewhat different oops:
kernel BUG at fs/proc/generic.c:660!
invalid operand: 0000 [#1]
SMP
CPU: 0
EIP: 0060:[<021884fc>] Not tainted
EFLAGS: 00010206 (2.6.5-1.326smp)
EIP is at remove_proc_entry+0xa6/0xf6
eax: 21ec3d30 ebx: 2284461d ecx: 00000000 edx: 21ec3d30
esi: 21ec3d30 edi: 21c7d400 ebp: 00000006 esp: 1f66ef50
ds: 007b es: 007b ss: 0068
Process rmmod (pid: 1170, threadinfo=1f66e000 task=1eaae870)
Stack: 21ec3d00 2284461d 22845880 0231209c 00000000 1f66e000 228444d8
02133778
00000000 74747562 1d006e6f 1dc76080 f70e3000 0214a8b0 1e141a00
00000001
023d0000 02369000 02107c1f 1f66e000 02310238 1dc76080 1f66efc0
00000004
Call Trace:
[<228444d8>] acpi_button_exit+0x40/0x41 [button]
[<02133778>] sys_delete_module+0x124/0x166
[<0214a8b0>] unmap_vma_list+0xe/0x17
[<02107c1f>] do_IRQ+0x1c5/0x225
Code: 0f 0b 94 02 83 a6 2d 02 8b 47 40 85 c0 75 09 89 f8 e8 0c ff
and after that a machine dies immediately or pretty soon.
It is possible that my "port" is not really correct and/or sufficient.
Created attachment 99510 [details]
A patch used in an attempt to fix "remove button
And how about the patch in http://bugzilla.kernel.org/show_bug.cgi? id=2457. It fixes similar issue for processor but it applied on Button driver as well. Thanks Using the patch at bug id 2457 I was able to manually apply the patch to a 2.6.5-1.358 kernel but without any progress. I also downloaded and built a 2.6.6 tree from kernel.org using the .config from my 358 kernel. I'm still getting an oops removing battery, button, ac, et al. still an issue in 2.6.9? > still an issue in 2.6.9?
It does not seem to be at least when using 2.6.9-1.650_devel.
Len, this is still an issue in mainline 2.6.9, as we carry a hack so that we never kfree the object that gets referenced later.. diff -urNp linux-1130/drivers/acpi/ec.c linux-10000/drivers/acpi/ec.c --- linux-1130/drivers/acpi/ec.c +++ linux-10000/drivers/acpi/ec.c @@ -600,7 +600,7 @@ acpi_ec_add ( acpi_remove_gpe_handler(NULL, ec_ecdt->gpe_bit, &acpi_ec_gpe_handler); - kfree(ec_ecdt); +// kfree(ec_ecdt); } /* Get GPE bit assignment (EC events). */ Obviously, this is a really ugly hack, but leaking a few bytes at rmmod time is favourable over crashing until this gets fixed properly. An update has been released for Fedora Core 3 (kernel-2.6.12-1.1372_FC3) which may contain a fix for your problem. Please update to this new kernel, and report whether or not it fixes your problem. If you have updated to Fedora Core 4 since this bug was opened, and the problem still occurs with the latest updates for that release, please change the version field of this bug to 'fc4'. Thank you. |