Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1199737

Summary: Review Request: nodejs-isarray - Array#isArray for older browsers
Product: [Fedora] Fedora Reporter: Gerard Ryan <fedora>
Component: Package ReviewAssignee: Piotr Popieluch <piotr1212>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, piotr1212
Target Milestone: ---Flags: piotr1212: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: nodejs-isarray-0.0.1-1.fc23 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-03-21 22:46:43 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 956806, 1199738    

Description Gerard Ryan 2015-03-07 17:21:08 UTC
Spec URL: https://galileo.fedorapeople.org/fpe-rpm-review/nodejs-isarray.spec
SRPM URL: https://galileo.fedorapeople.org/fpe-rpm-review/nodejs-isarray-0.0.1-1.fc23.src.rpm
Description: Array#isArray for older browsers
Fedora Account System Username: galileo

Successful koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9169064

Comment 1 Piotr Popieluch 2015-03-20 21:10:58 UTC
APPROVED

Please add a comment that license is in README.md

Would you mind taking a look at bug 1200241 ? I need that for the update on nodejs-domutils.



Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = òanual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Unknown or generated". 2 files have unknown license. Detailed output of
     licensecheck in /home/piotr/rpmbuild/1199737-nodejs-
     isarray/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: nodejs-isarray-0.0.1-1.fc23.noarch.rpm
          nodejs-isarray-0.0.1-1.fc23.src.rpm
nodejs-isarray.noarch: W: only-non-binary-in-usr-lib
2 packages and 0 specfiles checked; 0 errors, 1 warnings.




Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:


Requires
--------
nodejs-isarray (rpmlib, GLIBC filtered):
    nodejs(engine)



Provides
--------
nodejs-isarray:
    nodejs-isarray
    npm(isarray)



Source checksums
----------------
http://registry.npmjs.org/isarray/-/isarray-0.0.1.tgz :
  CHECKSUM(SHA256) this package     : 3e8444020696800aed92a09d4c52602adc76140a39b6c8e94fe7c89cf70a9f0a
  CHECKSUM(SHA256) upstream package : 3e8444020696800aed92a09d4c52602adc76140a39b6c8e94fe7c89cf70a9f0a


Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/usr/bin/fedora-review -b 1199737
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

Comment 2 Gerard Ryan 2015-03-20 21:22:53 UTC
(In reply to Piotr Popieluch from comment #1)
> APPROVED
> 
> Please add a comment that license is in README.md
> 
> Would you mind taking a look at bug 1200241 ? I need that for the update on
> nodejs-domutils.
> 

Hi Piotr,

Thanks for the review! I'll add that comment before merging.

I'll review bug 1200241 for you this evening. I've had a busy couple of weeks, so haven't had a chance to look at anything Fedora related. I was just settling down to see the state of things, so it's a great surprise to see a new review approved! :)

Comment 3 Gerard Ryan 2015-03-20 21:24:23 UTC
New Package SCM Request
=======================
Package Name: nodejs-isarray
Short Description: Array#isArray for older browsers
Owners: galileo
Branches: f22 f21

Comment 4 Gwyn Ciesla 2015-03-21 16:44:07 UTC
Git done (by process-git-requests).

Comment 5 Gerard Ryan 2015-03-21 22:46:43 UTC
This is built in Rawhide now: http://koji.fedoraproject.org/koji/taskinfo?taskID=9292739

Thanks!