Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1205459
Summary: | Review Request: mingw-qt5-qtwebsockets - Qt5 for Windows - QtWebSockets component | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Erik van Pienbroek <erik-fedora> |
Component: | Package Review | Assignee: | Kalev Lember <kalevlember> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 21 | CC: | fedora-mingw, kalevlember, package-review |
Target Milestone: | --- | Flags: | kalevlember:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | mingw-qt5-qtwebsockets-5.4.1-1.el7 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2015-03-31 21:48:49 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 858058 | ||
Bug Blocks: |
Description
Erik van Pienbroek
2015-03-24 23:21:10 UTC
Fedora review mingw-qt5-qtwebsockets-5.4.1-1.fc23.src.rpm 2015-03-25 $ rpmlint mingw-qt5-qtwebsockets-5.4.1-1.fc22.src.rpm \ mingw32-qt5-qtwebsockets-5.4.1-1.fc22.noarch.rpm \ mingw64-qt5-qtwebsockets-5.4.1-1.fc22.noarch.rpm \ mingw32-qt5-qtwebsockets-debuginfo-5.4.1-1.fc22.noarch.rpm \ mingw64-qt5-qtwebsockets-debuginfo-5.4.1-1.fc22.noarch.rpm mingw-qt5-qtwebsockets.src:29: W: macro-in-comment %{qt_module} mingw-qt5-qtwebsockets.src:29: W: macro-in-comment %{snapshot_rev} mingw-qt5-qtwebsockets.src:29: W: macro-in-comment %{qt_module} mingw-qt5-qtwebsockets.src:29: W: macro-in-comment %{snapshot_rev} mingw32-qt5-qtwebsockets-debuginfo.noarch: E: debuginfo-without-sources mingw64-qt5-qtwebsockets-debuginfo.noarch: E: debuginfo-without-sources 5 packages and 0 specfiles checked; 2 errors, 4 warnings. + OK ! needs attention + rpmlint warnings are harmless and can be ignored + The package is named according to Fedora MinGW packaging guidelines + The spec file name matches the base package name. + The package meets the Packaging Guidelines + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The license field in the spec file matches the actual license + The stated license for the mingw package is the same as the one for the corresponding native Fedora package ! The license text is included in %license Can you use %license instead of %doc for the license files, please? + Spec file is written in American English + Spec file is legible + Upstream sources match the sources in the srpm 308e1e9126e6fab8b06616db9810973e qtwebsockets-opensource-src-5.4.1.tar.xz 308e1e9126e6fab8b06616db9810973e Download/qtwebsockets-opensource-src-5.4.1.tar.xz + The package builds in koji n/a ExcludeArch bugs filed + BuildRequires look sane n/a locale handling n/a ldconfig in %post and %postun + Package does not bundle copies of system libraries n/a Package isn't relocatable + Package owns all the directories it creates + No duplicate files in %files + Permissions are properly set + Consistent use of macros + The package must contain code or permissible content n/a Large documentation files should go in -doc subpackage + Files marked %doc should not affect the runtime of application n/a Static libraries should be in -static n/a Development files should be in -devel Not applicable to MinGW packages. n/a -devel must require the fully versioned base + Packages should not contain libtool .la files n/a Proper .desktop file handling + Doesn't own files or directories already owned by other packages + Filenames are valid UTF-8 Looks good to me, just a minor problem with the %license vs %doc macros -- the guidelines were recently updated to require the %license macro for license files. Please fix this before importing. APPROVED Thanks for the review! New Package SCM Request ======================= Package Name: mingw-qt5-qtwebsockets Short Description: Qt5 for Windows - QtWebSockets component Upstream URL: http://www.qt.io/ Owners: epienbro Branches: f20 f21 f22 epel7 InitialCC: Git done (by process-git-requests). mingw-qt5-qtwebsockets-5.4.1-1.fc22,mingw-qt5-qtxmlpatterns-5.4.1-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/mingw-qt5-qtwebsockets-5.4.1-1.fc22,mingw-qt5-qtxmlpatterns-5.4.1-1.fc22 mingw-qt5-qtwebsockets-5.4.1-1.fc21,mingw-qt5-qtxmlpatterns-5.4.1-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/mingw-qt5-qtwebsockets-5.4.1-1.fc21,mingw-qt5-qtxmlpatterns-5.4.1-1.fc21 mingw-qt5-qtwebsockets-5.4.1-1.fc20,mingw-qt5-qtxmlpatterns-5.4.1-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/mingw-qt5-qtwebsockets-5.4.1-1.fc20,mingw-qt5-qtxmlpatterns-5.4.1-1.fc20 mingw-qt5-qtwebsockets-5.4.1-1.el7,mingw-qt5-qtxmlpatterns-5.4.1-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/mingw-qt5-qtwebsockets-5.4.1-1.el7,mingw-qt5-qtxmlpatterns-5.4.1-1.el7 mingw-qt5-qtwebsockets-5.4.1-1.el7, mingw-qt5-qtxmlpatterns-5.4.1-1.el7 has been pushed to the Fedora EPEL 7 testing repository. mingw-qt5-qtwebsockets-5.4.1-1.fc22, mingw-qt5-qtxmlpatterns-5.4.1-1.fc22 has been pushed to the Fedora 22 stable repository. mingw-qt5-qtwebsockets-5.4.1-1.fc21, mingw-qt5-qtxmlpatterns-5.4.1-1.fc21 has been pushed to the Fedora 21 stable repository. mingw-qt5-qtwebsockets-5.4.1-1.fc20, mingw-qt5-qtxmlpatterns-5.4.1-1.fc20 has been pushed to the Fedora 20 stable repository. mingw-qt5-qtwebsockets-5.4.1-1.el7, mingw-qt5-qtxmlpatterns-5.4.1-1.el7 has been pushed to the Fedora EPEL 7 stable repository. |