Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1210969
| Summary: | Review Request: python-munch - A dot-accessible dictionary (a la JavaScript objects) | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ralph Bean <rbean> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | Pierre-YvesChibon <pingou> |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review, pingou |
| Target Milestone: | --- | Flags: | pingou:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-05-04 15:48:20 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Ralph Bean
2015-04-11 15:45:46 UTC
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9462321 You can drop the python2_sitearch definition at the top since you don't need it. Otherwise spec file looks clean * Using the sources from upstream: SRPM: 68fd192e64a22a69d445a74d84da640cb2314e9571114836864a7b5c06d1454d Upstream: 68fd192e64a22a69d445a74d84da640cb2314e9571114836864a7b5c06d1454d * License MIT is valid, present in the sources and installed correctly in the spec file * Spec file looks good ! rpmlint output can be improved: python-munch.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/munch/__init__.py 0644L /usr/bin/env python3-munch.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/munch/__init__.py 0644L /usr/bin/env 3 packages and 0 specfiles checked; 2 errors, 0 warnings. Maybe https://fedoraproject.org/wiki/Packaging_tricks#Remove_shebang_from_Python_libraries could help After this I'll approve the review Done. Removed shebang to make rpmlint happy. Spec URL: http://threebean.org/rpm/SPECS/python-munch.spec SRPM URL: http://threebean.org/rpm/SRPMS/python-munch-2.0.2-2.fc21.src.rpm OK, this package is APPROVED. New Package SCM Request ======================= Package Name: python-munch Short Description: A dot-accessible dictionary (a la JavaScript objects) Upstream URL: https://pypi.python.org/pypi/munch Owners: ralph Branches: f22 f21 f20 epel7 el6 InitialCC: Git done (by process-git-requests). python-munch-2.0.2-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/python-munch-2.0.2-2.el7 python-munch-2.0.2-2.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/python-munch-2.0.2-2.fc22 python-munch-2.0.2-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-munch-2.0.2-2.fc21 python-munch-2.0.2-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-munch-2.0.2-2.fc20 python-munch-2.0.2-2.fc22 has been pushed to the Fedora 22 stable repository. python-munch-2.0.2-2.fc20 has been pushed to the Fedora 20 stable repository. python-munch-2.0.2-2.fc21 has been pushed to the Fedora 21 stable repository. python-munch-2.0.2-2.el7 has been pushed to the Fedora EPEL 7 stable repository. |