Bug 1221231

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues
======

[!]: Changelog in prescribed format.
- Email address is missing

[!]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.

[!]: Latest version is packaged.
- Upstream has 1.0.2 now

[!]: Spec file according to URL is the same as in SRPM.

[!]: Rpmlint is run on all installed packages.
nodejs-async-some.noarch: W: spelling-error Summary(en_US) protototype -> prototype, typewrote
nodejs-async-some.noarch: W: summary-not-capitalized C short-circuited, asynchronous version of Array.protototype.some
nodejs-async-some.noarch: W: spelling-error %description -l en_US protototype -> prototype, typewrote
nodejs-async-some.src: W: spelling-error Summary(en_US) protototype -> prototype, typewrote
nodejs-async-some.src: W: summary-not-capitalized C short-circuited, asynchronous version of Array.protototype.some
nodejs-async-some.src: W: spelling-error %description -l en_US protototype -> prototype, typewrote
nodejs-async-some.src:15: W: mixed-use-of-spaces-and-tabs (spaces: line 8, tab: line 15)


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[-]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated". 4 files have unknown license. Detailed
     output of licensecheck in /home/tom/1221231-nodejs-async-
     some/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[!]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).
     See: (this test has no URL)
[!]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: nodejs-async-some-1.0.1-1.fc23.noarch.rpm
          nodejs-async-some-1.0.1-1.fc23.src.rpm
nodejs-async-some.noarch: W: spelling-error Summary(en_US) protototype -> prototype, typewrote
nodejs-async-some.noarch: W: summary-not-capitalized C short-circuited, asynchronous version of Array.protototype.some
nodejs-async-some.noarch: W: spelling-error %description -l en_US protototype -> prototype, typewrote
nodejs-async-some.noarch: W: only-non-binary-in-usr-lib
nodejs-async-some.noarch: W: dangling-symlink /usr/lib/node_modules/async-some/node_modules/dezalgo /usr/lib/node_modules/dezalgo
nodejs-async-some.src: W: spelling-error Summary(en_US) protototype -> prototype, typewrote
nodejs-async-some.src: W: summary-not-capitalized C short-circuited, asynchronous version of Array.protototype.some
nodejs-async-some.src: W: spelling-error %description -l en_US protototype -> prototype, typewrote
nodejs-async-some.src:15: W: mixed-use-of-spaces-and-tabs (spaces: line 8, tab: line 15)
2 packages and 0 specfiles checked; 0 errors, 9 warnings.




Rpmlint (installed packages)
----------------------------
nodejs-async-some.noarch: W: spelling-error Summary(en_US) protototype -> prototype, typewrote
nodejs-async-some.noarch: W: summary-not-capitalized C short-circuited, asynchronous version of Array.protototype.some
nodejs-async-some.noarch: W: spelling-error %description -l en_US protototype -> prototype, typewrote
nodejs-async-some.noarch: W: only-non-binary-in-usr-lib
nodejs-async-some.noarch: W: dangling-symlink /usr/lib/node_modules/async-some/node_modules/dezalgo /usr/lib/node_modules/dezalgo
1 packages and 0 specfiles checked; 0 errors, 5 warnings.



Diff spec file in url and in SRPM
---------------------------------
--- /home/tom/1221231-nodejs-async-some/srpm/nodejs-async-some.spec	2015-06-23 22:46:49.326392049 +0100
+++ /home/tom/1221231-nodejs-async-some/srpm-unpacked/nodejs-async-some.spec	2015-05-13 15:24:09.000000000 +0100
@@ -35,4 +35,6 @@
 
 %install
+rm -rf %buildroot
+
 mkdir -p %{buildroot}%{nodejs_sitelib}/%{npm_name}
 
@@ -48,8 +50,11 @@
 %endif
 
+%clean
+rm -rf %buildroot
+
 %files
-%{nodejs_sitelib}/%{npm_name}
+%{nodejs_sitelib}/async-some
+
 %doc README.md
-%license LICENSE
 
 %changelog


Requires
--------
nodejs-async-some (rpmlib, GLIBC filtered):
    nodejs(engine)
    npm(dezalgo)



Provides
--------
nodejs-async-some:
    nodejs-async-some
    npm(async-some)



Source checksums
----------------
http://registry.npmjs.org/async-some/-/async-some-1.0.1.tgz :
  CHECKSUM(SHA256) this package     : 7026f40c425f8d822473aa02afbfa15e42522deb5b8a04e586a55a19783ab515
  CHECKSUM(SHA256) upstream package : 7026f40c425f8d822473aa02afbfa15e42522deb5b8a04e586a55a19783ab515


Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -m compton-rawhide-x86_64 -b 1221231
Buildroot used: compton-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Fixed.

Spec URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-async-some/nodejs-async-some.spec
SRPM URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-async-some/nodejs-async-some-1.0.2-1.fc22.src.rpm

That looks good now. Package approved.

Thank you.

New Package SCM Request
=======================
Package Name: nodejs-async-some
Short Description: Short-circuited, asynchronous version of Array.prototype.some
Upstream URL: https://github.com/othiym23/async-some
Owners: zvetlik
Branches: f21 f22 el6 epel7

Git done (by process-git-requests).

nodejs-async-some-1.0.2-1.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/nodejs-async-some-1.0.2-1.fc22

nodejs-async-some-1.0.2-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/nodejs-async-some-1.0.2-1.fc21

nodejs-async-some-1.0.2-1.fc22 has been pushed to the Fedora 22 testing repository.

nodejs-async-some-1.0.2-1.fc21 has been pushed to the Fedora 21 stable repository.

nodejs-async-some-1.0.2-1.fc22 has been pushed to the Fedora 22 stable repository.