Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1231736
| Summary: | git-core is strangely split from git | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Roman Kagan <rkagan> |
| Component: | git | Assignee: | Petr Stodulka <pstodulk> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 22 | CC: | aliakc, bruno, chrisw, gwync, jbowes, mikhail.v.gavrilov, ooprala, pstodulk, raulmariuszay, rkagan, tmokros, tmz |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | git-2.4.3-3.fc22 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-06-23 09:11:27 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Hi Roman, in version git-2.4.3-1 it was split wrong but it's old version. I got it and fix it since git-2.4.3-2. The older git shouldn't be built earlier and should be checked before this. However, no one else (I guess) check any changes and new builds were done for rebase of Perl and Git too. Can you please check latest version, where git-core is split to git-core and git-core-doc? There it should be ok already. Why is this commit in F22?!!!! I really push it only to rawhide and I see here my commit on both branches without any info about merge! Who do that?!!! git-core will be obsoleted and provided by git again. This split can't be done in F22 due to some other packages which are dependent on git binary. git-2.4.3-2.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/git-2.4.3-2.fc22 The obsoletes was done incorrecty. git-core <= 2.4.3-1 will not obsolete git-core-2.4.3-1.f22 as 1.f22 > 1 . You either need <= 2.4.3 or < 2.4.3-2 . (In reply to pstodulk from comment #2) > Why is this commit in F22?!!!! I really push it only to rawhide and I see > here my commit on both branches without any info about merge! Who do that?!!! It came with when I updated to 2.4.3. I'm only updating 2.4.4 in rawhide at this time. It wasn't aware that the git-core split was only intended for rawhide, it upgraded on my system without issue. *** Bug 1232464 has been marked as a duplicate of this bug. *** Jon: sigh... Yes it is. Do you read bugzillas for git? There is written that's planned since F23 [0]. Otherwise, packages in released fedora should never be rebased if there is not good reason for that. And anything like new subpackages and so, shouldn't be done hidden without any comments of changes in bodhi. [0] https://bugzilla.redhat.com/show_bug.cgi?id=1161251 Bruno: Thanks for feedback. I apologize that I didn't test it due to missing F22 virtual machine. I installed it for testing now, so next build should be ok. I don't, I'll check in the future. I didn't see anything about it in the changelog so it didn't occur to me. Do you plan to backport 2.4.4 to f22 once the Provides have been sorted out? That's ok. Everyone does mistakes. I don't plan any other rebases in f22 for git. v2.4.3 should be kept in F22 during lifecycle. *** Bug 1232715 has been marked as a duplicate of this bug. *** *** Bug 1233377 has been marked as a duplicate of this bug. *** Package git-2.4.3-3.fc22: * should fix your issue, * was pushed to the Fedora 22 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing git-2.4.3-3.fc22' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2015-10067/git-2.4.3-3.fc22 then log in and leave karma (feedback). git-2.4.3-3.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. |
Description of problem: Fedora git package recently introduced git-core subpackage which is required by git. OTOH the contents of both packages overlaps significantly, with most files provided by both packages, and docs duplicated in the corresponding doc directories. Besides, the declared purpose of the split which, according to changelog, was to isolate git-core from perl dependencies, isn't achieved. Version-Release number of selected component (if applicable): git-2.4.3-1.fc22.x86_64 apparently introduced in 2.4.2-2. Proof: files in git only: # LC_ALL=C comm -23 <(rpm -q git -l | LC_ALL=C sort) \ <(rpm -q git-core -l | sed 's@\(/usr/share/doc/git\)-core@\1@' | LC_ALL=C sort) | wc -l 17 files in git-core: # LC_ALL=C comm -13 <(rpm -q git -l | LC_ALL=C sort) \ <(rpm -q git-core -l | sed 's@\(/usr/share/doc/git\)-core@\1@' | LC_ALL=C sort) | wc -l 548 files in both git and git-core: # LC_ALL=C comm -12 <(rpm -q git -l | LC_ALL=C sort) \ <(rpm -q git-core -l | sed 's@\(/usr/share/doc/git\)-core@\1@' | LC_ALL=C sort) | wc -l 752 git requires git-core: # rpm -q git -R |fgrep git git-core = 2.4.3-1.fc22 perl dependencies in git-core: # rpm -q git-core -R |fgrep perl /usr/bin/perl perl(File::Basename) perl(File::Find) perl(File::Spec) perl(Getopt::Long) perl(strict) I must admit that the whole -core split doesn't look justified, at least in its current state.