Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1257288

Summary: please build libgit2 against libcurl
Product: [Fedora] Fedora Reporter: Dirk Hohndel <dirk>
Component: libgit2Assignee: Veeti Paananen <veeti.paananen>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 23CC: dirk, i, ignatenko, pingou, veeti.paananen
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
Whiteboard:
Fixed In Version: 0.23.1-1.fc23 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-09-04 03:22:45 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1259346    

Description Dirk Hohndel 2015-08-26 16:58:54 UTC 
User-Agent:       Mozilla/5.0 (X11; Linux x86_64; rv:40.0) Gecko/20100101 Firefox/40.0
Build Identifier: 

the libgit2 maintainers decided to use libcurl as their advanced transport for http/https based traffic. In order to allow libgit2 to work through http/https proxies it has to be built against libcurl
I believe all that is needed is to have a build requirement for libcurl-devel; the libgit2 cmake file will detect libcurl and automatically build against this.

Reproducible: Always

Steps to Reproduce:
1.build an application against libgit2 (e.g. Subsurface master)
2.try to access an https based git repository while behind a reverse proxy / firewall that blocks direct https access (e.g. try to access Subsurface cloud storage in a typical corporate environment)

Actual Results:  
access to the remote repository fails even if the correct proxies are set up as libgit2 as currently shipped in Fedora isn't built against libcurl and therefore doesn't support http/https proxies

Expected Results:  
access to the remote repository should work with correctly configured proxy settings
Comment 1 Pierre-YvesChibon 2015-09-02 12:28:10 UTC 
Ping?

I am a provenpackager and can take care of rebuilding libgit2 with a new BR on libcurl-devel.

This should impact consumers of libgit2 since we're just rebuilding the package, no change in the version, so it sounds like an easy build :)

Let me know if you want to me to care of it.
Comment 2 Veeti Paananen 2015-09-02 13:19:03 UTC 
Sorry, I'll get this done in a moment.
Comment 3 Fedora Update System 2015-09-02 15:27:45 UTC 
libgit2-0.23.1-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-14884
Comment 4 Fedora Update System 2015-09-03 09:52:29 UTC 
libgit2-0.23.1-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update libgit2'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-14884
Comment 5 Fedora Update System 2015-09-04 03:22:42 UTC 
libgit2-0.23.1-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.