Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1258425
Summary: | Use __isa_bits macro instead of list of 64-bit architectures | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Marcin Juszkiewicz <mjuszkie> | ||||||
Component: | nspr | Assignee: | Elio Maldonado Batiz <emaldona> | ||||||
Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
Severity: | unspecified | Docs Contact: | |||||||
Priority: | unspecified | ||||||||
Version: | rawhide | CC: | emaldona, kengert, ovasik | ||||||
Target Milestone: | --- | ||||||||
Target Release: | --- | ||||||||
Hardware: | ppc64le | ||||||||
OS: | Unspecified | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | nspr-4.10.10-2.fc21, nspr-4.10.10-2.fc22, nspr-4.10.10-2.fc23, nss-util-3.21.0-1.0.fc23, nss-util-3.21.0-1.0.fc22, nss-3.21.0-1.0.fc21, nss-softokn-3.21.0-1.0.fc23, nss-softokn-3.21.0-1.0.fc22, nss-softokn-3.21.0-1.0.fc21, nss-3.21.0-1.0.fc23, nss-3.21.01 | Doc Type: | Bug Fix | ||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2016-02-10 01:07:11 UTC | Type: | Bug | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Bug Depends On: | |||||||||
Bug Blocks: | 1051573 | ||||||||
Attachments: |
|
Thank you Marcin, I'll make the change and adapt for latest sources as needed. We should also do it for the nss-util, nss-softokn and nss packages. I checked and the same has already been done for RHEL since RHEL-7.1. Comment on attachment 1068610 [details] spec change This patch woks if you do fedpkg mockbuild or a scratch build. A regular build, failed http://koji.fedoraproject.org/koji/getfile?taskID=11837671&name=build.log&offset=-4000 Tried locally /usr/bin/rpmbuild -bs --target noarch --nodeps ./nspr.spec witch failed in the same way. The problems that when building the srpm it is a noarch and __isa_bits doesn't it apply. One must have the _isa_bits check bracketed by %ifnarch noarch ... %endif as follows: %ifnarch noarch %if 0%{__isa_bits} == 64 --enable-64bit \ %endif %endif That works: http://koji.fedoraproject.org/koji/buildinfo?buildID=699375 Created attachment 1094219 [details]
spec change V2 - in patch format
nss-3.21.0-1.0.fc23 nss-softokn-3.21.0-1.0.fc23 nss-util-3.21.0-1.0.fc23 nspr-4.10.10-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-bc355f6cdd nspr-4.10.10-2.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-ae4c9ec179 nss-3.21.0-1.0.fc21 nss-softokn-3.21.0-1.0.fc21 nspr-4.10.10-2.fc21 has been submitted as an update to Fedora 21. https://bodhi.fedoraproject.org/updates/FEDORA-2015-2cccce34fc nspr-4.10.10-2.fc23, nss-3.21.0-1.0.fc23, nss-softokn-3.21.0-1.0.fc23, nss-util-3.21.0-1.0.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update nss nspr nss-softokn nss-util' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-bc355f6cdd nspr-4.10.10-2.fc22, nss-3.21.0-1.0.fc22, nss-softokn-3.21.0-1.0.fc22, nss-util-3.21.0-1.0.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update nspr nss-softokn nss nss-util' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-ae4c9ec179 nspr-4.10.10-2.fc23, nss-3.21.0-1.0.fc23, nss-softokn-3.21.0-1.0.fc23, nss-util-3.21.0-1.0.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. nspr-4.10.10-2.fc21, nss-3.21.0-1.0.fc21, nss-softokn-3.21.0-1.0.fc21, nss-util-3.21.0-1.0.fc21 has been pushed to the Fedora 21 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update nspr nss nss-util nss-softokn' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-2cccce34fc nspr-4.10.10-2.fc22 nss-3.21.0-1.1.fc22 nss-softokn-3.21.0-1.0.fc22 nss-util-3.21.0-1.0.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-ae4c9ec179 nspr-4.10.10-2.fc22 nss-3.21.0-1.1.fc22 nss-softokn-3.21.0-1.1.fc22 nss-util-3.21.0-1.0.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-ae4c9ec179 nspr-4.10.10-2.fc21 nss-3.21.0-1.1.fc21 nss-softokn-3.21.0-1.1.fc21 nss-util-3.21.0-1.0.fc21 has been submitted as an update to Fedora 21. https://bodhi.fedoraproject.org/updates/FEDORA-2015-2cccce34fc nspr-4.10.10-2.fc21, nss-3.21.0-1.1.fc21, nss-softokn-3.21.0-1.1.fc21, nss-util-3.21.0-1.0.fc21 has been pushed to the Fedora 21 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update nspr nss-util nss nss-softokn' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-2cccce34fc nspr-4.10.10-2.fc22, nss-3.21.0-1.1.fc22, nss-softokn-3.21.0-1.1.fc22, nss-util-3.21.0-1.0.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update nspr nss-softokn nss nss-util' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-ae4c9ec179 nspr-4.10.10-2.fc22, nss-3.21.0-1.1.fc22, nss-softokn-3.21.0-1.1.fc22, nss-util-3.21.0-1.0.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. |
Created attachment 1068610 [details] spec change Description of problem: nspr can be built in 64bit mode. Current specfile handles it by %ifarch macro with list of 64-bit architectures. But this list is incomplete. It is also not best way to check for 32/64-bit. Use of %__isa_bits macro is how it should be done. Version-Release number of selected component (if applicable): 4.10.8-2 How reproducible: always Actual results: ppc64le is treated as 32bit Expected results: all current and future 64-bit architectures are treated as 64-bit Additional info: