Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1259333
Summary: | Review Request: python-mox3 - Mock object framework for Python | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Lukas Bezdicka <lbezdick> |
Component: | Package Review | Assignee: | Lukas Bezdicka <social> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | apevec, karlthered, lrintel, package-review, social |
Target Milestone: | --- | Keywords: | Reopened |
Target Release: | --- | Flags: | lrintel:
fedora-review+
gwync: fedora-cvs+ |
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2015-11-20 15:25:13 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 1259286 | ||
Bug Blocks: | 1154650, 1243533, 1259400 |
Description
Lukas Bezdicka
2015-09-02 12:14:38 UTC
* Named correctly * Version tag correct, packaging latest version * The source file is the same as distributed by upstream * License tag correct * License fine for Fedora * SPEC file clean and legible - Does not build in mock The fedora-23-x86_64 build fails: http://paste.fedoraproject.org/262924/12693631 - The package seems to depend on some particular versions of other packages (hence the build failure) Please use versioned Requires/BuildRequires whenever possible - The URL tag is incorrect You may want to use https://pypi.python.org/pypi/mox3 instead Just for the record, package fails to build without the newer python-subunit build as tests fail. http://koji.fedoraproject.org/koji/buildinfo?buildID=682335 I have to investigate with subunit fails to build in F23, but it'll be fixed. Package complies with new python guidelines. somes fixes * drop the following comment or expand it: # https://bugs.launchpad.net/heat-cfntools/+bug/1403214/ * missing requires to six, fixtures and testtools * about versioning, I would only require that we set min version on python-six 1.9.0, as it could break updates on EL7 (this package will be needed for OpenStack) * Filelists sane * RPMlint happy * Provides sane * Requires sane Do not: # Remove bundled egg-info rm -rf %{pypi_name}.egg-info It was misguided packaging guideline, corrected in the meantime: https://fedorahosted.org/fpc/ticket/488 Egg _binaries_ need to be removed, not Egg _metadata_ For packages using PBR metadata cannot be completely generated from sdist tarball. Spec URL: https://social.fedorapeople.org/python-mox3.spec SRPM URL: https://social.fedorapeople.org/python-mox3-0.9.0-4.fc22.src.rpm Fine now. APPROVED New Package SCM Request ======================= Package Name: python-mox3 Short Description: Mock object framework for Python Upstream URL: http://git.openstack.org/cgit/openstack/mox3 Owners: social apevec chandankumar Branches: InitialCC: New Package SCM Request ======================= Package Name: python-mox3 Short Description: Mock object framework for Python Upstream URL: http://git.openstack.org/cgit/openstack/mox3 Owners: social apevec chandankumar Branches: InitialCC: Git done (by process-git-requests). Package Change Request ====================== Package Name: python-mox3 New Branches: f22 f23 Owners: social apevec chandankumar InitialCC: Git done (by process-git-requests). python-mox3-0.10.0-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-2798ddf72b python-mox3-0.10.0-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-1359a57f2c python-mox3-0.10.0-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update python-mox3' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-1359a57f2c python-mox3-0.10.0-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update python-mox3' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-1359a57f2c python-mox3-0.10.0-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update python-mox3' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-2798ddf72b python-mox3-0.10.0-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. python-mox3-0.10.0-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. |