Bug 1260290

Hello mrunge,

Here is the updated 
SPEC file: https://chandankumar.fedorapeople.org/python-XStatic-roboto-fontface.spec
SRPM: https://chandankumar.fedorapeople.org/python-XStatic-roboto-fontface-0.4.3.2-1.fc22.src.rpm

Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=10986719

Please have a look.

Thanks,

Chandan Kumar

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
     Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated". 4 files have unknown license. Detailed
     output of licensecheck in /home/mrunge/review/review-python-XStatic-
     roboto-fontface/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
     Note: Using prebuilt rpms.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[!]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 40960 bytes in 4 files.
[!]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[!]: Reviewer should test that the package builds in mock.
[!]: Avoid bundling fonts in non-fonts packages.
     Note: Package contains font files
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2
     -XStatic-roboto-fontface , roboto-fontface-common , roboto-fontface-
     fonts , python3-XStatic-roboto-fontface
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python2-XStatic-roboto-fontface-0.4.3.2-1.fc24.noarch.rpm
          roboto-fontface-common-0.4.3.2-1.fc24.noarch.rpm
          roboto-fontface-fonts-0.4.3.2-1.fc24.noarch.rpm
          python3-XStatic-roboto-fontface-0.4.3.2-1.fc24.noarch.rpm
          python-XStatic-roboto-fontface-0.4.3.2-1.fc22.src.rpm
python2-XStatic-roboto-fontface.noarch: W: summary-not-capitalized C roboto-fontface
python2-XStatic-roboto-fontface.noarch: W: spelling-error %description -l en_US javascript -> java script, java-script, JavaScript
python2-XStatic-roboto-fontface.noarch: W: spelling-error %description -l en_US setuptools -> setup tools, setup-tools, toadstools
roboto-fontface-common.noarch: W: summary-not-capitalized C roboto-fontface
roboto-fontface-fonts.noarch: W: summary-not-capitalized C roboto-fontface fonts
roboto-fontface-fonts.noarch: E: script-without-shebang /usr/share/fonts/roboto_fontface/Roboto-Light.svg
roboto-fontface-fonts.noarch: E: script-without-shebang /usr/share/fonts/roboto_fontface/Roboto-Black.svg
roboto-fontface-fonts.noarch: E: script-without-shebang /usr/share/fonts/roboto_fontface/Roboto-BlackItalic.svg
roboto-fontface-fonts.noarch: E: script-without-shebang /usr/share/fonts/roboto_fontface/Roboto-LightItalic.svg
roboto-fontface-fonts.noarch: E: script-without-shebang /usr/share/fonts/roboto_fontface/Roboto-Bold.svg
roboto-fontface-fonts.noarch: E: script-without-shebang /usr/share/fonts/roboto_fontface/Roboto-BoldItalic.svg
roboto-fontface-fonts.noarch: E: script-without-shebang /usr/share/fonts/roboto_fontface/Roboto-Medium.svg
roboto-fontface-fonts.noarch: E: script-without-shebang /usr/share/fonts/roboto_fontface/Roboto-ThinItalic.svg
roboto-fontface-fonts.noarch: E: script-without-shebang /usr/share/fonts/roboto_fontface/Roboto-MediumItalic.svg
roboto-fontface-fonts.noarch: E: script-without-shebang /usr/share/fonts/roboto_fontface/Roboto-Thin.svg
roboto-fontface-fonts.noarch: E: script-without-shebang /usr/share/fonts/roboto_fontface/Roboto-RegularItalic.svg
roboto-fontface-fonts.noarch: E: script-without-shebang /usr/share/fonts/roboto_fontface/Roboto-Regular.svg
python3-XStatic-roboto-fontface.noarch: W: summary-not-capitalized C roboto-fontface
python3-XStatic-roboto-fontface.noarch: W: spelling-error %description -l en_US javascript -> java script, java-script, JavaScript
python3-XStatic-roboto-fontface.noarch: W: spelling-error %description -l en_US setuptools -> setup tools, setup-tools, toadstools
python-XStatic-roboto-fontface.src: W: summary-not-capitalized C roboto-fontface
python-XStatic-roboto-fontface.src: W: spelling-error %description -l en_US javascript -> java script, java-script, JavaScript
python-XStatic-roboto-fontface.src: W: spelling-error %description -l en_US setuptools -> setup tools, setup-tools, toadstools
5 packages and 0 specfiles checked; 12 errors, 11 warnings.




Rpmlint (installed packages)
----------------------------
roboto-fontface-common.noarch: W: summary-not-capitalized C roboto-fontface
python2-XStatic-roboto-fontface.noarch: W: summary-not-capitalized C roboto-fontface
roboto-fontface-fonts.noarch: W: summary-not-capitalized C roboto-fontface fonts
roboto-fontface-fonts.noarch: E: script-without-shebang /usr/share/fonts/roboto_fontface/Roboto-BoldItalic.svg
roboto-fontface-fonts.noarch: E: script-without-shebang /usr/share/fonts/roboto_fontface/Roboto-Black.svg
roboto-fontface-fonts.noarch: E: script-without-shebang /usr/share/fonts/roboto_fontface/Roboto-LightItalic.svg
roboto-fontface-fonts.noarch: E: script-without-shebang /usr/share/fonts/roboto_fontface/Roboto-MediumItalic.svg
roboto-fontface-fonts.noarch: E: script-without-shebang /usr/share/fonts/roboto_fontface/Roboto-Medium.svg
roboto-fontface-fonts.noarch: E: script-without-shebang /usr/share/fonts/roboto_fontface/Roboto-Bold.svg
roboto-fontface-fonts.noarch: E: script-without-shebang /usr/share/fonts/roboto_fontface/Roboto-Light.svg
roboto-fontface-fonts.noarch: E: script-without-shebang /usr/share/fonts/roboto_fontface/Roboto-ThinItalic.svg
roboto-fontface-fonts.noarch: E: script-without-shebang /usr/share/fonts/roboto_fontface/Roboto-RegularItalic.svg
roboto-fontface-fonts.noarch: E: script-without-shebang /usr/share/fonts/roboto_fontface/Roboto-Thin.svg
roboto-fontface-fonts.noarch: E: script-without-shebang /usr/share/fonts/roboto_fontface/Roboto-Regular.svg
roboto-fontface-fonts.noarch: E: script-without-shebang /usr/share/fonts/roboto_fontface/Roboto-BlackItalic.svg
python3-XStatic-roboto-fontface.noarch: W: summary-not-capitalized C roboto-fontface
4 packages and 0 specfiles checked; 12 errors, 4 warnings.



Requires
--------
roboto-fontface-common (rpmlib, GLIBC filtered):
    web-assets-filesystem

python2-XStatic-roboto-fontface (rpmlib, GLIBC filtered):
    python(abi)
    python-XStatic
    roboto-fontface-common
    roboto-fontface-fonts

roboto-fontface-fonts (rpmlib, GLIBC filtered):
    fontpackages-filesystem

python3-XStatic-roboto-fontface (rpmlib, GLIBC filtered):
    python(abi)
    python3-XStatic
    roboto-fontface-common
    roboto-fontface-fonts



Provides
--------
roboto-fontface-common:
    roboto-fontface-common

python2-XStatic-roboto-fontface:
    python-XStatic-roboto-fontface
    python2-XStatic-roboto-fontface

roboto-fontface-fonts:
    roboto-fontface-fonts

python3-XStatic-roboto-fontface:
    python3-XStatic-roboto-fontface



Source checksums
----------------
https://pypi.python.org/packages/source/X/XStatic-roboto-fontface/XStatic-roboto-fontface-0.4.3.2.tar.gz :
  CHECKSUM(SHA256) this package     : e539aa991300d8ee09ee557d3cab1066237806e365ceaf868084777379e307a5
  CHECKSUM(SHA256) upstream package : e539aa991300d8ee09ee557d3cab1066237806e365ceaf868084777379e307a5


Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20


- Please use google-roboto-fonts instead of bundled fonts
- please fix rpmlint errors
- please add a bit more description to summary other than roboto-fontface
that is a bit too less information for listing in packages overview

Hello,

Thanks for the review,

Here is the updated 
spec file: https://chandankumar.fedorapeople.org/python-XStatic-roboto-fontface.spec
srpm : https://chandankumar.fedorapeople.org/python-XStatic-roboto-fontface-0.4.3.2-2.fc22.src.rpm

Thanks,

Chandan Kumar

Hello,

Here is the updated 

SPEC file: https://chandankumar.fedorapeople.org/python-XStatic-roboto-fontface.spec

SRPM : https://chandankumar.fedorapeople.org/python-XStatic-roboto-fontface-0.4.3.2-3.fc22.src.rpm

after fixing rpmlint.

Thanks,

Chandan Kumar

Thank you, remaining issues fixed.

package approved.

Could you please add me as co-maintainer to scm request?

New Package SCM Request
=======================
Package Name: python-XStatic-roboto-fontface
Short Description: XStatic-roboto-fontface is a roboto-fontface JavaScript library packaged for setuptools (easy_install) / pip.
Upstream URL: https://github.com/choffmeister/roboto-fontface-bower
Owners: chandankumar mrunge
Branches: f23
InitialCC:

Git done (by process-git-requests).

python-XStatic-roboto-fontface-0.4.3.2-3.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-15501

python-XStatic-roboto-fontface-0.4.3.2-3.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update python-XStatic-roboto-fontface'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-15501

Hi, can you please make also f22 release? rdo f22 build of python-django-horizon is failing.

python-XStatic-roboto-fontface-0.4.3.2-3.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8069

python-XStatic-roboto-fontface-0.4.3.2-3.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-15786

Lukas, did.

But note, delorean fails with
Error: No Package found for python-XStatic-bootswatch
Error: No Package found for python-XStatic-mdi
Error: No Package found for python-XStatic-roboto-fontface

The other packages are already submitted for a longer time, but still unavailable.

python-XStatic-roboto-fontface-0.4.3.2-3.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update python-XStatic-roboto-fontface'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-15786

python-XStatic-roboto-fontface-0.4.3.2-3.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update python-XStatic-roboto-fontface'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8069

python-XStatic-roboto-fontface-0.4.3.2-3.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.

python-XStatic-roboto-fontface-0.4.3.2-3.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

python-XStatic-roboto-fontface-0.4.3.2-4.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8192

python-XStatic-roboto-fontface-0.4.3.2-4.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update python-XStatic-roboto-fontface'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8192

python-XStatic-roboto-fontface-0.4.3.2-4.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.