Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1269039
Summary: | Review Request: python-weakrefmethod - A WeakMethod class for storing bound methods using weak references | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Chandan Kumar <chkumar> |
Component: | Package Review | Assignee: | Lukas Bezdicka <social> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | chkumar246, hguemar, karlthered, package-review, social |
Target Milestone: | --- | Flags: | social:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2015-12-08 19:53:29 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1243533 |
Description
Chandan Kumar
2015-10-06 06:14:17 UTC
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 3 files have unknown license. Detailed output of licensecheck in /home/social/1269039-python- weakrefmethod/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-weakrefmethod-1.0-1.fc24.noarch.rpm python-weakrefmethod-1.0-1.fc24.src.rpm python2-weakrefmethod.noarch: W: spelling-error %description -l en_US weakref -> weak ref, weak-ref, weakener python2-weakrefmethod.noarch: W: spelling-error %description -l en_US http -> HTTP python2-weakrefmethod.noarch: W: spelling-error %description -l en_US html -> HTML, ht ml, ht-ml python2-weakrefmethod.noarch: W: spelling-error %description -l en_US backport -> back port, back-port, backpacker python2-weakrefmethod.noarch: W: spelling-error %description -l en_US pypi -> typify python-weakrefmethod.src: W: spelling-error %description -l en_US weakref -> weak ref, weak-ref, weakener python-weakrefmethod.src: W: spelling-error %description -l en_US http -> HTTP python-weakrefmethod.src: W: spelling-error %description -l en_US html -> HTML, ht ml, ht-ml python-weakrefmethod.src: W: spelling-error %description -l en_US backport -> back port, back-port, backpacker python-weakrefmethod.src: W: spelling-error %description -l en_US pypi -> typify python-weakrefmethod.src:61: W: macro-in-comment %license 2 packages and 0 specfiles checked; 0 errors, 11 warnings. Rpmlint (installed packages) ---------------------------- python2-weakrefmethod.noarch: W: invalid-url URL: https://github.com/twang817/weakrefmethod <urlopen error [Errno -5] No address associated with hostname> 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Requires -------- python2-weakrefmethod (rpmlib, GLIBC filtered): python(abi) python-setuptools Provides -------- python2-weakrefmethod: python-weakrefmethod python2-weakrefmethod Source checksums ---------------- https://github.com/twang817/weakrefmethod/archive/1.0.tar.gz : CHECKSUM(SHA256) this package : 91f75447a7a11a7e0fc74d6e25fd3890eef21d17654c30ac9c6972d6f049faf2 CHECKSUM(SHA256) upstream package : 91f75447a7a11a7e0fc74d6e25fd3890eef21d17654c30ac9c6972d6f049faf2 Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -b 1269039 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 Python3 packages aren't required as it's backport of python3 class. License file is missing, issue is reported upstream https://github.com/twang817/weakrefmethod/issues/2 New Package SCM Request ======================= Package Name: python-weakrefmethod Short Description: This project is a backport of the WeakMethod class, and tests, for Python 2.6. The tests require the `unittest2 package <http://pypi.python.org/pypi/unittest2>`_. Upstream URL: https://github.com/twang817/weakrefmethod Owners: chandankumar social Branches: f23 f22 InitialCC: This SCM request method has been deprecated. Please see https://fedoraproject.org/wiki/PackageDB_admin_requests. Set assignee back to social as this review was granted. python-weakrefmethod-1.0.2-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-842872e318 python-weakrefmethod-1.0.2-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update python-weakrefmethod' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-842872e318 python-weakrefmethod-1.0.2-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. |