Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1270531

Summary: Review Request: gfeedline - Social Networking Client
Product: [Fedora] Fedora Reporter: Nuno Dias <nuno.dias>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: e, karlthered, package-review, samuel-rhbugs
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-03-25 10:37:24 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 177841    

Description Nuno Dias 2015-10-10 19:12:56 UTC
Spec URL: http://rpms.lip.pt/pub/f22/src/gfeedline.spec
SRPM URL: http://rpms.lip.pt/pub/f22/src/gfeedline-2.4.6-3.fc22.src.rpm
Description: 

GFeedLine is a social networking client, It supports Twitter, Facebook & Tumblr.

This is my first package, so I need a sponsor.

I already build the package in koji.
http://koji.fedoraproject.org/koji/taskinfo?taskID=11401143

Fedora Account System Username: nunodias

Comment 1 Haïkel Guémar 2015-10-10 20:13:59 UTC
All of the following are blockers.
* incorrect BuildRequires
BuildRequires:	python >= 2.6
Should be
BuildRequires: python2-devel python-setuptools
* Incorrect sources url, please read the following guideline
https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Git_Hosting_Services
* Drop this include
%include %{_rpmconfigdir}/macros.python
* Do not use %py_libdir but %python2_sitelib
* a lot of unowned directories, please read the following guidelines
https://fedoraproject.org/wiki/Packaging:UnownedDirectories
* No requires on runtime libraries, so your application will fail to run properly after installation. I think that most of your BuildRequires should be converted to Requires (after all, there is no test suite to run during package building)

Comment 2 Upstream Release Monitoring 2015-10-11 20:40:07 UTC
nunodias's scratch build of gfeedline-2.4.6-4.fc22.src.rpm for f22 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11410546

Comment 3 Nuno Dias 2015-10-11 20:53:51 UTC
Haïkel, thanks for the advices.

I addressed all the issues you mention, and created a new RPM, also build in koji. 

http://rpms.lip.pt/pub/f22/src/gfeedline-2.4.6-4.fc22.src.rpm
http://rpms.lip.pt/pub/f22/src/gfeedline.spec

Comment 4 Upstream Release Monitoring 2015-10-12 10:22:06 UTC
nunodias's scratch build of gfeedline-2.4.6-5.fc22.src.rpm for f22 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11413320

Comment 6 Upstream Release Monitoring 2015-10-24 13:45:16 UTC
nunodias's scratch build of gfeedline-2.4.6-7.fc22.src.rpm for f22 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11572371