Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1271133
Summary: | /usr/share/dpkg/default.mk contains wrong path | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jonas Jonsson <jonas> | ||||||
Component: | dpkg | Assignee: | Andrew Colin Kissa <andrew> | ||||||
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
Severity: | unspecified | Docs Contact: | |||||||
Priority: | unspecified | ||||||||
Version: | 22 | CC: | andrew, leamas.alec, sergio, vanmeeuwen+fedora | ||||||
Target Milestone: | --- | ||||||||
Target Release: | --- | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | dpkg-1.17.25-6.fc22 dpkg-1.17.25-6.fc23 | Doc Type: | Bug Fix | ||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2015-10-28 16:24:15 UTC | Type: | Bug | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Attachments: |
|
Description
Jonas Jonsson
2015-10-13 08:40:35 UTC
Created attachment 1083903 [details]
Patch against fedora scm repo.
Attaching fix in a patch. This uses Gnu make specific code to locate the directory and should be possible to usptream. An alternative would be to just hardcode the known path.
I have a copr repo with the fix included - "dnf copr enable leamas/dpkg-addons" to use it. It also contains a provisionary dh_python package. Created attachment 1083904 [details]
Revised patch with white-space junk scrubbed
Seeing your patch make me feel that it's not the right way to do this. git clone git://anonscm.debian.org/dpkg/dpkg.git cd dpkg git checkout 1.17.25 autoreconf -i ./configure make install DESTDIR="$(pwd)/foo" -j4 grep ^dpkg_datadir ./foo/usr/local/share/dpkg/default.mk dpkg_datadir = /usr/local/share/dpkg So it works just fine if I build it myself. It seems that there is something wrong with the spec file. Looking at the Makefile.am in the upstream repository they are doing the substituting at install time. The question is why doesn't this work when building for Fedora? https://anonscm.debian.org/cgit/dpkg/dpkg.git/tree/scripts/mk/Makefile.am Oh, and the problem is really this line in the spec file where the .mk files are copied from the source rather that letting "make install" deal with them. http://pkgs.fedoraproject.org/cgit/dpkg.git/tree/dpkg.spec#n167 Thanks , yeah , I found the bug. spec misses a make install-data to run a make hook something , I'm not finish yet , but soon I will give you some news ... Thanks dpkg-1.17.25-6.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-d6271da07d dpkg-1.17.25-6.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-fb6c575e25 (In reply to Jonas Jonsson from comment #5) > Oh, and the problem is really this line in the spec file where the .mk files > are copied from the source rather that letting "make install" deal with them. > > http://pkgs.fedoraproject.org/cgit/dpkg.git/tree/dpkg.spec#n167 yeah, my fault, hopefully only happened after update to 1.17.25 which does not affect epel builds . Thanks dpkg-1.17.25-6.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update dpkg' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-d6271da07d dpkg-1.17.25-6.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update dpkg' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-fb6c575e25 dpkg-1.17.25-6.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. dpkg-1.17.25-6.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. |