Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at

Bug 1272090

Summary: Review Request: nodejs-expect - Write better assertions
Product: [Fedora] Fedora Reporter: Jared Smith <jsmith.fedora>
Component: Package ReviewAssignee: Jeroen van Meeuwen <vanmeeuwen+fedora>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, piotr1212, vanmeeuwen+fedora
Target Milestone: ---Flags: vanmeeuwen+fedora: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-08-15 15:20:46 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On: 1272088, 1363789    
Bug Blocks: 956806, 1364637, 1387531    

Description Jared Smith 2015-10-15 13:24:44 UTC
Spec URL:
Description: Write better assertions
Fedora Account System Username: jsmith

Comment 1 Piotr Popieluch 2015-10-27 12:44:19 UTC
Title of but is nodejs-expect but the links point to nodejs-serve, please check what the correct module should be.

In nodejs-server there is a binary. This should be symlinked to /usr/bin/<name>

in %install:
mkdir -p %{buildroot}%{_bindir}
ln -s %{nodejs_sitelib}/%{srcname}/cli.js %{buildroot}%{_bindir}/%{srcname}

and %files:

Comment 2 Jared Smith 2015-11-04 15:18:25 UTC
Sorry, that was a mistake on my part.  I'll open a separate review for nodejs-server.  In the meantime, here are the Spec and SRPM for nodejs-expect:

Spec URL:

Comment 4 Jeroen van Meeuwen 2016-08-03 13:12:50 UTC
We're missing the build dependency of nodejs-is-equal (I can not find an existing review request for it either).

Comment 5 Jared Smith 2016-08-03 14:58:00 UTC
Ask and ye shall recieve... See RHBZ#1363789

Comment 6 Jeroen van Meeuwen 2016-08-07 10:03:36 UTC is not marked as a license file.

Comment 8 Gwyn Ciesla 2016-08-11 13:40:42 UTC
Package request has been approved:

Comment 9 Jared Smith 2016-08-15 15:20:46 UTC
In rawhide, closing bug