Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1275517
Summary: | Review Request: python-wand - python bindings for ImageMagick | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Dennis Chen <barracks510> |
Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | package-review, rbarlow, rdieter |
Target Milestone: | --- | Keywords: | Reopened |
Target Release: | --- | Flags: | rdieter:
fedora-review+
|
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2015-11-08 22:22:30 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Dennis Chen
2015-10-27 07:00:18 UTC
Hello Dennis! My review here is informal (as I am also currently seeking to become a package maintainer), but here are a few notes: 0) You've put a BuildRequires on python3-setuptools in the section that deals with Python 2 (probably a typo). 1) Python 3 systems will get Requires ImageMagick twice - I think the second Requires line is redundant. rpmlint only complains about a few spellings, but I think they are all OK so I wouldn't worry about them. Nice work! Welcome Dennis, I'd be happy to help review this (and sponsor you). Per Randy's comment's: 0. this is actually ok, it's already wrapped inside the conditional %if %{with python3} ... %endif 1. MUST: however, putting runtime dep here is wrong, you really want the Requires: ImageMagick down under %package -n python3-wand for cleanliness, and since this subpkg is already wrapped by %if %{with python3} itself, you could move both the runtime and build python3-related deps here, to look something like: %if %{with python3} %package -n python3-wand Summary: Ctypes-based simple MagickWand API binding for Python BuildRequires: python3-devel BuildRequires: python3-setuptools Requires: ImageMagick %description -n python3-wand Wand is a ctypes-based simple ImageMagick binding for Python. It doesn't cover all functionalities of MagickWand API currently. It works on Python 2.6, 2.7, 3.2, 3.3, and PyPy. %endif naming: ok 2. SHOULD consider omitting from %description the imo mostly-needless phrase: "It works on Python 2.6, 2.7, 3.2, 3.3, and PyPy." sources: kinda ok, but 3. SHOULD see https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Git_Tags about how to rename the source tarball, to use something like: https://github.com/dahlia/wand/archive/%{version}.tar.gz#/%{name}-%{version}.tar.gz instead license: ok macros: ok, mostly... 4. SHOULD omit from %install: rm -rf $RPM_BUILD_ROOT it is deprecated and no longer needed. scriptets: ok (n/a) Please fix all MUST items, and consider addressing SHOULD's, and we should be good to go. (In reply to Rex Dieter from comment #2) > 0. this is actually ok, it's already wrapped inside the conditional > %if %{with python3} > ... > %endif Hi Rex! I should have been clearer - the python3-setuptools is actually repeated. It appears first outside the conditional statement, and then again inside it. I suspect the first one was supposed to be python2-setuptools. Ah, I misinterpreted that detail, thanks. Let's amend point 0, 0. MUST adjust the initial BuildRequires: python3-setuptools present in the top/main pkg to: BuildRequires: python2-setuptools Hi Rex and Randy! Thanks for the feedback on the package. I have update the SPEC file and RPM to fix all the MUSTS and the SHOULDS. SPEC: http://unintel.tk/packaging/python-wand.spec SRPM: http://unintel.tk/packaging/python-wand-0.4.1-2.fc22.src.rpm Here is a link to the Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=11613811 barracks510's scratch build of python-wand-0.4.1-2.fc22.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11613811 APPROVED and sponsored, welcome to fedora. Please let me know if have any questions or need help with anything else. Next steps, https://fedoraproject.org/wiki/Join_the_package_collection_maintainers?rd=PackageMaintainers/Join#Add_Package_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner One other optional/non-blocker item I just noticed: 5. SHOULD remove BuildRequires: python-setuptools and BuildRequires: python3-setuptools turns out these are already implicitly pulled in by base python packages, and afaict, are currently not recommended to explicitly list per guidelines at: https://fedoraproject.org/wiki/Packaging:Python#BuildRequires python-wand-0.4.1-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-e15101edc9 python-wand-0.4.1-2.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-98115ca1a3 python-wand-0.4.1-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-fd9e8a4e7a python-wand-0.4.1-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update python-wand' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-e15101edc9 python-wand-0.4.1-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'yum --enablerepo=epel-testing update python-wand' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-fd9e8a4e7a python-wand-0.4.1-2.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update python-wand' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-98115ca1a3 python-wand-0.4.1-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. python-wand-0.4.1-2.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. python-wand-0.4.1-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |