Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1277505
Summary: | Review Request: jssc - Java Simple Serial Connector | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Damian Wrobel <dwrobel> |
Component: | Package Review | Assignee: | Dennis Chen <barracks510> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | barracks510, package-review, puntogil |
Target Milestone: | --- | Flags: | barracks510:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2015-12-13 04:23:23 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1194551 |
Description
Damian Wrobel
2015-11-03 13:34:53 UTC
dwrobel's scratch build of jssc-2.8.0-1.fc22.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11686916 Hi, I'd be happy to review this formally. MUST FIX: - The SPEC File does not match the source RPM. - JSSC seems to be have some code licensed GPLv3+ and others LGPLv3+. Using the FSF compatibility matrix, the combination must be distributed GPLv3+. Everything else seems fine. Please find updated both spec & srpm with fixes for all aforementioned issues. Spec URL: https://dwrobel.fedorapeople.org/projects/rpmbuild/SPECS/jssc.spec SRPM URL: https://dwrobel.fedorapeople.org/projects/rpmbuild/SRPMS/jssc-2.8.0-3.fc23.src.rpm dwrobel's scratch build of jssc-2.8.0-3.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11980040 Approved. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/jssc jssc-2.8.0-3.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-7e3ce91e3d jssc-2.8.0-3.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-b1ed622527 (In reply to Dennis Chen from comment #5) > Approved. Dennis, Thank you for reviewing this package. hi in install -d %{buildroot}%{jni} \ %{buildroot}%{_jnidir} \ %{buildroot}%{_jnidir} is not necessary maven-local or javapackages-local handle the jar file in "automatic" %{_jnidir}/%{name}.jar is also not usefull %attr(644, root, root) %{_datadir}/maven-metadata/%{name}.xml you should changes as %files -f .mfiles %license COPYING %doc README.txt %{jni}/ javadoc should be installed by %mvn_install -J javadoc and install -d %{buildroot}%{_javadocdir}/%{name} is no more necessary instead of maven-local you should use javapackages-local Regards, and sorry for the noise jssc-2.8.0-3.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update jssc' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-7e3ce91e3d jssc-2.8.0-3.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update jssc' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-b1ed622527 (In reply to gil cattaneo from comment #10) > instead of maven-local you should use javapackages-local > Gil, thanks for your hints, I started to look at them and compare with packaging guidelines [1] and I found that e.g. [1] clearly states the following: "Java packages MUST BuildRequire their respective build system: BuildRequires: maven-local for packages built with Maven" and there is no single reference that javapackages-local can be used as a substitute for maven-local in this case. So is there any specification on top of it which overwrites this or I misunderstood or missed something? [1]. https://fedoraproject.org/wiki/Packaging:Java#BuildRequires_and_Requires (In reply to Damian Wrobel from comment #13) > (In reply to gil cattaneo from comment #10) > > instead of maven-local you should use javapackages-local > > > Gil, thanks for your hints, I started to look at them and compare with > packaging guidelines [1] and I found that e.g. [1] clearly states the > following: > > "Java packages MUST BuildRequire their respective build system: > > BuildRequires: maven-local for packages built with Maven" > > and there is no single reference that javapackages-local can be used as a > substitute for maven-local in this case. Only if the package provide a pom.xml file and use that for build the package in this case you use only java-devel. javapackages-local is enough > So is there any specification on top of it which overwrites this or I > misunderstood or missed something? > > [1]. https://fedoraproject.org/wiki/Packaging:Java#BuildRequires_and_Requires see also https://fedorahosted.org/released/javapackages/doc/#_generic_java_builds regards Other trick Remove BuildRequires: jpackage-utils BuildRequires: maven-local Requires: java-headless Requires: jpackage-utils and add BuildRequires: javapackages-local because jpackage-utils is an alias of javapackages-tools . Damian javapackages-tools-doc package provides https://fedorahosted.org/released/javapackages/doc Hi, sorry for the noise. This is not necessary: Please, remove %doc %{_javadocdir}/%{name} Please, use: %files javadoc -f .mfiles-javadoc Please, remove Requires: java-headless Requires: jpackage-utils The requirements list is generated with Fedora java tools (javapackages-tools >> javapackages-local) and install license file also in this sub package e.g. %files javadoc -f .mfiles-javadoc %license COPYING %package javadoc Summary: Javadoc for %{name} package BuildArch: noarch Please, remove >> Requires: %{name} = %{version} This is "contrary" to the guidelines of Fedora is usually applied in this way. but in this case is not necessary/ useless Requires: %{name} = %{version}-%{release} jssc-2.8.0-3.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. jssc-2.8.0-3.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. |