Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1280141 (python-psychopy)
| Summary: | Review Request: python-psychopy - Psychophysics toolkit for Python | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Adrian Alves <aalves> |
| Component: | Package Review | Assignee: | Igor Raits <igor.raits> |
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | aalves, package-review, sanjay.ankur |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-08-22 10:27:45 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1290995 | ||
| Bug Blocks: | 201449 | ||
|
Description
Adrian Alves
2015-11-11 03:02:37 UTC
Before I will do full review fix major issues: psychopy/LICENSES.txt. You should unbundle those. For ttf - patch to use system -------------------------------------------------------------------------------- - pyparallel (http://pyserial.sourceforge.net/pyparallel.html). License: Python Software Foundation - quest (http://www.visionegg.org/Quest). License: BSD - psychopy/app/Resources/DejaVuSerif.ttf. License: BSD-like (see below for full list of terms) -------------------------------------------------------------------------------- I don't see any adventures why you packaging latest commit. It's not acceptable without good reason because since last release was only 44 commits. -------------------------------------------------------------------------------- Source0: https://github.com/psychopy/psychopy/archive/%{commit}/%{modname}-%{shortcommit}.tar.gz -------------------------------------------------------------------------------- You don't have any BuildRequires/Requires for this package. I opened only one file and already see dependency on wxPython. https://github.com/psychopy/psychopy/blob/master/psychopy/app/_psychopyApp.py From .travis.yml I see at least pygame, gevent, psutil, msgpack, pandas and many others. This wildcard I think not good, because I guess there only 1 directory. -------------------------------------------------------------------------------- %{python2_sitelib}/%{modname}* -------------------------------------------------------------------------------- If you're using version you should use macros! But I'd recommend to use %{python2_sitelib}/PsychoPy*.egg-info -------------------------------------------------------------------------------- %{python2_sitelib}/PsychoPy-1.83.1-py2.7.egg-info/* -------------------------------------------------------------------------------- Changelog for sure incorrect. Release is incorrect (you must bump version and use 0.1.git...., but don't do this and stick to release). And last BIG issue: You DONT run tests. You MUST. and one more comment:
- Package installs a %{name}.desktop using desktop-file-install or desktop-
file-validate if there is such a file.
- update-desktop-database is invoked in %post and %postun if package
contains desktop file(s) with a MimeType: entry.
Note: desktop file(s) with MimeType entry in python2-psychopy
See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-
database
ping? ping once more? Adrian, Would you like to continue the review? Otherwise I can submit the package for review to be included in neuro-fedora. Cheers, Ankur Closing this one too. We'll do a fresh review when time permits. |