Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1282082
| Summary: | python-flask-debugtoolbar: Python 3 support | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Francesco Frassinelli (frafra) <fraph24> | ||||||||
| Component: | python-flask-debugtoolbar | Assignee: | Yohan Graterol <yohangraterol92> | ||||||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | unspecified | Docs Contact: | |||||||||
| Priority: | unspecified | ||||||||||
| Version: | 24 | CC: | athoscribeiro, lbalhar, mhroncok, pviktori, yohangraterol92 | ||||||||
| Target Milestone: | --- | ||||||||||
| Target Release: | --- | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | python-flask-debugtoolbar-0.10.0-3.fc26 | Doc Type: | Bug Fix | ||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2016-09-07 10:51:12 UTC | Type: | Bug | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Bug Depends On: | |||||||||||
| Bug Blocks: | 1285816, 1333770 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Francesco Frassinelli (frafra)
2015-11-14 20:14:31 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 24 development cycle. Changing version to '24'. More information and reason for this action is here: https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora24#Rawhide_Rebase Yohan, do you need any help with adding Python 3 support? Created attachment 1182936 [details]
Patch adding python 3 support
Hello,
I prepared a patch to including subpackages for python 2 and 3 and also updated this package to the latest version.
Since this is my first python 3 porting attempt, it would be nice to review before applying.
I also changed the link where license and changelog files are retrieved from so we can have the ones for the correct version of the package.
Thanks
Here is a COPR build: https://copr.fedorainfracloud.org/coprs/ribeiro/fedora/build/406450/ Created attachment 1184327 [details] Patch adding python 3 support There were a few mistakes in the former patch: subpackages were named python-Flask* instead of python-flask* Here is an updated patch and a copr build. New COPR build: https://copr.fedorainfracloud.org/coprs/ribeiro/fedora/build/422739/ Hello. Your patch looks good to me, but I have two suggestions: - Could you use a global variable for 'flask-debugtoolbar', which is in specfile many times? (name, url, subpackages name ...) - It's better to use %license macro for license files What do you think about it? Created attachment 1184638 [details] Patch adding python 3 support (In reply to Lumír Balhar from comment #6) > Hello. > > Your patch looks good to me, but I have two suggestions: > > - Could you use a global variable for 'flask-debugtoolbar', which is in > specfile many times? (name, url, subpackages name ...) > - It's better to use %license macro for license files > > What do you think about it? I agree. I kept changes in the package not related to the python 3 porting to a minimum. Shouldn't it also require or at least recommend python-flask? Here is another patch with the proposed suggestions Thank you for your update. Patch is now ok and it can be pushed. There was no Require for python-flask so we can stay in this state. Also, the maintainer can add some Requires later. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=15047843 Yohan, do you mind if I push this? If you don't reply in a week, I assume it's OK. The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days |