Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1286625

Summary: [PATCH][tiff-load] Fix compilation on big endian arches
Product: [Fedora] Fedora Reporter: Rafael Fonseca <rdossant>
Component: gegl03Assignee: Debarshi Ray <debarshir>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: debarshir, nphilipp
Target Milestone: ---   
Target Release: ---   
Hardware: ppc64   
OS: Linux   
Whiteboard:
Fixed In Version: gegl03-0.3.4-2.fc23 gegl03-0.3.4-2.fc22 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-12-28 22:59:34 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 467765, 1071880    
Attachments:
Description Flags
Fix compilation on big endian none

Description Rafael Fonseca 2015-11-30 11:21:25 UTC
Created attachment 1100476 [details]
Fix compilation on big endian

Description of problem: because of a typo, gegl03 fails to build on big endian arches with the following error

tiff-load.c: In function 'load_RGBA':
tiff-load.c:508:17: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'end'
       guint row end = row * p->width + p->width;
                 ^
tiff-load.c:508:17: error: 'end' undeclared (first use in this function)
tiff-load.c:508:17: note: each undeclared identifier is reported only once for each function it appears in
tiff-load.c:509:7: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
       guint i;
       ^
tiff-load.c:511:31: error: 'row_end' undeclared (first use in this function)
       for (i = row_start; i < row_end; i++)
                               ^
Makefile:1302: recipe for target 'tiff_load_la-tiff-load.lo' failed


Version-Release number of selected component (if applicable): 0.3.4-1


How reproducible: always on ppc-koji


Additional info: reported upstream with patch supplied. Same patched added downstream for the time being. Please, apply on all relevant fedora versions.

Comment 1 Fedora Update System 2015-12-08 14:26:33 UTC
gegl03-0.3.4-2.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-7b0287814e

Comment 2 Fedora Update System 2015-12-08 14:27:42 UTC
gegl03-0.3.4-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-b1af2cfa63

Comment 3 Fedora Update System 2015-12-08 22:57:28 UTC
gegl03-0.3.4-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update gegl03'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-b1af2cfa63

Comment 4 Fedora Update System 2015-12-08 23:50:53 UTC
gegl03-0.3.4-2.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update gegl03'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-7b0287814e

Comment 5 Fedora Update System 2015-12-28 22:59:32 UTC
gegl03-0.3.4-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 6 Fedora Update System 2015-12-28 23:54:20 UTC
gegl03-0.3.4-2.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.