Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1288651 (OpenIGTLink)
| Summary: | Review Request: openigtlink - Implementation of the OpenIGTLink network communication protocol | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dmitry Mikhirev <mikhirev> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | ignatenko, package-review, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-02-02 21:10:57 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1276941 | ||
|
Description
Dmitry Mikhirev
2015-12-04 21:23:17 UTC
I'm sorry, forgot to paste URLs: Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/bizdelnick/neuro/OpenIGTLink.git/plain/OpenIGTLink.spec?id=dcd4b2f058890e46f74a31d47661e4ddeecb97b3 SRPM URL: https://copr-be.cloud.fedoraproject.org/results/bizdelnick/neuro/fedora-rawhide-x86_64/00143768-OpenIGTLink/OpenIGTLink-0-0.1.20151015gitccb2438.fc24.src.rpm The name should be lowercase [https://fedoraproject.org/wiki/Packaging:NamingGuidelines#General_Naming], it's hard to remember (or type) or those mixed-case letters. You could use a single doc directory: %global _docdir_fmt %{name} Don't repeat the package name in summary. It's also better to drop the article, listings look better without. I don't see any issues otherwise. > The name should be lowercase I hate mixed-case letters too, but the upstream always refers to this library as OpenIGTLink, like in ORBit example on the wiki page. The github repository (and source tarball archived from there) is also named in mixed-case. > Don't repeat the package name in summary. It is not a package name, it's a protocol name. Shouldn't the package summary for protocol implementation include the protocol name? Really, I don't know what to write there if not this... (In reply to Dmitry Mikhirev from comment #3) > > The name should be lowercase > I hate mixed-case letters too, but the upstream always refers to this > library as OpenIGTLink, like in ORBit example on the wiki page. The github > repository (and source tarball archived from there) is also named in > mixed-case. That's fine. You should use capitalized name in the description and other docs. Just the package name should be lowercase. > > Don't repeat the package name in summary. > It is not a package name, it's a protocol name. Shouldn't the package > summary for protocol implementation include the protocol name? Really, I > don't know what to write there if not this... OK, if the package name will be lowercase, it might make more sense to repeat the protocol name. Maybe Summary: implementation of the OpenIGTLink network protocol ? Thank you! I fixed evrything as you adviced. Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/bizdelnick/neuro/openigtlink.git/plain/openigtlink.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/bizdelnick/neuro/fedora-rawhide-x86_64/00155407-openigtlink/openigtlink-0-0.1.20151015gitccb2438.fc24.src.rpm + license is acceptable (BSD) + license file is present, %license is used + name is correct + scriptlets are OK + builds and installs fine + provides and requires look fine + recent version (git) + %check is present Package is APPROVED. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/openigtlink |