Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1289006 (python-pyactivetwo)
| Summary: | Review Request: python-pyactivetwo - Python library for reading signal from BioSemi ActiveTwo EEG device | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Igor Gnatenko <ignatenko> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-12-28 22:58:36 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1276941 | ||
|
Description
Igor Gnatenko
2015-12-07 08:34:40 UTC
.egg-info doesn't need to be deleted.
cp -p %{SOURCE1} → %autosetup ... -a1
Remove empty %check.
BR should be one-per-line.
- license is OK
- license file is present, %license is used
- new python packaging template is used
- provides/requires are ok
- latest version
- no scriptlets
- builds and installs OK
- fedora-review is happy
rpmlint:
3 packages and 0 specfiles checked; 0 errors, 0 warnings.
Package is APPROVED.
(In reply to Zbigniew Jędrzejewski-Szmek from comment #1) > .egg-info doesn't need to be deleted. Why? > > cp -p %{SOURCE1} → %autosetup ... -a1 ok > > Remove empty %check. ok > > BR should be one-per-line. I'm somehow grouping it... > > - license is OK > - license file is present, %license is used > - new python packaging template is used > - provides/requires are ok > - latest version > - no scriptlets > - builds and installs OK > - fedora-review is happy > > rpmlint: > 3 packages and 0 specfiles checked; 0 errors, 0 warnings. > > Package is APPROVED. (In reply to Igor Gnatenko from comment #2) > (In reply to Zbigniew Jędrzejewski-Szmek from comment #1) > > .egg-info doesn't need to be deleted. > Why? The guidelines say that egg *packages* cannot be distributed, but egg *metadata* (i.e. the directory) is not the same thing. It will be recreated, if it is deleted, but deleting it simply isn't necessary. > > BR should be one-per-line. > I'm somehow grouping it... I know. OTOH, diffs are less readable. Anyway, for a simple package like that it doesn't matter too much. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/python-pyactivetwo python-pyactivetwo-0.1-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-3cca7ecf2c python-pyactivetwo-0.1-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update python-pyactivetwo' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-3cca7ecf2c python-pyactivetwo-0.1-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. |