Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1291868
Summary: | SystemTap cannot find kernel tracepoints due to missing 32-bit ARM opcodes.h | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jeff Bastian <jbastian> | ||||
Component: | kernel | Assignee: | Kernel Maintainer List <kernel-maint> | ||||
Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | CC: | gansalmon, itamar, jonathan, kernel-maint, madhu.chinakonda, mchehab, pbrobinson, pwhalen, wcohen | ||||
Target Milestone: | --- | Keywords: | Patch | ||||
Target Release: | --- | ||||||
Hardware: | aarch64 | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2016-11-20 13:39:44 UTC | Type: | Bug | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 922257 | ||||||
Attachments: |
|
Description
Jeff Bastian
2015-12-15 19:03:43 UTC
Created attachment 1106134 [details]
proposed patch to include 32-bit arm opcodes.h
64-bit ARM opcodes.h references the 32-bit version:
$ cat arch/arm64/include/asm/opcodes.h
#include <../../arm/include/asm/opcodes.h>
This proposed patch includes the 32-bit ARM opcodes.h in the kernel-devel rpm.
An alternative to the patch in comment 1 might be to include all of 32-bit arm/include/* in kernel-devel for aarch64. I don't think it will hurt anything other than increasing the size of kernel-devel by 1.4MB. This will help to avoid problems in the future if more aarch64 headers reference the 32-bit version. cp -a --parents arch/arm/include $RPM_BUILD_ROOT/lib/modules/$KernelVer/build/ Committed your patch and pushed it out to all branches. The alternative of adding all of them is tempting, but I'd rather avoid that for now and go with only the known needed files. It'll mean we might hit this again, but I'd rather do that than get errant includes in a build just because they are there.
> 64-bit ARM opcodes.h references the 32-bit version:
> $ cat arch/arm64/include/asm/opcodes.h
> #include <../../arm/include/asm/opcodes.h>
>
> This proposed patch includes the 32-bit ARM opcodes.h in the kernel-devel
> rpm.
This file is already in the upstream kernel sources:
arch/arm/include/asm/opcodes.h
checking "git log arch/arm/include/asm/opcodes.h" on a upstream linus kernel checkout tells me it's been there since "Mon Dec 12 19:31:55 2011 +0100". So is the problem here that we're just not shipping it?
(In reply to Peter Robinson from comment #4) > > 64-bit ARM opcodes.h references the 32-bit version: > > $ cat arch/arm64/include/asm/opcodes.h > > #include <../../arm/include/asm/opcodes.h> > > > > This proposed patch includes the 32-bit ARM opcodes.h in the kernel-devel > > rpm. > > This file is already in the upstream kernel sources: > arch/arm/include/asm/opcodes.h > > checking "git log arch/arm/include/asm/opcodes.h" on a upstream linus kernel > checkout tells me it's been there since "Mon Dec 12 19:31:55 2011 +0100". So > is the problem here that we're just not shipping it? Yes. And Jeff's patch fixes it, which is what I committed today. |