Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1295015
Summary: | Many Packages create broken symbolic links - in this case Python34 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | John Dodson <jwadodson> | ||||||
Component: | python-urllib3 | Assignee: | Fedora Infrastructure SIG <infra-sig> | ||||||
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
Severity: | medium | Docs Contact: | |||||||
Priority: | unspecified | ||||||||
Version: | 22 | CC: | jberan, kevin, rbean, sagarun | ||||||
Target Milestone: | --- | ||||||||
Target Release: | --- | ||||||||
Hardware: | All | ||||||||
OS: | Linux | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | python-urllib3-1.15.1-3.fc23 python-urllib3-1.15.1-3.fc22 python-urllib3-1.15.1-3.fc24 | Doc Type: | Bug Fix | ||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2016-06-07 01:24:01 UTC | Type: | Bug | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Attachments: |
|
Description
John Dodson
2015-12-31 21:31:03 UTC
Moving to the right package. Any progress on this? The same problem exists in FC23... python3-urllib3.noarch 1.13.1-3.fc23 Sorry, this was not on my radar. Will try to get a fix out asap. I'm not sure how to deal with this one. I tried moving the symlinks to what I thought was the correct location, but the python3 byte compilation step seems to not like what I was doing. I'm attaching my patch and error logs in case anyone has an idea about what to do here. Created attachment 1137147 [details]
First attempt at a patch
Created attachment 1137148 [details]
Error log from mock when applying first attempt at a patch
So, looking at this... python3-six only provides the 'six.py' file, not the .pyc/.pyo versions (which I think is right for python3). So, what we want to do here is not link to those non existent files. Proposed patch: diff --git a/python-urllib3.spec b/python-urllib3.spec index a889122..9ce418f 100644 --- a/python-urllib3.spec +++ b/python-urllib3.spec @@ -12,7 +12,7 @@ Name: python-%{srcname} Version: 1.13.1 -Release: 3%{?dist} +Release: 4%{?dist} Summary: Python HTTP library with thread-safe connection pooling and file post License: MIT @@ -168,8 +168,6 @@ rm -rf %{buildroot}/%{python3_sitelib}/urllib3/packages/ssl_match_hostname/ mkdir -p %{buildroot}/%{python3_sitelib}/urllib3/packages/ ln -s ../../six.py %{buildroot}/%{python3_sitelib}/urllib3/packages/six.py -ln -s ../../six.pyc %{buildroot}/%{python3_sitelib}/urllib3/packages/six.pyc -ln -s ../../six.pyo %{buildroot}/%{python3_sitelib}/urllib3/packages/six.pyo cp %{SOURCE1} %{buildroot}/%{python3_sitelib}/urllib3/packages/ssl_match_hostname.py # Copy in six.py just for the test suite. @@ -222,6 +220,9 @@ rm -rf %{buildroot}/%{python3_sitelib}/__pycache__* %endif # with_python3 %changelog +* Wed Mar 16 2016 Ralph Bean <rbean> - 1.13.1-4 +- Fix broken symlinks in python3-urllib3 subpackage (#1295015). + * Fri Feb 26 2016 Ralph Bean <rbean> - 1.13.1-3 - Apply patch from upstream to fix ipv6. Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=13461212 If that looks ok to you, I can push it or you can. ;) Yes. Looks ok to me! Thanks for your efforts in fixing this. Will the package maintainers for the package that does need those symlinks be "warned" to do the right thing & create/remove them when appropriate? I guess we can post a bug when they don't ;-) Let's try it out. One tricky part to this is that while python3-six doesn't provide the .pyc/.pyo files that we're used to, it does provide some new ones under a __pycache__ directory. See 'rpm -qal python3-six' output: /usr/lib/python3.4/site-packages/__pycache__/six.cpython-34.pyc /usr/lib/python3.4/site-packages/__pycache__/six.cpython-34.pyo Yeah, confirmed. Applying the patch above ends up re-using the bundled __pycache__ files for six.py.. and if I remove them then it doesn't work at all. Still looking for another solution here. This package has changed ownership in the Fedora Package Database. Reassigning to the new owner of this component. Any news on this? I ended up applying Kevin's patch here: http://pkgs.fedoraproject.org/cgit/rpms/python-urllib3.git/commit/?id=646b32969a1288f24993b81fb3b80d1235f39ada as I just couldn't figure out another way. python-urllib3-1.15.1-2.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-6055c6f922 python-urllib3-1.15.1-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-5af58932b8 python-urllib3-1.15.1-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-d76350d8c5 python-urllib3-1.15.1-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-5af58932b8 python-urllib3-1.15.1-2.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-6055c6f922 python-urllib3-1.15.1-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-d76350d8c5 python-urllib3-1.15.1-3.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-bc843b3a8d python-urllib3-1.15.1-3.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-635f0ce6a3 python-urllib3-1.15.1-3.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-90cb798292 python-urllib3-1.15.1-3.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-635f0ce6a3 python-urllib3-1.15.1-3.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-bc843b3a8d python-urllib3-1.15.1-3.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-90cb798292 python-urllib3-1.15.1-3.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. python-urllib3-1.15.1-3.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. python-urllib3-1.15.1-3.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. |