Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1297550
Summary: | Review Request: golang-github-jmespath-go-jmespath - Golang implementation of JMESPath | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Ed Marshall <esm> |
Component: | Package Review | Assignee: | Matthias Runge <mrunge> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | esm, jchaloup, mrunge, package-review |
Target Milestone: | --- | Keywords: | Reopened |
Target Release: | --- | Flags: | mrunge:
fedora-review+
esm: needinfo- |
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2017-03-08 15:50:46 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1330110, 1256978, 1297679 |
Description
Ed Marshall
2016-01-11 20:17:27 UTC
*** Bug 1328739 has been marked as a duplicate of this bug. *** Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated". 659 files have unknown license. Detailed output of licensecheck in /home/mrunge/review/1297550-golang-github-jmespath-go- jmespath/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/gocode/src/github.com/jmespath/go- jmespath/cmd [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gocode/src, /usr/share/gocode/src/github.com/jmespath/go-jmespath/cmd, /usr/share/gocode, /usr/share/gocode/src/github.com [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang- github-jmespath-go-jmespath-devel , golang-github-jmespath-go- jmespath-unit-test-devel [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [-]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: golang-github-jmespath-go-jmespath-devel-0.2.2-1.fc25.noarch.rpm golang-github-jmespath-go-jmespath-unit-test-devel-0.2.2-1.fc25.x86_64.rpm golang-github-jmespath-go-jmespath-0.2.2-1.fc25.src.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Requires -------- golang-github-jmespath-go-jmespath-devel (rpmlib, GLIBC filtered): golang(github.com/stretchr/testify/assert) golang-github-jmespath-go-jmespath-unit-test-devel (rpmlib, GLIBC filtered): golang-github-jmespath-go-jmespath-devel Provides -------- golang-github-jmespath-go-jmespath-devel: golang(github.com/jmespath/go-jmespath) golang(github.com/jmespath/go-jmespath/fuzz) golang-github-jmespath-go-jmespath-devel golang-github-jmespath-go-jmespath-unit-test-devel: golang-github-jmespath-go-jmespath-unit-test-devel golang-github-jmespath-go-jmespath-unit-test-devel(x86-64) Source checksums ---------------- https://github.com/jmespath/go-jmespath/archive/3433f3ea46d9f8019119e7dd41274e112a2359a9/go-jmespath-3433f3e.tar.gz : CHECKSUM(SHA256) this package : 537dcc481e990390bf8e1be0710f82c7113d7b2982f7c30d20c12ce820040482 CHECKSUM(SHA256) upstream package : 537dcc481e990390bf8e1be0710f82c7113d7b2982f7c30d20c12ce820040482 Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -b 1297550 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 Please fix the unowned dir issue noted above. Otherwise looks good *** Bug 1327534 has been marked as a duplicate of this bug. *** [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/gocode/src/github.com/jmespath/go- jmespath/cmd [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gocode/src, /usr/share/gocode/src/github.com/jmespath/go-jmespath/cmd, /usr/share/gocode, /usr/share/gocode/src/github.com All dirs up to /usr/share/gocode/src/github.com/jmespath/go-jmespath/cmd are (should be owned) by golang compiler. The cmd is problematic. By the nature of the construct in %install section, github.com/jmespath/go-jmespath/cmd is skipped as it contains no go files. Opening issue on gofed [1]. Temporary fix is use this instead: # find all *.go but no *_test.go files and generate devel.file-list for file in $(find . -iname "*.go" \! -iname "*_test.go") ; do dirprefix=$(dirname $file) install -d -p %{buildroot}/%{gopath}/src/%{import_path}/$dirprefix cp -pav $file %{buildroot}/%{gopath}/src/%{import_path}/$file echo "%%{gopath}/src/%%{import_path}/$file" >> devel.file-list while [ "$dirprefix" != "." ]; do echo "%%dir %%{gopath}/src/%%{import_path}/$dirprefix" >> devel.file-list dirprefix=$(dirname $dirprefix) done done [1] https://github.com/gofed/gofed/issues/97 Hi Ed, any progress on this? This package is requirement for new cadvisor. I can regenerated the spec file if you don't have time for it. Jan Here is the update spec file if needed: Spec URL: https://jchaloup.fedorapeople.org/reviews/golang-github-jmespath-go-jmespath/golang-github-jmespath-go-jmespath.spec SRPM URL: https://jchaloup.fedorapeople.org/reviews/golang-github-jmespath-go-jmespath/golang-github-jmespath-go-jmespath-0-0.1.git0b12d6b.fc20.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=14163948 Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated". 660 files have unknown license. Detailed output of licensecheck in /home/mrunge/review/1297550-golang-github-jmespath-go- jmespath/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gocode/src, /usr/share/gocode, /usr/share/gocode/src/github.com [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang- github-jmespath-go-jmespath-devel , golang-github-jmespath-go- jmespath-unit-test-devel [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [-]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: golang-github-jmespath-go-jmespath-devel-0-0.1.git0b12d6b.fc25.noarch.rpm golang-github-jmespath-go-jmespath-unit-test-devel-0-0.1.git0b12d6b.fc25.x86_64.rpm golang-github-jmespath-go-jmespath-0-0.1.git0b12d6b.fc25.src.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Requires -------- golang-github-jmespath-go-jmespath-devel (rpmlib, GLIBC filtered): golang-github-jmespath-go-jmespath-unit-test-devel (rpmlib, GLIBC filtered): golang(github.com/stretchr/testify/assert) golang-github-jmespath-go-jmespath-devel Provides -------- golang-github-jmespath-go-jmespath-devel: golang(github.com/jmespath/go-jmespath) golang(github.com/jmespath/go-jmespath/fuzz) golang-github-jmespath-go-jmespath-devel golang-github-jmespath-go-jmespath-unit-test-devel: golang-github-jmespath-go-jmespath-unit-test-devel golang-github-jmespath-go-jmespath-unit-test-devel(x86-64) Source checksums ---------------- https://github.com/jmespath/go-jmespath/archive/0b12d6b521d83fc7f755e7cfc1b1fbdd35a01a74/go-jmespath-0b12d6b.tar.gz : CHECKSUM(SHA256) this package : ebd7bfbb34cae779d7c72c35d8779bb276a6646a27ee1a9f161711e6d94b70de CHECKSUM(SHA256) upstream package : ebd7bfbb34cae779d7c72c35d8779bb276a6646a27ee1a9f161711e6d94b70de Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1297550 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 PACKAGE APPROVED Thanks Matthias. Ed, if you have any other review request(s), you can add it/them to https://bugzilla.redhat.com/show_bug.cgi?id=1330110. golang-github-jmespath-go-jmespath-0-0.1.git0b12d6b.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-346c1bb4f6 golang-github-jmespath-go-jmespath-0-0.1.git0b12d6b.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-2501bb9e2d golang-github-jmespath-go-jmespath-0-0.1.git0b12d6b.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-aecfcea89c golang-github-jmespath-go-jmespath-0-0.1.git0b12d6b.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-9d51858366 golang-github-jmespath-go-jmespath-0-0.1.git0b12d6b.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-db45dd1350 golang-github-jmespath-go-jmespath-0-0.1.git0b12d6b.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-2501bb9e2d golang-github-jmespath-go-jmespath-0-0.1.git0b12d6b.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-346c1bb4f6 golang-github-jmespath-go-jmespath-0-0.1.git0b12d6b.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-db45dd1350 golang-github-jmespath-go-jmespath-0-0.1.git0b12d6b.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-aecfcea89c golang-github-jmespath-go-jmespath-0-0.1.git0b12d6b.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-9d51858366 golang-github-jmespath-go-jmespath-0-0.1.git0b12d6b.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. golang-github-jmespath-go-jmespath-0-0.1.git0b12d6b.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. golang-github-jmespath-go-jmespath-0-0.1.git0b12d6b.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. golang-github-jmespath-go-jmespath-0.2.2-0.1.gitbd40a43.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-6054ad1a6f golang-github-jmespath-go-jmespath-0.2.2-0.1.gitbd40a43.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-c976666327 golang-github-jmespath-go-jmespath-0.2.2-0.1.gitbd40a43.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-6054ad1a6f golang-github-jmespath-go-jmespath-0.2.2-0.1.gitbd40a43.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-c976666327 golang-github-jmespath-go-jmespath-0.2.2-0.1.gitbd40a43.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. |