Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1305340
Summary: | DNF message "Upgrading" at Zanata translation defect. is this Present Progressive ? or , is Gerund? Grammar problem. | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Ooyama Yosiyuki <qqke6wd9k> |
Component: | dnf | Assignee: | rpm-software-management |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | low | ||
Version: | 28 | CC: | digitalfreak, dmach, noriko.mizumoto, packaging-team-maint, piotrdrag, vmukhame |
Target Milestone: | --- | Keywords: | i18n, Translation, Triaged |
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | dnf-4.0.4-1.fc29 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2018-10-24 20:06:27 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1546484 |
Description
Ooyama Yosiyuki
2016-02-07 10:42:28 UTC
In addition to the above, "Installing" string, There is similar grammar problem, too. Please split this message ID to two IDs. too. And "Reinstalling" string, There is similar grammar problem, too. Please split this message ID to two IDs. too. And "Removing" string, There is similar grammar problem, too. Please split this message ID to two IDs. too. Would just splitting fix the problem? How can translator of eng string know which tense it should be? Can you please propose your solution via pull request [1]? I though about renaming "Installing" and so on in transaction summary to "To be installed", etc. But then the wording would be too complicated. [1] https://github.com/rpm-software-management/dnf The reason that I have reported to this bugzilla is, Because I was redirected from the DNF official bug-report link "https://github.com/rpm-software-management/dnf/wiki/Bug-Reporting". In this DNF official page, The link message "File a bug with" in the chapter "New feature request" redirects me to this Red-Hat Bugzilla page. Already I have reported this problem to Fedora-translation Japanese-team. And I was suggested by a team member to report this bug to DNF Official Site etc. https://lists.fedoraproject.org/archives/list/trans-ja@lists.fedoraproject.org/thread/UMV5B3SQSMH7LTXE36D53QWLSPIAGZ27/ Therefore , I looked at DNF official Website. And I was redirected from DNF Website to RedHat Bugzilla here. Sorry, mistake in writing. redirected -> transferred That is, I was transferred from DNF site to this Bugzilla page. Thank you, Mr.Jan Silhan. Is your suggestion about "To be installed" is alike next example ? (example) ================================================================================ Package Arch Version Repository Size ================================================================================ To be Installed: kernel x86_64 4.3.5-300.fc23 updates 53 k kernel-core x86_64 4.3.5-300.fc23 updates 20 M kernel-modules x86_64 4.3.5-300.fc23 updates 18 M To be Upgraded: createrepo_c x86_64 0.10.0-2.fc23 updates 76 k createrepo_c-libs x86_64 0.10.0-2.fc23 updates 95 k Transaction Summary ================================================================================ (/example) and (example) Transaction test succeeded. Running transaction Upgrading : selinux-policy-3.13.1-158.4.fc23.noarch 1/55 Upgrading : linux-firmware-20160204-61.git91d5dd13.fc23.noarch 2/55 Installing : kernel-core-4.3.5-300.fc23.x86_64 3/55 Installing : kernel-modules-4.3.5-300.fc23.x86_64 4/55 (/example) If the thing that you say is alike this example, I agree your idea. By the way, Sorry, now I don't know How to use GitHub. because I have never used GitHub and Pull-Request. This package has changed ownership in the Fedora Package Database. Reassigning to the new owner of this component. This message is a reminder that Fedora 23 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 23. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '23'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 23 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. This bug appears to have been reported against 'rawhide' during the Fedora 26 development cycle. Changing version to '26'. Is this still relevant? Honza and Jens It seems still the problem exists. I see that the problem is simply reuse of particular strings, and that it can possibly be resolved to stop reuse those strings. Can you check them? Last I heard (https://bugzilla.redhat.com/show_bug.cgi?id=1302935#c17), DNF couldn’t use context to disambiguate strings. Piotr, thanks for the comment. It seems similar problem with different string of Polish. I will restate here the strings below which this bug reporter filed against for Japanese. Upgrading #28; Refs: ../dnf/yum/rpmtrans.py:129 ../dnf/cli/output.py:1005 Downloading #23; Refs: ../dnf/yum/rpmtrans.py:124 ../dnf/cli/output.py:1008 Installing #429; Refs: ../dnf/cli/output.py:1079,../dnf/yum/rpmtrans.py:125 Reinstalling #431; Refs: ../dnf/cli/output.py:1081,../dnf/yum/rpmtrans.py:127 Removing #435; Refs: ../dnf/cli/output.py:1085 Could you please not use the above for both 'verbal noun' string and 'present progressive' string? Those should be split. I would like to suggest below if possible. For 'verbal noun' string Upgrade, Download, Install, Reinstall and Remove For 'present progressive' string Upgrading, Downloading, Installing, Reinstalling and Removing (In reply to Piotr Drąg from comment #13) > Last I heard (https://bugzilla.redhat.com/show_bug.cgi?id=1302935#c17), DNF > couldn’t use context to disambiguate strings. That’s not quite true: 1. True, Python core library does not provide a translation with context but it’s easy to implement. Here is an example: https://github.com/abrt/gnome-abrt/commit/15f1c9a 2. Bug 1302935 is fixed, how did they do it? (In reply to Rafal Luzynski from comment #15) > That’s not quite true: > > 1. True, Python core library does not provide a translation with context but > it’s easy to implement. Here is an example: > https://github.com/abrt/gnome-abrt/commit/15f1c9a > That’s interesting. I would love it if DNF could do the same. > 2. Bug 1302935 is fixed, how did they do it? https://bugzilla.redhat.com/show_bug.cgi?id=1302935#c15 is still how DNF looks like. We are in F29 cycle, any plan to fix? I would be happy to fix it but the only problem is lack of time. Is there an upstream ticket opened for this? Can anybody fix it already using my hints provided in comment 15? I have started working on this. My work is not yet finished but it is already possible to preview what changes would be in the *.po files. Here are some excerpts for Czech, Japanese, and Polish languages. ========================================================================= diff --git a/po/cs.po b/po/cs.po index 5ed5274d..439cc809 100644 --- a/po/cs.po +++ b/po/cs.po -#: ../dnf/cli/output.py:1072 ../dnf/transaction.py:78 +#. Translators: This is for a single package currently being downgraded. +#: ../dnf/transaction.py:79 +#, fuzzy +msgctxt "currently" +msgid "Downgrading" +msgstr "Snížení verze" + +#. Traslators: This is for a list of packages to be downgraded. +#: ../dnf/cli/output.py:1078 +#, fuzzy +msgctxt "summary" msgid "Downgrading" msgstr "Snížení verze" @@ -1100,15 +1110,25 @@ msgstr "Instalované balíčky %s%s nejsou dostupné" msgid "Installed size: %s" msgstr "Velikost po nainstalování: %s" -#: ../dnf/cli/output.py:1063 ../dnf/transaction.py:80 +#. Translators: This is for a single package currently being installed. +#: ../dnf/transaction.py:82 +#, fuzzy +msgctxt "currently" msgid "Installing" msgstr "K instalaci" -#: ../dnf/cli/output.py:1067 +#. Traslators: This is for a list of packages to be installed. +#: ../dnf/cli/output.py:1065 +#, fuzzy +msgctxt "summary" +msgid "Installing" +msgstr "K instalaci" + -#: ../dnf/cli/output.py:1065 ../dnf/transaction.py:83 +#. Translators: This is for a single package currently being reinstalled. +#: ../dnf/transaction.py:86 +#, fuzzy +msgctxt "currently" +msgid "Reinstalling" +msgstr "K přeinstalování" + +#. Traslators: This is for a list of packages to be reinstalled. +#: ../dnf/cli/output.py:1069 +#, fuzzy +msgctxt "summary" msgid "Reinstalling" msgstr "K přeinstalování" -#: ../dnf/cli/output.py:1064 ../dnf/transaction.py:87 +#. Translators: This is for a single package currently being upgraded. +#: ../dnf/transaction.py:91 +#, fuzzy +msgctxt "currently" msgid "Upgrading" msgstr "K aktualizaci" -#: ../dnf/cli/output.py:1743 ../dnf/cli/output.py:1745 +#. Traslators: This is for a list of packages to be upgraded. +#: ../dnf/cli/output.py:1067 +#, fuzzy +msgctxt "summary" +msgid "Upgrading" +msgstr "K aktualizaci" + diff --git a/po/ja.po b/po/ja.po index a5bf54de..ebd680e8 100644 --- a/po/ja.po +++ b/po/ja.po -#: ../dnf/cli/output.py:1072 ../dnf/transaction.py:78 +#. Translators: This is for a single package currently being downgraded. +#: ../dnf/transaction.py:79 +#, fuzzy +msgctxt "currently" +msgid "Downgrading" +msgstr "ダウングレード" + +#. Traslators: This is for a list of packages to be downgraded. +#: ../dnf/cli/output.py:1078 +#, fuzzy +msgctxt "summary" msgid "Downgrading" msgstr "ダウングレード" @@ -1075,15 +1085,25 @@ msgstr "インストール済みパッケージ %s%s は利用できません。 msgid "Installed size: %s" msgstr "パッケージ展開後のサイズ: %s" -#: ../dnf/cli/output.py:1063 ../dnf/transaction.py:80 +#. Translators: This is for a single package currently being installed. +#: ../dnf/transaction.py:82 +#, fuzzy +msgctxt "currently" msgid "Installing" msgstr "インストール" -#: ../dnf/cli/output.py:1067 +#. Traslators: This is for a list of packages to be installed. +#: ../dnf/cli/output.py:1065 +#, fuzzy +msgctxt "summary" +msgid "Installing" +msgstr "インストール" + -#: ../dnf/cli/output.py:1065 ../dnf/transaction.py:83 +#. Translators: This is for a single package currently being reinstalled. +#: ../dnf/transaction.py:86 +#, fuzzy +msgctxt "currently" +msgid "Reinstalling" +msgstr "再インストール" + +#. Traslators: This is for a list of packages to be reinstalled. +#: ../dnf/cli/output.py:1069 +#, fuzzy +msgctxt "summary" msgid "Reinstalling" msgstr "再インストール" -#: ../dnf/cli/output.py:1064 ../dnf/transaction.py:87 +#. Translators: This is for a single package currently being upgraded. +#: ../dnf/transaction.py:91 +#, fuzzy +msgctxt "currently" msgid "Upgrading" msgstr "アップグレード" -#: ../dnf/cli/output.py:1743 ../dnf/cli/output.py:1745 +#. Traslators: This is for a list of packages to be upgraded. +#: ../dnf/cli/output.py:1067 +#, fuzzy +msgctxt "summary" +msgid "Upgrading" +msgstr "アップグレード" + +#: ../dnf/cli/output.py:1749 ../dnf/cli/output.py:1751 msgid "User :" msgstr "ユーザー :" diff --git a/po/pl.po b/po/pl.po index 1288c95c..c106be23 100644 --- a/po/pl.po +++ b/po/pl.po -#: ../dnf/cli/output.py:1072 ../dnf/transaction.py:78 +#. Translators: This is for a single package currently being downgraded. +#: ../dnf/transaction.py:79 +#, fuzzy +msgctxt "currently" +msgid "Downgrading" +msgstr "Instalowanie poprzedniej wersji" + +#. Traslators: This is for a list of packages to be downgraded. +#: ../dnf/cli/output.py:1078 +#, fuzzy +msgctxt "summary" msgid "Downgrading" msgstr "Instalowanie poprzedniej wersji" @@ -1108,15 +1118,25 @@ msgstr "Zainstalowany pakiet %s%s jest niedostępny." msgid "Installed size: %s" msgstr "Rozmiar po zainstalowaniu: %s" -#: ../dnf/cli/output.py:1063 ../dnf/transaction.py:80 +#. Translators: This is for a single package currently being installed. +#: ../dnf/transaction.py:82 +#, fuzzy +msgctxt "currently" msgid "Installing" msgstr "Instalowanie" -#: ../dnf/cli/output.py:1067 +#. Traslators: This is for a list of packages to be installed. +#: ../dnf/cli/output.py:1065 +#, fuzzy +msgctxt "summary" +msgid "Installing" +msgstr "Instalowanie" + -#: ../dnf/cli/output.py:1065 ../dnf/transaction.py:83 +#. Translators: This is for a single package currently being reinstalled. +#: ../dnf/transaction.py:86 +#, fuzzy +msgctxt "currently" +msgid "Reinstalling" +msgstr "Ponowne instalowanie" + +#. Traslators: This is for a list of packages to be reinstalled. +#: ../dnf/cli/output.py:1069 +#, fuzzy +msgctxt "summary" msgid "Reinstalling" msgstr "Ponowne instalowanie" -#: ../dnf/cli/output.py:1064 ../dnf/transaction.py:87 +#. Translators: This is for a single package currently being upgraded. +#: ../dnf/transaction.py:91 +#, fuzzy +msgctxt "currently" msgid "Upgrading" msgstr "Aktualizowanie" -#: ../dnf/cli/output.py:1743 ../dnf/cli/output.py:1745 +#. Traslators: This is for a list of packages to be upgraded. +#: ../dnf/cli/output.py:1067 +#, fuzzy +msgctxt "summary" +msgid "Upgrading" +msgstr "Aktualizowanie" + ========================================================================= Would anything like that be helpful? I've just made a pull request: https://github.com/rpm-software-management/dnf/pull/1201 but few more things are confusing for me. 1. There is another message: 'Obsoleting' which appears 3 times. Should it be disambiguated? Should it have 2 different translations or 3? If 2, which are the same? 2. There is a message 'Erasing' and has a comment: "TODO: 'Removing'?" Does it mean that the original author would like to use the word 'Removing' but has not used to avoid ambiguity with 'Removing'? Now it is possible to use 'Removing' everywhere. Note that 'Downloading' appears only once now and therefore is not ambiguous. Thanks for working on this, Rafal! If it gets accepted, can we extend it to fix also these (there may be more)? https://bugzilla.redhat.com/show_bug.cgi?id=1302935#c15 https://bugzilla.redhat.com/show_bug.cgi?id=1585509 https://github.com/rpm-software-management/dnf/pull/792#issuecomment-297131137 (In reply to Piotr Drąg from comment #21) > Thanks for working on this, Rafal! If it gets accepted, can we extend it to > fix also these (there may be more)? > > https://bugzilla.redhat.com/show_bug.cgi?id=1302935#c15 I'd like to take a closer look at this issue. Possible answers: 1. Not directly because it needs plurals with contexts. But it will be easy to implement following the same pattern. 2. Possibly it is incorrect to use plurals at all in this context and therefore the issue will disappear (or will be reduced to a simple disambiguation). > https://bugzilla.redhat.com/show_bug.cgi?id=1585509 I was not aware of this. Probably yes, easily. > https://github.com/rpm-software-management/dnf/pull/792#issuecomment- > 297131137 I was not aware of this, either. I think that disambiguation will be helpful but more work will be needed for that issue. BTW, there were some problems in my pull request as spotted by the DNF Bot but I've resolved them. Any feedback from human reviewers? This bug has been fixed upstream and the updated dnf.pot file has been pushed to Zanata today. Translators, please update your translations. Most likely it will be fixed in 3.6.1 or 3.6.2 release. However, I don't know which versions of Fedora will receive this update. Thank you Rafal, I updated Japanese, and sent the mail asking other language teams to give an update. dnf 3.6.1 containing this fix in software but not in translations has just arrived to Fedora 29. As some translations including Japanese have been fixed in Zanata after the release, maintainers please: * pull the translations from Zanata, * make a bugfix release, * push it to Fedora 29 and Rawhide, * mark this bug as fixed. BTW, this means that translations in the most up-to-date release are incomplete now. |