Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1306634

Summary: dahdi-tools-2.10.0-7.fc24 FTBFS: 'rcsid' defined but not used [-Werror=unused-const-variable]
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: dahdi-toolsAssignee: Petr Pisar <ppisar>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 24CC: bruno, itamar, jeff, releng
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://koji.fedoraproject.org/koji/buildinfo?buildID=717407
Whiteboard:
Fixed In Version: dahdi-tools-2.10.0-8.fc25 dahdi-tools-2.10.0-8.fc24 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-04-04 17:25:19 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1305208    

Description Petr Pisar 2016-02-11 13:54:32 UTC
dahdi-tools-2.10.0-7.fc24 fails to build in F24:

gcc -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic -I. -Ixtalk -Wall -Werror   -c -o astribank_usb.o astribank_usb.c
dahdi_registration syntax OK
astribank_usb.c:37:19: error: 'rcsid' defined but not used [-Werror=unused-const-variable]
 static const char rcsid[] = "$Id$";
                   ^~~~~

This seems to be triggered by GCC 6.

Comment 1 Petr Pisar 2016-02-17 07:07:46 UTC
*** Bug 1307417 has been marked as a duplicate of this bug. ***

Comment 2 Jan Kurik 2016-02-24 14:29:48 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 24 development cycle.
Changing version to '24'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora24#Rawhide_Rebase

Comment 3 Petr Pisar 2016-03-30 08:11:39 UTC
Latest upstream version is 2.11.1. It contains substantial changes and the offending file is not there anymore. Git tree has a commit:

commit f105a09eda3a3b832078194e7ece902271a8d7b7
Author: Tzafrir Cohen <tzafrir.cohen>
Date:   Tue Jan 26 15:12:30 2016 +0200

    Remove rcsid: Unused since move to Git
    
    * While technically Git can support $ID keywords, in practice they are not
      used.
    * GCC now give a warning about ''rcsid' defined but not used' for some
      of those.
    
    Let's just remove the unused rcsid.

that removes the rcsid definitions and prints in usage outputs.

Comment 4 Fedora Update System 2016-03-30 09:04:07 UTC
dahdi-tools-2.10.0-8.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-d9910060d0

Comment 5 Fedora Update System 2016-03-30 22:25:59 UTC
dahdi-tools-2.10.0-8.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-d9910060d0

Comment 6 Fedora Update System 2016-04-04 17:25:16 UTC
dahdi-tools-2.10.0-8.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.