Bug 1306794

Created attachment 1123249 [details]
[patch] Update to 2.1.0 (#1306794)

Scratch build completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12945759

Latest upstream release: 2.2.0
Current version/release in rawhide: 2.0.0-2.fc24
URL: https://github.com/openstack/python-gnocchiclient

Please consult the package updates policy before you issue an update to a stable branch: https://fedoraproject.org/wiki/Updates_Policy

More information about the service that created this bug can be found at: https://fedoraproject.org/wiki/Upstream_release_monitoring

Please keep in mind that with any upstream change, there may also be packaging changes that need to be made. Specifically, please remember that it is your responsibility to review the new version to ensure that the licensing is still correct and that no non-free or legally problematic items have been added upstream.

Created attachment 1130501 [details]
[patch] Update to 2.2.0 (#1306794)

Scratch build completed http://koji.fedoraproject.org/koji/taskinfo?taskID=13126726

Upstream, this software supports Python 3. Please provide a Python 3
package for Fedora.


According to the Python packaging guidelines [0], software must be
packaged for Python 3 if upstream supports it.
The guidelines give detailed information on how to do this, and even
provide an example spec file [1].

The current best practice is to provide subpackages for the two Python
versions (called "Common SRPM" in the guidelines). Alternatively, if
nothing depends on your Python2 package, you can just switch to Python 3
entirely.

It's ok to do this in Rawhide only, however, it would be greatly
appreciated if you could push it to Fedora 24 as well.


If anything is unclear, or if you need any kind of assistance with the
porting, you can ask on IRC (#fedora-python on Freenode), or reply here.
We'll be happy to help!


[0] https://fedoraproject.org/wiki/Packaging:Python
[1] https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file

hguemar's python-gnocchiclient-2.2.0-1.fc25 completed http://koji.fedoraproject.org/koji/buildinfo?buildID=754969

Hello Pradeep,

Do you need any help adding Python 3 support to the RPM?

If you need more instructions, a [guide] for porting Python-based RPMs is available.

[guide] http://python-rpm-porting.readthedocs.org/en/latest/index.html

Thanks, I'll look into adding py3 support this week.

pkilambi's python-gnocchiclient-2.2.0-2.fc25 completed http://koji.fedoraproject.org/koji/buildinfo?buildID=761476

Hi Pradeep!

Thank you very much for taking the time to port your package!

I've seen you already pushed a ported spec file for rawhide, there is just a slight hiccup: Your `python3-gnocchiclient` subpackage depends on Python 3 as it should, but also on /usr/bin/python2.

This is very likely just a forgotten shebang which is not very troublesome to fix. I suggest reading the section on Shebangs on the Python RPM Porting Guide:

http://python-rpm-porting.readthedocs.io/en/latest/application-modules.html#are-shebangs-dragging-you-down-to-python-2

Thank you for your time!

The issue here is that both packages bundle the binary, while only the python 3 should have it as stated in [0]

[0] https://fedoraproject.org/wiki/Packaging:Python#Naming

Hi Pradeep!
Charalampos is correct, here is a list of binaries in each package:

rpm -ql python2-gnocchiclient
/usr/bin/gnocchi
/usr/bin/gnocchiclient-2
/usr/bin/gnocchiclient-2.7
/usr/bin/gnocchiclient-3
/usr/bin/gnocchiclient-3.5

rpm -ql python3-gnocchiclient
/usr/bin/gnocchi
/usr/bin/gnocchiclient-2
/usr/bin/gnocchiclient-2.7
/usr/bin/gnocchiclient-3
/usr/bin/gnocchiclient-3.5
/usr/bin/python3-gnocchi



That is very bad, it'll cause a whole lot of problems. To fix it, you should figure out if the binaries work the same regardless of which version of Python they are run on (very likely). If they indeed are not reliant on the Python version, here's how they should be packaged:

Python 2:
no binaries

Python 3:
/usr/bin/gnocchi
/usr/bin/gnocchiclient



On the other hand, in the unlikely case that the binaries behave differently on Python 2 and 3, they should be packaged thus:

Python 2
/usr/bin/gnocchi
/usr/bin/gnocchi-2
/usr/bin/gnocchi-2.7
/usr/bin/gnocchiclient
/usr/bin/gnocchiclient-2
/usr/bin/gnocchiclient-2.7

Python 3
/usr/bin/gnocchi-3
/usr/bin/gnocchi-3.5
/usr/bin/gnocchiclient-3
/usr/bin/gnocchiclient-3.5

Nothing else and nothing more. The actual executables should lie at the path with the full version (2.7, 3.5), the rest should be symlinks to these. See the Python RPM Porting Guide [0] for more details on this case.

[0] /usr/bin/gnocchiclient-3.5

This is now fixed in python-gnocchiclient-2.3.1-2

rawhide packages are built: 

http://koji.fedoraproject.org/koji/buildinfo?buildID=773785

i'll push an update to bodhi.

python-gnocchiclient-2.3.1-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-18c3da0320

python-gnocchiclient-2.3.1-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-18c3da0320