Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1307300

Summary: SDL2_gfx: FTBFS in rawhide
Product: [Fedora] Fedora Reporter: Fedora Release Engineering <releng>
Component: SDL2_gfxAssignee: Lubomir Rintel <lkundrak>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 24CC: ignatenko, lkundrak, yselkowi
Target Milestone: ---Keywords: Patch
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: SDL2_gfx-1.0.1-4.fc24 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-03-07 19:02:11 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1253930    
Bug Blocks: 1305208    
Attachments:
Description Flags
build.log
none
root.log
none
state.log
none
Patch for rawhide and f24 none

Description Fedora Release Engineering 2016-02-13 20:58:57 UTC
Your package SDL2_gfx failed to build from source in current rawhide.

http://koji.fedoraproject.org/koji/taskinfo?taskID=12805150

For details on mass rebuild see https://fedoraproject.org/wiki/Fedora_24_Mass_Rebuild

Comment 1 Fedora Release Engineering 2016-02-13 20:58:59 UTC
Created attachment 1123970 [details]
build.log

Comment 2 Fedora Release Engineering 2016-02-13 20:59:01 UTC
Created attachment 1123971 [details]
root.log

Comment 3 Fedora Release Engineering 2016-02-13 20:59:02 UTC
Created attachment 1123972 [details]
state.log

Comment 4 Igor Gnatenko 2016-02-18 09:35:21 UTC
it is completely ignores LDFLAGS in test.

Conclusion - rewrite that fuckin buildsystem.

Comment 5 Yaakov Selkowitz 2016-02-19 21:59:56 UTC
(In reply to Igor Gnatenko from comment #4)
> it is completely ignores LDFLAGS in test.

Actually, the issue is SDL2_gfx 1.0.1 added a dependency on libSDL2_test, a static library which should be shipped in SDL2-devel but is mistakenly removed.

Comment 6 Igor Gnatenko 2016-02-20 09:05:05 UTC
*** Unable to find SDL2_gfx library

this is different issue. and I am able to pass all tests without any static libraries. problem in their fuckin autocrap. If Lubomir will not fix it in next week - I will just replace autotools with something better.

Comment 7 Yaakov Selkowitz 2016-02-21 02:39:20 UTC
(In reply to Igor Gnatenko from comment #6)
> *** Unable to find SDL2_gfx library
> 
> this is different issue. and I am able to pass all tests without any static
> libraries.

I ran a mock build, and the *cause* of that error is the -lSDL2_test link flag which causes the link to fail.  This was added as a requirement of the testsuite prior to 1.0.1:

https://sourceforge.net/p/sdl2gfx/code/17/

> If Lubomir will not fix it in next week - I will just replace autotools with 
> something better.

That won't be necessary.  The proper fix is to include libSDL2_test.a in SDL2-devel.

Comment 8 Jan Kurik 2016-02-24 14:32:38 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 24 development cycle.
Changing version to '24'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora24#Rawhide_Rebase

Comment 9 Yaakov Selkowitz 2016-02-25 22:15:28 UTC
Created attachment 1130672 [details]
Patch for rawhide and f24

- Fix build of testsuite (#1307300)
- Disable tests which require --batch support not in SDL2_test

Comment 10 Yaakov Selkowitz 2016-02-25 22:16:09 UTC
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=13131147

Comment 11 Upstream Release Monitoring 2016-03-07 18:09:35 UTC
yselkowitz's SDL2_gfx-1.0.1-4.fc25 completed http://koji.fedoraproject.org/koji/buildinfo?buildID=742668