Bug 1307871

Created attachment 1125674 [details]
build.log

Created attachment 1125675 [details]
root.log

Created attachment 1125676 [details]
state.log

This bug appears to have been reported against 'rawhide' during the Fedora 24 development cycle.
Changing version to '24'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora24#Rawhide_Rebase

Created attachment 1134591 [details]
Patch to fix the FTBFS

This FTBFS is caused by a seemingly obvious bug in the source code, gcc-6 now treats as an error (cf. attachment).

Unless somebody objects, I will apply this patch in the attachment (against Fedora git master) and build the package in near future.

Upstream has fixed this in Github and it will be in the next release.

If this is the only change required and if it matches what upstream has in Github then you are more than welcome to update the package with this patch.

(In reply to Daniel Pocock from comment #6)
> Upstream has fixed this in Github and it will be in the next release.

I can't spot any fix to this bug upstream's git.

Also, 4.9.3 is still failing with same FTBFS:
...
displays/dspBookings.cpp: In member function 'virtual void dspBookings::sViewOrder()':
displays/dspBookings.cpp:163:52: error: no matching function for call to 'salesOrder::viewSalesOrder(int, bool)'
   salesOrder::viewSalesOrder(list()->altId(), false);
...

This is the message I received from upstream:

"I have seen this before. It's a bad method call that passes a boolean where a pointer is expected. It's been fixed in 4_10_x by simply removing the 2nd arg to salesOrder::viewSalesOrder() at https://github.com/xtuple/qt-client/blob/v4.9.2/guiclient/displays/dspBookings.cpp#L163"

Maybe it is in the commit from 20 May 2015:

https://github.com/xtuple/qt-client/commits/4_10_x/guiclient/displays/dspBookings.cpp

Upstream sources have been tagged v4.9.4 to address this problem: https://github.com/xtuple/qt-client/releases/tag/v4.9.4
Unlike most xTuple releases, the 4.9.4 client expects to talk to a 4.9.3 database.

Gil, thanks for addressing this issue

Ralf, would you possibly have time to fetch 4.9.4 from the tag in Github and see if it builds OK?  I have more travel over the next two weeks for FOSSASIA so I didn't want to upload something today if I won't be able to respond to any other issues that arise.

pocock's postbooks-4.9.5-9.fc25 completed http://koji.fedoraproject.org/koji/buildinfo?buildID=760247

postbooks-4.9.5-9.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3f3a320414

postbooks-4.9.5-9.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-fa5678069b

postbooks-4.9.5-9.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-3f3a320414

postbooks-4.9.5-9.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-fa5678069b

I can confirm that the package is installed correctly on Fedora 23 using Fedora testing repository. However, program is still unusable due to GUI glitches which hide menus and options (as per reported in bug https://www.xtuple.org/xtincident/view/bugs/27099)

Juan, thanks for the feedback.  I haven't ever seen the GUI glitches on Debian, I've asked xTuple if they can comment on why it happens on Fedora.  Is there any chance you could test the F24 update and give feedback in the xTuple bug tracker if you see the same problem?  Did you ever use the packages on F22 or other versions as well?  Please comment further in the xTuple bug tracker as this bug is only for the FTBFS issue.

postbooks-4.9.5-9.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-0c3e0809cd

postbooks-4.9.5-9.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

postbooks-4.9.5-9.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

postbooks-4.9.5-9.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-0c3e0809cd

postbooks-4.9.5-9.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.